Collaborator nominations

[Trott]

Feel free to nominate yourself or anyone else as long as a reasonable case can be made that the nominee has made significant and valuable contributions.

Ultimate decisions about Collaborator nominations are made by the CTC.

Factors that get reviewed include (but are not limited to):

• commits
• open pull requests and issues
• comments on issues and pull requests
• participation in workgroups, IRC, and elsewhere in the project and the community

If we're missing valuable contributors because there are factors we're not considering, we certainly want to know about it! Leave a comment!

At this time, we have the following nominee:

• Yuta Hiroto (@abouthiroppy)

[gibfahn]

I'd nominate @vsemozhetbyt , who's been pretty active on the documentation side (both in commits and Issues). I had assumed he was a collaborator until #11110 (comment).

@vsemozhetbyt let me/us know if you'd be interested!

[vsemozhetbyt]

@gibfahn Thank you. I was asked about this some months ago, and I've refused. I was — and am — afraid to get any potentially harmful rights and to seem competent collaborator, because of lack of knowledge and experience (I've messed up PRs sometimes as my git skills are pretty primitive).

But I can see that I need every now and then to nudge other competent collaborators for landing my rather simple PRs, and this worries me. So I would like to step up my responsibility for overall simplification and time economy. However, I would try to use my rights with big caution. And I would be happy with any community's decision)

[gibfahn]

@vsemozhetbyt I think worrying about the damage you could accidentally do as a collaborator is a good thing, if you weren't worried at all that would scare me!

The thing to remember is that you can take it at your own pace. Being a collaborator doesn't mean you have to land all your own PRs and do arcane git incantations on release branches, to start with you can do exactly what you're doing now, but now if you review doc PRs, your word will carry more weight (reflecting your experience). Then over time you can get used to things like landing commits.

Landing commits is something that has become a lot easier with things like @evanlucas's node-review and core-validate-commit. It's mostly a question of following the guide carefully each time so you don't miss anything.

The only dangerous thing is that you could accidentally push to nodejs/node and overwrite some branches (which some very experienced people have done). It's nearly always recoverable, but there's quite a lot you can do to avoid it (see below).

Either way, it's entirely up to you! If you ever need help with anything feel free to reach out on Github or Twitter (@gibfahn), or ask any other collaborator.

How to avoid accidentally pushing to `nodejs/node` (click me)

Once you become a collaborator you get push access to nodejs/node. This can be an issue, because you want a read-only nodejs/node most of the time for hacking. If you use ssh to push to GitHub then this is doable.

You need to make sure you've forked nodejs/node (so you have a gibfahn/node, replacing gibfahn with your username). Then set up ssh if you haven't already, GitHub has a pretty good guide here.

First make sure you haven't told git to remember your github username and password for https access by cloning your repo with https and trying to push to it (all instructions should work on Linux/macOS using the git command line).

GITHUBUSER=gibfahn # Replace with your GitHub username
git clone https://github.com/$GITHUBUSER/node.git && cd node
echo "Test" >test.sh 
git add test.sh 
git commit -m "This should not get pushed"
git push origin master

You should get a username and password prompt. If not you must have told git to remember your password, so tell it not to (ssh is usually easier to use anyway).

Then set up a repo for hacking and a repo for landing PRs (feel free to change the folder structure):

Hacking repo:

cd
mkdir dev
cd dev  # This creates ~/dev, feel free to use somewhere else
git clone https://github.com/nodejs/node.git && cd node
git remote rename origin upstream # So upstream refers to nodejs/node
git remote add fork git@github.com:$GITHUBUSER/node.git # So fork refers to your fork
git fetch --all # Update everything

Landing PRs repo:

cd ~/dev # Wherever you'd like it to go
mkdir DANGER # So you know not to go in there!
git clone git@github.com:nodejs/node.git && cd node
git remote rename origin DANGER # This is the remote that writes to node
git remote add fork git@github.com:$GITHUBUSER/node.git # Useful for merging your own PRs
git fetch --all

So after this, if you clone nodejs/node, make sure to use https (https://github.com/nodejs/node.git) not ssh (git@github.com:nodejs/node.git). Then, if you accidentally try to push to nodejs/node you'll get a Username and password prompt, which should alert you to what you're doing. If you're in the DANGER directory you should already know to be careful (and you only need to be in there for merging PRs).

The last thing I'd recommend is using a git alias to use --force-with-lease instead of --force for force pushing. You should (hopefully) never need to force push to nodejs/node, but in any case, --force-with-lease is just safer.

You can add an alias with git config --global alias.pf=push --force-with-lease, and then git pf will do git push --force-with-lease.

[jasnell]

I'd like to nominate @watilde for the fantastic work helping to improve the URL impl.

[watilde]

@jasnell Thanks for mentioning my name at here! I'd love to continue working for the core codes (also for npm/Intl as well), and it would be helpful to me if I can get a notification when someone does ping @nodejs/url ;)

[addaleax]

and it would be helpful to me if I can get a notification when someone does ping @nodejs/url ;)

Done! You don’t need to be a collaborator for that. :)

[sam-github]

@vsemozhetbyt being a collaborator isn't a heavy responsibility on your part, mostly it means that you can land you own commits rather than having someone else do it for you. Also, you can tag issues, and help out with general maintenance should you feel so inclined. And it doesn't imply you have to be an authority on everything, either, just that you are consistently involved, helpful and well intentioned, which you are.

[Trott]

Sorry for the delay on this @vsemozhetbyt and @watilde! We'll get to it soon! In the meantime, I think it's past the point that @richardlau should be nominated as well.

[addaleax]

@Trott Just in case our chat was ambiguous, @vsemozhetbyt’s onboarding is currently being scheduled (last I heard) and I’ll be onboarding @watilde in person on Friday if all goes well :)

[Trott]

@Trott Just in case our chat was ambigious, @vsemozhetbyt’s onboarding is currently being scheduled (last I heard) and I’ll be onboarding @watilde in person on Friday if all goes well :)

🔥 ✨ 🚀 🤘 🙌

Awesome, thanks!

[Trott]

Is someone scheduling @vsemozhetbyt's onboarding? If not, I can try to take that on. If so, then I'll maybe try to set something up for @richardlau. (EDIT: Assuming @richardlau is interested, of course!)

[addaleax]

@ChALkeR ping ^^^

If that doesn’t work out, I can be probably still be available, too

[richardlau]

Assuming @richardlau is interested, of course!

Count me in 😄

[bnoordhuis]

I can do Richard's onboarding (same timezone, same company, logical fit.)

[Trott]

@bnoordhuis If you're able to get @richardlau onboarded, I'll move on to nominating @aqrln.

[aqrln]

@Trott wow, thank you. While I wish I contributed more to the project, I am certainly willing to spend more time on it, and being able to run CI and land reviewed patches myself without the need to ping people on IRC constantly will be very helpful.

[addaleax]

I’d like to nominate @AnnaMag and @DavidCai1993, who have both been recurring contributors for several months now and seem like good candidates for being collaborators to me.

[AnnaMag]

@addaleax, thank you so much for recognizing my efforts! Please count me in 😀

[DavidCai1111]

@addaleax Thanks so much for the nomination and giving me a chance to let me become more helpful to the community, please count me in 😀

[cjihrig]

I'd like to nominate @lucamaraschi. He is a member of the post-mortem working group, and has been contributing to test coverage.

https://github.com/nodejs/node/pulls/lucamaraschi
https://github.com/nodejs/node/commits/master?author=lucamaraschi

[lucamaraschi]

@cjihrig Thanks a lot for the nomination!I feel honoured of this opportunity ;-)

[cjihrig]

@Trott I can onboard @lucamaraschi if no one is opposed to him being a collaborator.

[Trott]

@cjihrig Sounds good to me. Thanks! Our governance doc indicates that the CTC approves new collaborators, so just to keep things on the level there, I'll add ctc-review to this issue and CTC folks can give the stamp of approval to the currently pending nominations.

[Trott]

@nodejs/ctc Adding ctc-review so CTC folks can review the current pending nominees for Collaborator. They are: @aqrln @AnnaMag @DavidCai1993 and @lucamaraschi

https://github.com/nodejs/node/pulls/aqrln
https://github.com/nodejs/node/commits/master?author=aqrln

https://github.com/nodejs/node/pulls/AnnaMag
https://github.com/nodejs/node/commits/master?author=AnnaMag

https://github.com/nodejs/node/pulls/DavidCai1993
https://github.com/nodejs/node/commits/master?author=DavidCai1993

https://github.com/nodejs/node/pulls/lucamaraschi
https://github.com/nodejs/node/commits/master?author=lucamaraschi

If you have any objections or concerns with any of the nominees, please state them here or on the CTC mailing list. Thanks! Expressions of endorsement also welcome. :-D

[Trott]

Probably about time to nominate @refack too.

https://github.com/nodejs/node/pulls/refack
https://github.com/nodejs/node/commits/master?author=refack

[jasnell]

+1 to all of the above.

[gibfahn]

Maybe not the place, but when we add new collaborators we should encourage them to join the teams mentioned in the onboarding-extras if they have a particular focus or skillset. For example @refack seems like someone who knows his way around Windows, so it would be great to have him in @nodejs/platform-windows.

I guess onboarders probably do that already, so this is just to confirm.

[refack]

Would be happy to help with `nodejs/platform-windows`, also `nodejs/build`.

[Trott]

I guess onboarders probably do that already, so this is just to confirm.

Not sure about other onboarders but I generally don't. And it's a great idea, so I'll start doing that. Thanks for suggesting it.

[addaleax]

I’ve added @refack to platform-windows. For the notification-only teams (as opposed to WGs) we can add anybody who wants to join and is an org member anyway. :)

@refack For joining the build working group you’d probably best open an issue at https://github.com/nodejs/build

[mhdawson]

+1 to all nominations from me.

[targos]

+1 from me too.

[Trott]

Probably overdue to nominate @jkrems too.

https://github.com/nodejs/node/pulls/jkrems
https://github.com/nodejs/node/commits/master?author=jkrems

[refack]

@jkrems 47f8f74 was a whopper, great job! but in the future remember us windows people #12261

[addaleax]

@AnnaMag @DavidCai1993 @jkrems @lucamaraschi Did anybody reach out to you yet about scheduling your onboarding sessions? I should be able to do something this weekend if you have the time. (If somebody already did: Awesome, please ignore me!)

@AnnaMag Your git Author: fields don’t carry a public email address. That’s perfectly fine, but so far I’ve always scheduled onboardings via email. Could you send me one at anna@addaleax.net with a preferred way of contacting you for scheduling?

[AnnaMag]

@addaleax, thanks so much for following up on that!
My onboarding session is scheduled for tomorrow with @Trott (who contacted me by email 😄 ).

[lucamaraschi]

@addaleax thanks a lot for following up on this!I am going to be out the coming days but I can from next Thursday on...

[addaleax]

@lucamaraschi Oh, yeah, the suggestion to do something this weekend was more like “I have the time, so if any of you do, great”. :) I also figured you might want to ask one of the collaborators you’re working with, but that’s totally your/their call.

[jkrems]

Did anybody reach out to you yet about scheduling your onboarding sessions?

Not yet! Wasn't sure if there was a CTC decision yet..? If there was, I'd be happy to take some time this weekend for the onboarding!

[addaleax]

We skipped the CTC meeting this week, but so far there has been a decided lack of objections to any of the candidates. ;)

[DavidCai1111]

@addaleax Thanks so much for following up on this! I have not been contacted yet and I think i'm free on this weekends or today (my timezone: Beijing 😢 ) :=)

[Trott]

I think all the nominees have been onboarded at this point with the exception of @lucamaraschi. If I'm wrong and I missed someone, please comment!

[lucamaraschi]

@Trott I am planning to do it with @cjihrig this week.

[Trott]

Looks like this round is done. If anyone has more nominations, feel free to open a new issue.