Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix and modernize code examples in domain.md #11110

Closed
wants to merge 4 commits into from
Closed

doc: fix and modernize code examples in domain.md #11110

wants to merge 4 commits into from

Conversation

vsemozhetbyt
Copy link
Contributor

@vsemozhetbyt vsemozhetbyt commented Feb 1, 2017

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, domain

  • var -> const
  • concatenations -> templates
  • add missing space
  • fix variable shadowing (fixed basing on the previous example)

FWIW, until the sealing of the domain's vague fate.

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. domain Issues and PRs related to the domain subsystem. labels Feb 1, 2017
reqd.add(req);
reqd.add(res);
reqd.on('error', (er) => {
console.error('Error', er, req.url);
console.error(`Error ${er} ${req.url}`);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't this change remove the stack trace?

Copy link
Contributor Author

@vsemozhetbyt vsemozhetbyt Feb 1, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh. Yes. Sorry.

I shall revert these ones. It seems something like Error ${util.format(err)} will be much worse.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@evanlucas Reverted.

@vsemozhetbyt
Copy link
Contributor Author

cc @nodejs/documentation

@vsemozhetbyt
Copy link
Contributor Author

@evanlucas Could we proceed?

@vsemozhetbyt
Copy link
Contributor Author

@evanlucas @jasnell Could this be landed?

@evanlucas
Copy link
Contributor

Yep LGTM. Can you land or would you like me to? Thanks!

@vsemozhetbyt
Copy link
Contributor Author

@evanlucas Sorry, I can't) I am not a collaborator)

@evanlucas
Copy link
Contributor

Landed in 5a42cd1. Thanks!

@evanlucas evanlucas closed this Feb 14, 2017
evanlucas pushed a commit that referenced this pull request Feb 14, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@vsemozhetbyt vsemozhetbyt deleted the domain.md branch February 14, 2017 22:17
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 16, 2017
* var -> const
* string concatenation -> template strings

PR-URL: nodejs#11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas pushed a commit that referenced this pull request Feb 22, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@italoacasas italoacasas mentioned this pull request Feb 25, 2017
jasnell pushed a commit that referenced this pull request Mar 7, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
jasnell pushed a commit that referenced this pull request Mar 7, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
MylesBorins pushed a commit that referenced this pull request Mar 9, 2017
* var -> const
* string concatenation -> template strings

PR-URL: #11110
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Mar 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. domain Issues and PRs related to the domain subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants