test: skip irrelevant test on Windows #12261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Skip test-cluster-disconnect-handles on Windows. Refs: nodejs#12197 (comment)
|
If CI is green, I would strongly advocate for landing this immediately. Needs an LGTM or two, though.... |
|
First of all: Sorry, should've looked more closely at the semantics of |
richardlau
approved these changes
Apr 6, 2017
|
@jkrems This means that the test will be skipped. It won't run at all on Windows. The current version of the test has code that checks to see if it's running on Windows and, if so, exits, which means that it doesn't fail as expected. Yeah, it's confusing. |
|
Ah, missed that early return. Thanks for explaining! :) |
jkrems
approved these changes
Apr 6, 2017
cjihrig
approved these changes
Apr 6, 2017
|
CI is green. Landing. |
|
Landed in a94a5da |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 6, 2017
Skip test-cluster-disconnect-handles on Windows. PR-URL: nodejs#12261 Ref: nodejs#12197 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Apr 6, 2017
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Apr 10, 2017
Skip test-cluster-disconnect-handles on Windows. PR-URL: nodejs#12261 Ref: nodejs#12197 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 18, 2017
Skip test-cluster-disconnect-handles on Windows. PR-URL: #12261 Ref: #12197 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
Skip test-cluster-disconnect-handles on Windows. PR-URL: #12261 Ref: #12197 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
Skip test-cluster-disconnect-handles on Windows. PR-URL: nodejs/node#12261 Ref: nodejs/node#12197 (comment) Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Skip test-cluster-disconnect-handles on Windows.
Refs: #12197 (comment)
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test