Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Investigate flaky test-https-agent-create-connection on multiple platforms #11644

Closed
Trott opened this issue Mar 2, 2017 · 5 comments · Fixed by #11649
Closed

Investigate flaky test-https-agent-create-connection on multiple platforms #11644

Trott opened this issue Mar 2, 2017 · 5 comments · Fixed by #11649
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.

Comments

@Trott
Copy link
Member

Trott commented Mar 2, 2017

https://ci.nodejs.org/job/node-test-commit-linuxone/4236/nodes=rhel72-s390x/console

not ok 638 parallel/test-https-agent-create-connection
  ---
  duration_ms: 0.120
  severity: fail
  stack: |-
    events.js:163
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect ECONNREFUSED 127.0.0.1:59481
        at Object.exports._errnoException (util.js:986:11)
        at exports._exceptionWithHostPort (util.js:1009:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1089:14)
@Trott Trott added https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests. labels Mar 2, 2017
@bnoordhuis bnoordhuis mentioned this issue Mar 2, 2017
Closed
2 tasks
@mscdex
Copy link
Contributor

mscdex commented Mar 2, 2017

FWIW I just saw this same test fail, but with different output on the same rhel72-s390x machine:

not ok 637 parallel/test-https-agent-create-connection
  ---
  duration_ms: 0.170
  severity: fail
  stack: |-
    
    assert.js:81
      throw new assert.AssertionError({
      ^
    AssertionError: false == true
        at TLSSocket.socket.on.common.mustCall (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/parallel/test-https-agent-create-connection.js:111:5)
        at TLSSocket.<anonymous> (/data/iojs/build/workspace/node-test-commit-linuxone/nodes/rhel72-s390x/test/common.js:452:15)
        at emitOne (events.js:96:13)
        at TLSSocket.emit (events.js:191:7)
        at emitErrorNT (net.js:1280:8)
        at _combinedTickCallback (internal/process/next_tick.js:80:11)
        at process._tickCallback (internal/process/next_tick.js:104:9)

@mscdex
Copy link
Contributor

mscdex commented Mar 2, 2017

I should also add that the same stack trace I just posted for the same test has happened on centos5-32 now.

@bnoordhuis bnoordhuis mentioned this issue Mar 2, 2017
Closed
3 tasks
@santigimeno santigimeno mentioned this issue Mar 2, 2017
Merged
2 tasks
@Trott Trott changed the title Investigate flaky test-https-agent-create-connection on LinuxONE Investigate flaky test-https-agent-create-connection on multiple platforms Mar 2, 2017
@Trott
Copy link
Member Author

Trott commented Mar 2, 2017

Now Windows: https://ci.nodejs.org/job/node-test-binary-windows/6823/RUN_SUBSET=3,VS_VERSION=vs2015,label=win2008r2/console

not ok 160 parallel/test-https-agent-create-connection 
 ---
  duration_ms: 1.398
  severity: fail
  stack: |-
    events.js:163
          throw er; // Unhandled 'error' event
          ^
    
    Error: connect ECONNREFUSED 127.0.0.1:52212
        at Object.exports._errnoException (util.js:986:11)
        at exports._exceptionWithHostPort (util.js:1009:20)
        at TCPConnectWrap.afterConnect [as oncomplete] (net.js:1089:14)

@Trott
Copy link
Member Author

Trott commented Mar 2, 2017

This is a brand new test as of about two weeks ago. Looping in author, approvers, and testing working group:

@chiiia12 @jasnell @abouthiroppy @nodejs/testing

@santigimeno
Copy link
Member

@Trott, proposed fix here: #11649

santigimeno added a commit to santigimeno/node that referenced this issue Mar 2, 2017
@santigimeno
test: fix flaky test-https-agent-create-connection
5269e95 
Use a different server instance for every test to avoid that they reuse
the same port.

PR-URL: nodejs#11649
Fixes: nodejs#11644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
addaleax pushed a commit that referenced this issue Mar 5, 2017
@santigimeno @addaleax
test: fix flaky test-https-agent-create-connection
00dd20c 
Use a different server instance for every test to avoid that they reuse
the same port.

PR-URL: #11649
Fixes: #11644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 17, 2017
@santigimeno @MylesBorins
test: fix flaky test-https-agent-create-connection
577eb81 
Use a different server instance for every test to avoid that they reuse
the same port.

PR-URL: #11649
Fixes: #11644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this issue Apr 19, 2017
@santigimeno @MylesBorins
test: fix flaky test-https-agent-create-connection
640b72e 
Use a different server instance for every test to avoid that they reuse
the same port.

PR-URL: #11649
Fixes: #11644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this issue Jul 19, 2017
@santigimeno @andrew749
test: fix flaky test-https-agent-create-connection
fd5f0c7 
Use a different server instance for every test to avoid that they reuse
the same port.

PR-URL: nodejs/node#11649
Fixes: nodejs/node#11644
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
https Issues or PRs related to the https subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: fix flaky test-https-agent-create-connection santigimeno/node
3 participants
@mscdex @Trott @santigimeno