test: improve https coverage to check create connection #11435
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
requested changes
Feb 17, 2017
| socket.on('data', common.mustCall((chunk) => { | ||
| result += chunk; | ||
| })); | ||
| socket.on('end', () => { |
There was a problem hiding this comment.
common.mustCall() would be good here too
| }; | ||
|
|
||
| // use option connect | ||
| server.listen(0, () => { |
| }); | ||
|
|
||
| // use port and host and option connect | ||
| server.listen(0, () => { |
chiiia12
force-pushed
the
improve_test_https2
branch
from
58cd166
to
2e57fea
Compare
|
@jasnell thanks for reviewing! I fix it. |
|
LGTM. |
jasnell
approved these changes
Feb 24, 2017
hiroppy
approved these changes
Feb 25, 2017
hiroppy
pushed a commit
that referenced
this pull request
Mar 2, 2017
PR-URL: #11435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
|
landed in 104c9ac, thanks! |
|
See #11644, the test appears to be rather flaky. |
addaleax
pushed a commit
that referenced
this pull request
Mar 5, 2017
PR-URL: #11435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Apr 17, 2017
PR-URL: #11435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
|
I've backported including the change that closed #11644 LMK if this should be reverted |
MylesBorins
pushed a commit
that referenced
this pull request
Apr 19, 2017
PR-URL: #11435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Merged
andrew749
pushed a commit
to michielbaird/node
that referenced
this pull request
Jul 19, 2017
PR-URL: nodejs/node#11435 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves https coverage (maybe cover statement 100%).
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)