-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sometimes REPL cannot display the result #12085
Comments
I also met for this problem since 6.10.0 |
It sounds like GetVersionEx() is failing but I can't fathom why. Can you try building from source with the patch below applied? diff --git a/src/node_os.cc b/src/node_os.cc
index d7be909..e31578b 100644
--- a/src/node_os.cc
+++ b/src/node_os.cc
@@ -125,8 +125,13 @@ static void GetOSRelease(const FunctionCallbackInfo<Value>& args) {
// Don't complain that GetVersionEx is deprecated; there is no alternative.
#pragma warning(suppress : 4996)
- if (GetVersionExW(&info) == 0)
+ if (GetVersionExW(&info) == 0) {
+ auto isolate = args.GetIsolate();
+ auto exception =
+ WinapiErrnoException(isolate, GetLastError(), "GetVersionEx");
+ isolate->ThrowException(exception);
return;
+ }
snprintf(release,
sizeof(release), |
Seems to be a duplicate of #7837. Please try with the latest node.js version. |
It is the latest version of 6.x.x already. |
I've reverted the offending commit in 1978911, this should be fixed in the next v6.x LTS release |
@seishun my node version is 6.10.1 which is latest version of LTS already |
Full original message: Revert "repl: disable Ctrl+C support on win32 for now" This reverts commit 1d400ea. Fixes: nodejs#12085 Refs: nodejs#8645 PR-URL: nodejs#12123 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Full original message: Revert "repl: disable Ctrl+C support on win32 for now" The original fix was a stop gap until a libuv update landed. As the libuv update has not yet landed on v6.x the revert should not have landed. This commit reverts 1d400ea reapplying the stopgap fix until we update libuv. Fixes: #12085 Refs: #8645 PR-URL: #12123 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Full original message: Revert "repl: disable Ctrl+C support on win32 for now" The original fix was a stop gap until a libuv update landed. As the libuv update has not yet landed on v6.x the revert should not have landed. This commit reverts 1d400ea reapplying the stopgap fix until we update libuv. Fixes: #12085 Refs: #8645 PR-URL: #12123 Reviewed-By: Anna Henningsen <anna@addaleax.net>
I can't tell if this was fixed in 6.10.2 or if it's expected to be fixed in 6.11.2. Can someone confirm the bug on Windows in 6.10.2 or later? |
No follow-up and no one complained so I'll go ahead and assume this is fixed. If not, please leave a comment. |
In node REPL mode, when I execute a function, sometimes the result cannot be displayed. Refer as the below screenshot:
The text was updated successfully, but these errors were encountered: