Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade libuv to 1.10.0 #9267

Merged
merged 1 commit into from
Oct 26, 2016
Merged

deps: upgrade libuv to 1.10.0 #9267

merged 1 commit into from
Oct 26, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 25, 2016

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

This PR upgrades libuv from 1.9.1 to 1.10.0. This is a continuation of #8280.

Refs: #8280
Fixes: #4351
Fixes: #6763

R= @saghul @bnoordhuis @indutny @santigimeno

@nodejs-github-bot nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Oct 25, 2016
@santigimeno
Copy link
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/4659/

@bnoordhuis
Copy link
Member

LGTM. A known flake on the freebsd10-64 buildbot and infrastructure issues on three of the rpi1 machines.

@seishun
Copy link
Contributor

seishun commented Oct 25, 2016

I again confirm that this fixes #6763.

@jasnell
Copy link
Member

jasnell commented Oct 25, 2016

semver-minor?

jasnell
jasnell approved these changes Oct 25, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 25, 2016

This libuv update itself is semver minor. It looks like previous semver minor libuv bumps have been treated as semver patch.

@jasnell
Copy link
Member

jasnell commented Oct 25, 2016

Yep... I just want to be careful after the 1.9 update issues. I'd like to
make sure this goes out in a v7.x release before getting pulled into v6 or
v4

On Tuesday, October 25, 2016, Colin Ihrig notifications@github.com wrote:

This libuv update itself is semver minor. It looks like previous semver
minor libuv bumps have been treated as semver patch
https://nodejs.org/en/blog/release/v4.5.0/.

—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
#9267 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAa2ecBuASdKVjVztXSC22Dmj22nPThOks5q3klNgaJpZM4KffvB
.

@cjihrig
deps: upgrade libuv to 1.10.0
63243bc 
Fixes: nodejs#4351
Fixes: nodejs#6763
Refs: nodejs#8280
PR-URL: nodejs#9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig merged commit 63243bc into nodejs:master Oct 26, 2016
@cjihrig cjihrig deleted the libuv branch October 26, 2016 13:48
evanlucas pushed a commit that referenced this pull request Nov 3, 2016
@cjihrig @evanlucas
deps: upgrade libuv to 1.10.0
106d719 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Nov 3, 2016
Merged
@MylesBorins
Copy link
Contributor

Throwing LTS watch on here for v4 and v6. This should come in a minor if it lands in either. This should bake for a while before landing and come with #9647

@MylesBorins MylesBorins mentioned this pull request Nov 18, 2016
Merged
2 tasks
@MylesBorins
Copy link
Contributor

@nodejs/lts should we include this in the upcoming minor release?

have there been any regressions from this?

@MylesBorins MylesBorins added the semver-minor PRs that contain new features and should be released in the next minor version. label Mar 3, 2017
@MylesBorins
Copy link
Contributor

adding semver-minor label... pretty sure that should have been there

@seishun seishun mentioned this pull request Mar 28, 2017
Closed
@MylesBorins
Copy link
Contributor

if this lands on v6.x it needs to come with #8645

@seishun
Copy link
Contributor

seishun commented Mar 28, 2017

I'm looking forward to the revertception.

@gibfahn gibfahn mentioned this pull request Apr 24, 2017
Closed
31 tasks
MylesBorins pushed a commit that referenced this pull request May 16, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.10.0
2a06752 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
@cjihrig @MylesBorins
deps: upgrade libuv to 1.10.0
3585ffa 
Fixes: #4351
Fixes: #6763
Refs: #8280
PR-URL: #9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request May 23, 2017
Merged
@bzoz bzoz mentioned this pull request Jun 6, 2017
Closed
MylesBorins added a commit that referenced this pull request Jun 6, 2017
@MylesBorins
2017-06-06, Version 6.11.0 'Boron' (LTS)
40859e2 
This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    #10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    #10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    #8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    #8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    #9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    #11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    #12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    #11094
  - upgrade libuv to 1.10.2 (cjihrig)
    #10717
  - upgrade libuv to 1.10.1 (cjihrig)
    #9647
  - upgrade libuv to 1.10.0 (cjihrig)
    #9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    #9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    #10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    #10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    #11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    #10294

PR-URL: #13059
MylesBorins added a commit that referenced this pull request Jun 6, 2017
@MylesBorins
2017-06-06, Version 6.11.0 'Boron' (LTS)
4c5cbb7 
This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    #10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    #10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    #8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    #8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    #9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    #11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    #12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    #11094
  - upgrade libuv to 1.10.2 (cjihrig)
    #10717
  - upgrade libuv to 1.10.1 (cjihrig)
    #9647
  - upgrade libuv to 1.10.0 (cjihrig)
    #9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    #9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    #10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    #2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    #10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    #11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    #10294

PR-URL: #13059
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@cjihrig @andrew749
deps: upgrade libuv to 1.10.0
81dc03d 
Fixes: nodejs/node#4351
Fixes: nodejs/node#6763
Refs: nodejs/node#8280
PR-URL: nodejs/node#9267
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
@MylesBorins @andrew749
2017-06-06, Version 6.11.0 'Boron' (LTS)
e5cdc26 
This LTS release comes with 126 commits. This includes 40 which
are test related, 32 which are doc related, 12 which are
build / tool related and 4 commits which are updates to
dependencies.

Notable Changes:

* build:
  - support for building mips64el (nanxiongchao)
    nodejs/node#10991
* cluster:
  - disconnect() now returns a reference to the disconnected
    worker. (Sean Villars)
    nodejs/node#10019
* crypto:
  - ability to select cert store at runtime (Adam Majer)
    nodejs/node#8334
  - Use system CAs instead of using bundled ones (Adam Majer)
    nodejs/node#8334
  - The `Decipher` methods `setAuthTag()` and `setAAD` now return
    `this`. (Kirill Fomichev)
    nodejs/node#9398
  - adding support for OPENSSL_CONF again (Sam Roberts)
    nodejs/node#11006
  - make LazyTransform compabile with Streams1 (Matteo Collina)
    nodejs/node#12380
* deps:
  - upgrade libuv to 1.11.0 (cjihrig)
    nodejs/node#11094
  - upgrade libuv to 1.10.2 (cjihrig)
    nodejs/node#10717
  - upgrade libuv to 1.10.1 (cjihrig)
    nodejs/node#9647
  - upgrade libuv to 1.10.0 (cjihrig)
    nodejs/node#9267
* dns:
  - Implemented `{ttl: true}` for `resolve4()` and `resolve6()`
    (Ben Noordhuis)
    nodejs/node#9296
* process:
  - add NODE_NO_WARNINGS environment variable (cjihrig)
    nodejs/node#10842
* readline:
  - add option to stop duplicates in history (Danny Nemer)
    nodejs/node#2982
* src:
  - support "--" after "-e" as end-of-options (John Barboza)
    nodejs/node#10651
* tls:
  - new tls.TLSSocket() supports sec ctx options (Sam Roberts)
    nodejs/node#11005
  - Allow obvious key/passphrase combinations. (Sam Roberts)
    nodejs/node#10294

PR-URL: nodejs/node#13059
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@santigimeno santigimeno santigimeno approved these changes

Assignees
No one assigned
Labels
libuv Issues and PRs related to the libuv dependency or the uv binding. semver-minor PRs that contain new features and should be released in the next minor version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@cjihrig @santigimeno @bnoordhuis @seishun @jasnell @MylesBorins @nodejs-github-bot