Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: 2 identical files in the same folder #12624

Closed
vsemozhetbyt opened this issue Apr 24, 2017 · 15 comments
Closed

meta: 2 identical files in the same folder #12624

vsemozhetbyt opened this issue Apr 24, 2017 · 15 comments
Labels
meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.

Comments

@vsemozhetbyt
Copy link
Contributor

In deps/npm/node_modules/request/node_modules/form-data/ there are 2 identical files: Readme.md and README.md. This confuses archivators on Windows: each time they try to unpack a repo from a GH zip, they stop and ask if the file should be rewritten. I am not sure what we can do about this issue.
@vsemozhetbyt vsemozhetbyt added meta Issues and PRs related to the general management of the project. windows Issues and PRs related to the Windows platform. labels Apr 24, 2017
@Fishrock123
Copy link
Contributor

There should only be one...

@gibfahn
Copy link
Member

gibfahn commented Apr 24, 2017

I see that form-data has a Readme.md rather than a README.md, maybe something is capitalising it at some point?

@gibfahn gibfahn added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 24, 2017
@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 24, 2017 •
edited
Loading

npm has README.md: https://github.com/npm/npm/tree/latest/node_modules/request/node_modules/form-data

@Fishrock123
Copy link
Contributor

I think it used to be README.md... so maybe git didn't rename it properly for case-insensitive filesystems?

cc @zkat but I think we can just remove the old README.md.

refs: #11085 & #11020...

@zkat
Copy link
Contributor

zkat commented Apr 24, 2017

oh god just remove one please this has been a nightmare

@vsemozhetbyt
Copy link
Contributor Author

So which of them should be removed?

@zkat
Copy link
Contributor

zkat commented Apr 24, 2017

@vsemozhetbyt README.md is the one that was (un?)intentionally capitalized

@vsemozhetbyt
Copy link
Contributor Author

vsemozhetbyt commented Apr 24, 2017 •
edited
Loading

I can't actually remove it as I am on Windows so I can already have only one locally) Can anybody remove it from a proper OS?

@Fishrock123
Copy link
Contributor

Yeah I'll get around to it today, hopefully.

@Fishrock123
Copy link
Contributor

Ok uh, I can't seem to do it now, maybe after landing v4.5.0... @nodejs/ctc can someone with a case insensitive FS and git fix this?

@Fishrock123
Copy link
Contributor

Maybe I can do it from the GitHub GUI.... https://github.com/form-data/form-data has Readme.md.

Fishrock123 added a commit that referenced this issue Apr 25, 2017
@Fishrock123
deps: remove form-data/README.md
5bd9c45 
Having multiples of the same file name with different casings causes problems on lots of OS-s.

Refs: #12624
@Fishrock123 Fishrock123 mentioned this issue Apr 25, 2017
Merged
1 task
@Fishrock123
Copy link
Contributor

Ok, looks like it worked from the GitHub GUI: #12643

@refack
Copy link
Contributor

refack commented Apr 26, 2017

Highlander - "There Can Be Only One"

Fishrock123 added a commit that referenced this issue Apr 26, 2017
@Fishrock123
deps: remove **/node_modules/form-data/README.md
e8f3163 
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Fishrock123
Copy link
Contributor

Fixed in e8f3163

@vsemozhetbyt
Copy link
Contributor Author

Refs: #12680

evanlucas pushed a commit that referenced this issue May 1, 2017
@Fishrock123 @evanlucas
deps: remove **/node_modules/form-data/README.md
41e052a 
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@Fishrock123 @evanlucas
deps: remove **/node_modules/form-data/README.md
f8ae23e 
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this issue May 2, 2017
@Fishrock123 @evanlucas
deps: remove **/node_modules/form-data/README.md
d154aaf 
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project. npm Issues and PRs related to the npm client dependency or the npm registry. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@zkat @refack @Fishrock123 @vsemozhetbyt @gibfahn