Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: remove form-data/README.md #12643

Merged
merged 1 commit into from
Apr 26, 2017

Conversation

Fishrock123
Copy link
Contributor

@Fishrock123 Fishrock123 commented Apr 25, 2017

Having multiples of the same file name with different casings causes problems on lots of OS-s.

Refs: #12624

@vsemozhetbyt think you could check if this fixed the issue for you?

Apologies if this commit is weird, I had to make it in the GitHub GUI.

Checklist
Affected core subsystem(s)

deps

@nodejs-github-bot nodejs-github-bot added the npm Issues and PRs related to the npm client dependency or the npm registry. label Apr 25, 2017
@Fishrock123
Copy link
Contributor Author

I can confirm this appears to fix a related issue with GitHub for Mac for me.

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 25, 2017

I don't know how I can test this till landing: I only had problems with unpacking GH zips with the repo. Should I try to download a zip from https://github.com/nodejs/node/tree/Fishrock123-remove-badly-cased-file ?

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Apr 25, 2017

Can confirm: https://github.com/nodejs/node/archive/Fishrock123-remove-badly-cased-file.zip contains no duplicates and is unpacked without a break. Thank you!

@Fishrock123 Fishrock123 force-pushed the Fishrock123-remove-badly-cased-file branch from 5bd9c45 to d3447f7 Compare April 26, 2017 16:09
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
@Fishrock123 Fishrock123 force-pushed the Fishrock123-remove-badly-cased-file branch from d3447f7 to e8f3163 Compare April 26, 2017 16:09
@Fishrock123 Fishrock123 merged commit e8f3163 into master Apr 26, 2017
@Fishrock123 Fishrock123 deleted the Fishrock123-remove-badly-cased-file branch April 26, 2017 16:11
@vsemozhetbyt
Copy link
Contributor

Refs: #12680

@evanlucas evanlucas mentioned this pull request May 1, 2017
evanlucas pushed a commit that referenced this pull request May 1, 2017
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
evanlucas pushed a commit that referenced this pull request May 2, 2017
Having multiple files with the same name but different casings causes
problems on lots of OS-s.

Refs: #12624
Refs: #11085
Refs: #11020

PR-URL: #12643
Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Timothy Gu <timothygu99@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Alexey Orlenko <eaglexrlnk@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants