investigate flaky test-benchmark-child-process on Windows

[Trott]

• Version: 8.0.0-pre
• Platform: win2008r2
• Subsystem: test

https://ci.nodejs.org/job/node-test-binary-windows/8189/RUN_SUBSET=3,VS_VERSION=vs2015-x86,label=win2008r2/console

not ok 356 sequential/test-benchmark-child-process
  ---
  duration_ms: 60.211
  severity: fail
  stack: |-
    timeout

refack adding
Ref: #12560

[refack]

It's that [expletive] yes.exe again.

[refack]

Post land stress: https://ci.nodejs.org/job/node-stress-single-test/1201/nodes=win-vs2015/

[refack]

Reopening:
https://ci.nodejs.org/job/node-test-binary-windows/8986/RUN_SUBSET=2,VS_VERSION=vs2015,label=win2012r2/

not ok 370 sequential/test-benchmark-child-process
  ---
  duration_ms: 0.623
  severity: fail
  stack: |-
    
    child_process\child-process-exec-stdout.js
    child_process\child-process-exec-stdout.js dur=0 len=1: 0
    ERROR: The process with PID 3816 (child process of PID 3692) could not be terminated.
    Reason: There is no running instance of the task.
    child_process.js:611
        throw err;
        ^
    
    Error: Command failed: taskkill /f /t /pid 3816
    ERROR: The process with PID 3816 (child process of PID 3692) could not be terminated.
    Reason: There is no running instance of the task.
    
    
        at checkExecSyncError (child_process.js:568:13)
        at Object.execSync (child_process.js:608:13)
        at Timeout._onTimeout (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\benchmark\child_process\child-process-exec-stdout.js:36:21)
        at ontimeout (timers.js:488:11)
        at tryOnTimeout (timers.js:323:5)
        at Timer.listOnTimeout (timers.js:283:5)
    assert.js:60
      throw new errors.AssertionError({
      ^
    
    AssertionError [ERR_ASSERTION]: 1 === 0
        at ChildProcess.child.on (c:\workspace\node-test-binary-windows\RUN_SUBSET\2\VS_VERSION\vs2015\label\win2012r2\test\sequential\test-benchmark-child-process.js:19:10)
        at emitTwo (events.js:125:13)
        at ChildProcess.emit (events.js:213:7)
        at Process.ChildProcess._handle.onexit (internal/child_process.js:197:12)
  ...

[bzoz]

@refack, did #13457 solve this?

[refack]

@refack, did #13457 solve this?

I think so.

---

Fixed by #13457