test: fix flakyness with yes.exe
#12821
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
benchmark
|
/cc @Trott |
cjihrig
approved these changes
May 4, 2017
joyeecheung
requested changes
May 4, 2017
| child.kill(); | ||
| if (process.platform === 'win32') { | ||
| // Sometimes there's a yes.exe process left hanging around on Windows... | ||
| child_process.execSync(`taskkill /f /t /pid ${child.pid}`); |
There was a problem hiding this comment.
CI is failing...
ReferenceError: child_process is not defined
Only the child_process.spawn is stored in a variable above..
There was a problem hiding this comment.
Fixed 😞
I should keep the late night commits to a minimum...
refack
commented
May 4, 2017
| const os = require('os'); | ||
| const child_process = require('child_process'); |
There was a problem hiding this comment.
As per test style guide. Even though it's a benchmark IMHO still a good idea.
2 tasks
jasnell
approved these changes
May 4, 2017
joyeecheung
approved these changes
May 5, 2017
refack
added a commit
to refack/node
that referenced
this pull request
May 6, 2017
PR-URL: nodejs#12821 Fixes: nodejs#12817 Refs: nodejs#12658 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in 68c933c |
|
Post land CI: https://ci.nodejs.org/job/node-test-commit/9691/ [update] |
anchnk
pushed a commit
to anchnk/node
that referenced
this pull request
May 19, 2017
PR-URL: nodejs#12821 Fixes: nodejs#12817 Refs: nodejs#12658 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
3 tasks
|
@refack I've landed this on v6.x, seems low risk, and should hopefully reduce CI flakyness on v6.x. If you think it shouldn't have landed LMK. |
Should be Ok. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Kills
yes.exewith fire cause it's evilFixes: #12817
Ref: #12658
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passesAffected core subsystem(s)
test, benchmark