-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buffer.kMaxLength returning different value than buffer.constants.MAX_LENGTH #14819
Labels
Comments
addaleax
added a commit
to addaleax/node
that referenced
this issue
Aug 14, 2017
This was a typo and accidentally returned the wrong value. Fixes: nodejs#14819 Ref: nodejs#13467
3 tasks
3 tasks
starkwang
added a commit
to starkwang/node
that referenced
this issue
Aug 15, 2017
The value of buffer.constants.MAX_LENGTH is different from buffer.kMaxLength.This change is to fix it. Fixes: nodejs#14819
MylesBorins
pushed a commit
that referenced
this issue
Sep 10, 2017
This was a typo and accidentally returned the wrong value. Fixes: #14819 Ref: #13467 PR-URL: #14821 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Sep 11, 2017
This was a typo and accidentally returned the wrong value. Fixes: #14819 Ref: #13467 PR-URL: #14821 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this issue
Sep 12, 2017
This was a typo and accidentally returned the wrong value. Fixes: #14819 Ref: #13467 PR-URL: #14821 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Yuta Hiroto <hello@about-hiroppy.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Version:
v8.2.1
Platform:
win32 (10.0.14393)
Subsystem:
Buffer
The documentation says...
For buffer.kMaxLength
The largest size allowed for a single Buffer instance
An alias for buffer.constants.MAX_LENGTH
For buffer.constants.MAX_LENGTH:
The largest size allowed for a single Buffer instance
On 32-bit architectures, this value is (2^30)-1 (~1GB). On 64-bit architectures, this value is (2^31)-1 (~2GB).
This value is also available as buffer.kMaxLength.
But when you call the functions, they return different values...
The text was updated successfully, but these errors were encountered: