-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OSX, intermittent - sequential/test-debug-prompt #21724
Comments
Hmmm...a recent uptick in this one it seems. Here's one from today. https://ci.nodejs.org/job/node-test-commit-osx/19816/nodes=osx1010/console 03:35:43 not ok 2263 sequential/test-debug-prompt
03:35:43 ---
03:35:43 duration_ms: 0.397
03:35:43 severity: fail
03:35:43 exitcode: 1
03:35:43 stack: |-
03:35:43 events.js:167
03:35:43 throw er; // Unhandled 'error' event
03:35:43 ^
03:35:43
03:35:43 Error: write EPIPE
03:35:43 at WriteWrap.afterWrite [as oncomplete] (net.js:836:14)
03:35:43 Emitted 'error' event at:
03:35:43 at onwriteError (_stream_writable.js:431:12)
03:35:43 at onwrite (_stream_writable.js:456:5)
03:35:43 at _destroy (internal/streams/destroy.js:40:7)
03:35:43 at Socket._destroy (net.js:606:3)
03:35:43 at Socket.destroy (internal/streams/destroy.js:32:8)
03:35:43 at WriteWrap.afterWrite [as oncomplete] (net.js:838:10)
03:35:43 ... |
Looking at osx1011 too instead of just osx1010, it's happening there as well. https://ci.nodejs.org/job/node-test-commit-osx/19817/nodes=osx1011/console 03:35:29 not ok 2263 sequential/test-debug-prompt
03:35:29 ---
03:35:29 duration_ms: 0.422
03:35:29 severity: fail
03:35:29 exitcode: 1
03:35:29 stack: |-
03:35:29 events.js:167
03:35:29 throw er; // Unhandled 'error' event
03:35:29 ^
03:35:29
03:35:29 Error: write EPIPE
03:35:29 at WriteWrap.afterWrite [as oncomplete] (net.js:836:14)
03:35:29 Emitted 'error' event at:
03:35:29 at onwriteError (_stream_writable.js:431:12)
03:35:29 at onwrite (_stream_writable.js:456:5)
03:35:29 at _destroy (internal/streams/destroy.js:40:7)
03:35:29 at Socket._destroy (net.js:606:3)
03:35:29 at Socket.destroy (internal/streams/destroy.js:32:8)
03:35:29 at WriteWrap.afterWrite [as oncomplete] (net.js:838:10)
03:35:29 ... |
@nodejs/platform-macos |
Stress test to hopefully get an idea of how frequently this fails. https://ci.nodejs.org/job/node-stress-single-test/1961/nodes=osx1010/ |
This is getting out of hand. Yet another one today: https://ci.nodejs.org/job/node-test-commit-osx/19827/nodes=osx1010/console |
FWIW, I've been unable (so far anyway) to replicate the problem on my 10.11.6 machine. |
Also worth noting that it's happening on both the macstadium and the requireio hosts. (A lot of times, a particular failure only happens on one of our providers, but in this case, it's on both.) |
https://ci.nodejs.org/job/node-test-commit-osx/19832/nodes=osx1010/console
|
Stress test at https://ci.nodejs.org/job/node-stress-single-test/1961/nodes=osx1010/console had 4 failures in 1000 runs, which is a lower failure rate than I expected but maybe that's host-dependent. Like, all hosts are affected but some are way more affected. Anyway, that was with commit cee8677 so with this information, I can begin a slow-motion Didn't look at the change, but my immediate suspicion would be 39977db. The pull request for that change is where this was first reported. And it's a change to |
Stress test for 9374a83. https://ci.nodejs.org/job/node-stress-single-test/1962/nodes=osx1010/ This is the commit directly before 39977db so if it comes up green, I'll do a stress test on 39977db next and see what happens... |
Failed 1 time in 1000 runs on 9374a83. Looks like maybe I need to use something more like 10000 runs just to be sure... |
9374a83 again but this time with 10000 runs: https://ci.nodejs.org/job/node-stress-single-test/1963/nodes=osx1010/ |
Ooof, 1 failure in 10000 runs this last time. Let's see if 10000 runs on 39977db produces substantially more failures... https://ci.nodejs.org/job/node-stress-single-test/1964/nodes=osx1010/ |
Quite the difference! We went from 1-in-10000 failures to 2373 failures in 10000 runs. |
So, the TL;DR: It seems that 39977db increased the failure of this test on OS X 10.10 (Yosemite) in CI from about 0.01% failure to about a 24% failure. YIkes! |
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: nodejs#21724
Testing a possible fix right now that seems to be working out: https://ci.nodejs.org/job/node-stress-single-test/1965/nodes=osx1010/console PR is #21826 |
Be sure to send `.exit` only once to avoid spurious EPIPE and possibly other errors. Fixes: #21724 PR-URL: #21826 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Jon Moss <me@jonathanmoss.me>
https://ci.nodejs.org/view/All/job/node-test-commit-osx/19700/nodes=osx1010/console
The text was updated successfully, but these errors were encountered: