-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Node v11.0 windows installation opting into chocolatey+boxstarter results in infinite reboots #23838
Comments
@nodejs/platform-windows |
I stopped the startup script to prevent a loop. However, it rebooted my computer without warning. This is a bug for sure. |
Back on my computer now. I was able to work around this on Windows 10 64bit. The annoying part where it forces the computer off and looks like a Virus is definitely true and should be fixed, it also didn't give me a chance to save any programs (sort of a force restart it seems). Also, I didn't get a chance to choose about installing boxstarter is that a problem? Anyway, in order to work around this I did the following steps.
Hope this helps. |
For me I just needed to quickly focus on the window that was about to reboot, and hit |
@klick-barakgall Yea, I ran the installer and went off to multitask and when I saw power shell pop up it was not until I saw chocolatey that I felt safe that I had not just downloaded a malicious version of the Node installer (my script was running quickly and I couldnt see that it was going to reboot before it was gone) |
Surprised no one from @nodejs/platform-windows chimed in yet. Let's try @nodejs/build. |
@joaocgreis can you take a look please? infinite reboots are bad 😞 |
@klick-barakgall can you see in the console what is being installed when it reboots? This is probably some corner case with some package, can you take a look at the log files in |
I installed Node 11 on a Dell laptop with 64 bit Windows 10 and unfortunately choose the Boxstarter install option. I thought the note just said you will have to restart your command window. I saw nothing about computer restarts. Node installed just fine but the Powershell Script rebooted 4 times before I noticed it was in a loop to install a script to keep Windows update from changing things. Since the reboot happens quickly you have to be ready to click on the Powershell window and hit Ctrl-C quickly. You are then prompted to type the text "ENTER" to exit the script. I then got a Windows message "You must restart your computer to turn off User Account Control". I didn't want UAC turned off but restarted anyway and everything seemed to work and UAC was on. I did have one program that syncs my Outlook address book with Google contacts that started up with a library error "Cannot open registry Interface{00063001-0000-0000-C000-000000000046}\TypeLib." After several attempts to fix this (including spelunking into the dreaded Windows Registry) I had success by running the repair option on Office installer. (Under Add or Remove Programs). I doubt Boxstarter works and I don't even want to see that name for while. |
This happened to me too on my Windows 10 machine. Once rebooting quickly X-out of the boxstarter script. Then press Ctrl+Shift+Esc to open up task manager and select the "Startup" tab where you can right click and disable |
Me too. Reboots forever. Created dozens of install scripts under
I guess python2 is never installed properly. When using nodejs, I get in gyp errors with pythrons all the time, but it seems ok to ignore them, except that it now keeps rebooting the machine (and needs me to type password too). I also get a strange directory called To exit the loop, control break and type
to undo its other temp changes (disable UAC, disable Windows update, etc). PS: I got the problem with LTS Node 10. I think it has nothing to do with Node version, just the way it is using boxstarter to install tools. |
and if I bypass install tools with Nodejs, the installer told me to follow the steps at
unfortunately it won't work. It seems windows-build-tools only support nodejs v4..9. maybe that's also why chocolatey failed.
and installing it with --ignore-engines crashed the whole Windows. |
I just got UAC turned off myself and had to activate it manually. This is really, really bad. |
Same here. After the 3rd or 4th restart, the script had finally managed to install Python and Build Tools (that's just a guess at this point). But after the next restart, it looked like it was going to begin the whole process again so I stopped the script and removed the startup task. And I've just noticed that my UAC is off. |
This comment has been minimized.
This comment has been minimized.
Ping @nodejs/build @nodejs/platform-windows ... @joaocgreis @richardlau ... please take a look. Looks like #22645 is causing some issues for some users. |
Maybe to people at Microsoft can help with perspective on their end? @yodurr, @crutkas and @bitcrazed & @gep13 |
@klick-barakgall the logs don't show anything that may be causing the reboots, only that installing Chocolatey and Boxstarter succeeded and it is probably rebooting installing our script. Can you see at what point the script reboots? What appears on the console, what is being installed? A picture or a video of your screen might help if you can't read it in time. |
@klick-barakgall can you also upload the log from |
Apologies @joaocgreis this happened on installation on a work machine and it will probably be a while before I can start messing around with (jeopardizing) my NodeJS install and give myself enough time to recover from any potentially bad state. I'm sorry I just don't want to risk destabilizing my dev environment any further at this time. That being said here is the next log you've requested: |
For everyone having this issue, if the computer reboots more than 20 times please upload your log from @klick-barakgall in the log file I see that it run for almost 50 minutes and rebooted 7 times. Then it finished successfully, looks like everything was installed in the end. So, whatever was causing the reboots happened after our script run. I understand you don't want to disturb your machine, but perhaps someone else with the same issue can help. |
boxstarter.zip All the C:\ProgramData\Boxstarter\BuildPackages*.tmp\tools directories have the same ps1 file: choco upgrade -y python2 from control panel, I have python 2.7.15 and vs build tools 2017 installed on that date. I don't find anything called workload vctools. @gep13
|
I am part of the Chocolatey Development Team, and I help oversee both the Chocolatey and Boxstarter projects. While it looks like there is definitely an issue in here that needs to be resolved, let me start by saying that this does work. I have just created a fresh VM with nothing on it, and performed the installation of NodeJS, including the additional components, and it worked as expected. During that process there was a single reboot. I captured this in a video which I have uploaded here: In order to try to figure out what is going on, it would be good to try to figure out if there is some commonality between the people that have reported problems. Things that I am thinking about are:
There was an issue which I documented here: chocolatey/boxstarter#357 (comment) Where the installation of the packages in the NodeJS installation was inadvertently causing a call to the Install-WindowsUpdate cmdlet, which if your machine wasn't up to date with Windows Update would potentially cause multiple reboots of the machine. Not from the installation of the package themselves, but rather from the Windows Updates that were being installed. This issue has been addressed and should no longer happen. Regarding the disabling of UAC, the original author of Boxstarter added some information about why disabling of UAC is required in the context of Boxstarter here: chocolatey/boxstarter#358 (comment) At the end of the Boxstarter execution, the UAC status will be returned to what it was before it started. You can see that in the video I linked to: Cancelling the Boxstarter execution obviously prevents this from being re-enabled. As I mentioned, if we could start collating what is different/similar between the machines where there is a problem, and those where there aren't, it would help to try to get to the bottom of the problem. Adding @pauby @flcdrg @mwallner @ferventcoder |
Howdy folks - I filed a PR to make folks aware of the behavior upon installation - #24000 |
FYI, I was able to get into a similar state (with Node 10, not just 11) and got a powershell prompt with So I hope any future fix will make it into Node 10 as well, not just to master. |
Experienced something similar. I opt'ed in (v11.1.0). It ran the script, rebooted, ran its post-reboot script and rebooted again, this time to a black screen. I don't know if it rebooted several times because I wasn't even seeing the Windows loader and the screen remain black without flashing or anything. Hitting the reset button few times didn't help it, so I ended cold-booting and then Windows finally came up. Then, another script pop, it tried to install few redistributables, but the actual resources were missing so it failed those parts. No idea how to verify the integrity of this entire bizarre process. Plus, I have no idea if it left my OS pristine or changed things like permissions and so. PS, Edit: It seems I had an issue with my keyboard, so the part where the screen went black seems like a local issue. Anyway, this cleared a lot of things for me: chocolatey/boxstarter#357 (comment) |
Yup, same here. I figured since it's LTS, it was safe to install. I also had Chocolatey already installed on my machine before installing Node 10 |
choco upgrade -y python2 Sugested by Alex888 works like a charm, I've previosly turned UAC off |
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: nodejs#24344 Refs: nodejs#22645 Refs: nodejs#23987 Refs: nodejs/Release#369 Refs: nodejs#23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
ran into the same thing today using Node 10. I had everything except python (I have python 3 installed). aborted the process in the middle, uninstalled node and now I am manually installing dependencies (following the steps written in node-gyp repo). |
After the first sudden restart, I found I was logged out of all websites on Chrome. Soon after the second restart came and I had to stop it. I removed everything I could find related to Chocolatey and Boxstarter. Checking that automatic installation was a mistake, it's unnecessarily aggressive and intrusive. Edit: I used Windows Restore to make sure everything is back to normal. I suggest anyone experiencing similar issues to do the same |
Use Chocolatey directly in the tools installation script. Fixes: nodejs#23838
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
@joaocgreis |
This reverts: Revision: 257a5e9 win: add prompt to tools installation script Revision: e9a2915 win: clarify Boxstarter behavior on install tools Revision: 3b895d1 win,msi: display license notes before installing tools Revision: cf284c8 win,msi: install Boxstarter from elevated shell Revision: 2b7e18d win,msi: highlight installation of 3rd-party tools Revision: ebf36cd win,msi: install tools for native modules PR-URL: #24344 Refs: #22645 Refs: #23987 Refs: nodejs/Release#369 Refs: #23838 Refs: nodejs/security-wg#439 Reviewed-By: João Reis <reis@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Use Chocolatey directly in the tools installation script. PR-URL: nodejs#24677 Fixes: nodejs#23838 Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Apologies if this is the wrong place to report this. But I just tried the windows installer for Node v11.0. There was an option to install build-tooling using chocolatey and boxstarter. It warned me that there would be reboots. After it rebooted over 20 times I kind of figured it was in a permanent reboot cycle so I stopped it. I am on an AD so I'm wondering if maybe there is some conflicting policy or antivirus at work that may be interfering with this process.
I'll try to update this task when I have time to try this on my home machine.
Not sure what more I can provide in the way of a test case..
The text was updated successfully, but these errors were encountered: