doc: clarify Boxstarter behavior on install tools #24000
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify the behavior of what Boxstarter may do when it runs on a box to install all the necessary tools so that there are no surprises to the end user when the script is run. Currently there is no interface that warns the user that Boxstarter will reboot the machine possibly multiple times depending on how many dependencies need to be installed and doesn't mention a need to disable UAC. For folks who see what may look like a reboot loop, we feel it is necessary to make them aware that UAC will be disabled and they will need to take action to re-enable UAC manually if they interfere/stop the script from finishing.
nodejs-github-bot
added
install
Trott
reviewed
Oct 31, 2018
| cls | ||
| echo !!!!!WARNING!!!!! | ||
| echo ----------------- | ||
| echo Use of Boxstarter may reboot your box automatically multiple times. When |
There was a problem hiding this comment.
Nit-picking a bit, but "reboot your box" is rather colloquial. "reboot your computer" or something like that is probably preferable.
There was a problem hiding this comment.
Sounds good to me!
Trott
reviewed
Oct 31, 2018
| echo !!!!!WARNING!!!!! | ||
| echo ----------------- | ||
| echo Use of Boxstarter may reboot your box automatically multiple times. When | ||
| echo performing a reboot, Boxstarter will need to disable UAC to allow the |
There was a problem hiding this comment.
Is it worth it to spell out what UAC refers to? Or are most Windows users going to know?
There was a problem hiding this comment.
As a developer using Windows, I guess you should know what it means. Looks much better now.
There was a problem hiding this comment.
I see this was fixed up by @joaocgreis
|
Thanks for opening this PR! I included this in #23987 as discussed there. |
|
Closed in favor of including this with #23987. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify the behavior of what Boxstarter may do when it runs on a box
to install all the necessary tools so that there are no surprises to
the end user when the script is run.
Currently there is no interface that warns the user that Boxstarter will
reboot the machine possibly multiple times depending on how many
dependencies need to be installed and doesn't mention a need to disable
UAC. For folks who see what may look like a reboot loop, we feel it is
necessary to make them aware that UAC will be disabled and they will need
to take action to re-enable UAC manually if they interfere/stop the script
from finishing.
Checklist
References #23838