-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Calling Intl.v8BreakIterator makes the process crash #3111
Comments
Yea, I'm seeing this also. It works when built with full-icu, but fails with small-icu |
/cc @nodejs/intl |
V8 wanted this to be a fatal instead of just a soft error (exception or Yes small Icu doesn't have the data needed for this undocumented feature. If this is an important feature lets get it added to ecma402 El martes, 29 de septiembre de 2015, Ben Noordhuis notifications@github.com
|
Should we "delete" the |
Does anyone know what Maybe @ajklein knows more about this method. |
@nciric would know much better than I (this is the best I could find: https://code.google.com/p/v8-i18n/wiki/BreakIterator). |
Break iterator does character/sentence segmentation in a locale friendly way. It relies on largish data files, and that's one of the reasons we added it to the Intl.* for Chrome/V8. Intl.v8BreakIterator is not part of ECMA 402 spec. Feel free to remove support for it from node. V8 may needed it for some internal projects. |
Nah just make it throw. |
OK. Current thought:
|
Does node exposes any other v8 specific functionality? I'm worry about portability of the code if you use |
@caridy no, nothing like that is exposed. |
I will say then, make it throw, and lets work on getting the break iterator in 402. |
+1 to making it throw until it's part of 402 |
Throw.. Iff we are in "small Icu".
|
If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Fixes nodejs#3111
|
If the undocumented v8BreakIterator does not have data available, monkeypatch it to throw an error instead of crashing. Backport of nodejs#3111 c99f231
This is the line where it happens:
node/deps/v8/src/i18n.cc
Line 914 in 64beab0
I guess that the feature v8 is trying to load is not available with
small-icu
? Anyway it seems wrong to experience a fatal error in this case.The text was updated successfully, but these errors were encountered: