Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

intl: (v4.x) Don't crash if v8BreakIterator not available #9008

Closed
wants to merge 1 commit into from
Closed

intl: (v4.x) Don't crash if v8BreakIterator not available #9008

wants to merge 1 commit into from

Conversation

srl295
Copy link
Member

@srl295 srl295 commented Oct 10, 2016 •
edited
Loading

Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines (think so?)
Affected core subsystem(s)

deps

Description of change

If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Backport of #3111 c99f231

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. v4.x labels Oct 10, 2016
@srl295 srl295 self-assigned this Oct 10, 2016
@srl295 srl295 added i18n-api Issues and PRs related to the i18n implementation. and removed c++ Issues and PRs that require attention from people who are familiar with C++. v4.x labels Oct 10, 2016
@srl295
intl: (v4.x) Don't crash if v8BreakIterator not available
ab3766a 
If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Backport of nodejs#3111 c99f231
@srl295 srl295 mentioned this pull request Oct 10, 2016
Closed
jasnell
jasnell approved these changes Oct 10, 2016
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MylesBorins
Copy link
Contributor

LGTM

@mscdex mscdex added the v4.x label Oct 10, 2016
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@srl295
intl: Don't crash if v8BreakIterator not available
0d53956 
If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Fixes: #3111
Ref: #9008
PR-URL: #4253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@MylesBorins
Copy link
Contributor

landed in 0d53956

@srl295 take a peak at the commit message there, we generally replicate the original message and add the new PR as a Ref:.

@srl295 srl295 deleted the backport-4253-v8brk-v4x branch October 10, 2016 19:16
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@srl295
intl: Don't crash if v8BreakIterator not available
b06323c 
If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Fixes: #3111
Ref: #9008
PR-URL: #4253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@srl295 @rvagg
intl: Don't crash if v8BreakIterator not available
d5d69fd 
If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Fixes: #3111
Ref: #9008
PR-URL: #4253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@srl295 @MylesBorins
intl: Don't crash if v8BreakIterator not available
2e29b76 
If the undocumented v8BreakIterator does not have data available,
monkeypatch it to throw an error instead of crashing.

Fixes: #3111
Ref: #9008
PR-URL: #4253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

Assignees

@srl295 srl295

Labels
i18n-api Issues and PRs related to the i18n implementation.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@srl295 @MylesBorins @jasnell @mscdex @nodejs-github-bot