Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

17.7 Regression on url.resolve breaks Yarn 1.x #42279

Closed
arcanis opened this issue Mar 10, 2022 · 0 comments · Fixed by #42280
Closed

17.7 Regression on url.resolve breaks Yarn 1.x #42279

arcanis opened this issue Mar 10, 2022 · 0 comments · Fixed by #42280
Labels
url Issues and PRs related to the legacy built-in url module.

Comments

@arcanis
Copy link
Contributor

arcanis commented Mar 10, 2022

Version

17.7

Platform

n/a

Subsystem

n/a

What steps will reproduce the bug?

yarn init
yarn add @zkochan/cmd-shim

How often does it reproduce? Is there a required condition?

Always

What is the expected behavior?

Should work as in 17.6

What do you see instead?

info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...
info There appears to be trouble with your network connection. Retrying...

Additional information

Caused by #42136. This diff seems to break Yarn Classic, which does:

url.resolve('https://registry.npmjs.org', '@foo/bar')

Node 17.6: https://registry.npmjs.org/@foo/bar
Node 17.7: https://foo/bar
@arcanis arcanis mentioned this issue Mar 10, 2022
Closed
aduh95 added a commit to aduh95/node that referenced this issue Mar 10, 2022
@aduh95
url: revert fix url.parse() for @hostname
b534057 
This reverts commit 010cb71.

Refs: nodejs#42279
@aduh95 aduh95 mentioned this issue Mar 10, 2022
Merged
@meixg meixg added the url Issues and PRs related to the legacy built-in url module. label Mar 10, 2022
sxa pushed a commit to sxa/node that referenced this issue Mar 10, 2022
@aduh95 @sxa
url: revert fix url.parse() for @hostname
e0db472 
This reverts commit 010cb71.

Refs: nodejs#42279
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
@Trott
chore: add test case for reverted 17.7 regression
a1ccf0a 
Refs: nodejs#42279
Trott pushed a commit to Trott/io.js that referenced this issue Mar 10, 2022
@aduh95 @Trott
url: revert fix url.parse() for @hostname
280a396 
This reverts commit 010cb71.

Refs: nodejs#42279
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
@Trott
chore: add test case for reverted 17.7 regression
0e77098 
Refs: nodejs#42279
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
@Trott
test: add test case for reverted 17.7 regression
c8204eb 
Refs: nodejs#42279
This was referenced Mar 10, 2022
Merged
Closed
nodejs-github-bot pushed a commit that referenced this issue Mar 10, 2022
@aduh95
url: revert fix url.parse() for @hostname
f91950c 
This reverts commit 010cb71.

Refs: #42279

PR-URL: #42280
Fixes: #42279
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Trott added a commit to Trott/io.js that referenced this issue Mar 10, 2022
@Trott
test: add test case for reverted 17.7 regression
860f6de 
Refs: nodejs#42279
sxa pushed a commit that referenced this issue Mar 10, 2022
@aduh95 @sxa
url: revert fix url.parse() for @hostname
96a9e00 
This reverts commit 010cb71.

Refs: #42279

PR-URL: #42280
Fixes: #42279
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@slorber slorber mentioned this issue Mar 10, 2022
Merged
@timotheeguerin timotheeguerin mentioned this issue Mar 10, 2022
Closed
2 tasks
@zburke zburke mentioned this issue Mar 10, 2022
Closed
nodejs-github-bot pushed a commit that referenced this issue Mar 11, 2022
@Trott
test: add test case for reverted 17.7 regression
bf357b7 
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
simao-silva added a commit to simao-silva/docker-renovate that referenced this issue Mar 11, 2022
@simao-silva
Unlocked Node version
c31363c 
Node version 17.6.0 had a continuous error message "info There appears to be trouble with your network connection. Retrying..." corrected by nodejs/node#42279 with the release of version 17.6.1.
bengl pushed a commit that referenced this issue Mar 21, 2022
@Trott @bengl
test: add test case for reverted 17.7 regression
94e5eaa 
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit to danielleadams/node that referenced this issue Apr 21, 2022
@Trott @danielleadams
test: add test case for reverted 17.7 regression
8eb0cbd 
Refs: nodejs#42279

PR-URL: nodejs#42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@Trott @danielleadams
test: add test case for reverted 17.7 regression
701eda9 
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@Trott @danielleadams
test: add test case for reverted 17.7 regression
2aed44e 
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this issue Apr 24, 2022
@Trott @danielleadams
test: add test case for reverted 17.7 regression
245577e 
Refs: #42279

PR-URL: #42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@aduh95 @xtx1130
url: revert fix url.parse() for @hostname
e9ec967 
This reverts commit 010cb71.

Refs: nodejs#42279

PR-URL: nodejs#42280
Fixes: nodejs#42279
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
xtx1130 pushed a commit to xtx1130/node that referenced this issue Apr 25, 2022
@Trott @xtx1130
test: add test case for reverted 17.7 regression
5b55d97 
Refs: nodejs#42279

PR-URL: nodejs#42283
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

url: revert fix url.parse() for @hostname aduh95/node
2 participants
@arcanis @meixg