Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

url: revert fix url.parse() for @hostname #42280

Merged
merged 1 commit into from
Mar 10, 2022
Merged

url: revert fix url.parse() for @hostname #42280

merged 1 commit into from
Mar 10, 2022

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Mar 10, 2022 •
edited
Loading

This reverts commit 010cb71.

Fixes: #42279

@aduh95 aduh95 requested a review from Trott March 10, 2022 11:32
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module. labels Mar 10, 2022
This was referenced Mar 10, 2022
Merged
Closed
@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2022
@sxa sxa added fast-track PRs that do not need to wait for 48 hours to land. and removed request-ci Add this label to start a Jenkins CI on a PR. labels Mar 10, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @sxa. Please 👍 to approve.

@richardlau richardlau added the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Mar 10, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/42932/

This was referenced Mar 10, 2022
Merged
Closed
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Mar 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit f91950c into nodejs:master Mar 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f91950c

@merceyz merceyz mentioned this pull request Mar 10, 2022
Closed
sxa pushed a commit that referenced this pull request Mar 10, 2022
@aduh95 @sxa
url: revert fix url.parse() for @hostname
96a9e00 
This reverts commit 010cb71.

Refs: #42279

PR-URL: #42280
Fixes: #42279
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@sxa sxa mentioned this pull request Mar 10, 2022
Merged
@zburke zburke mentioned this pull request Mar 10, 2022
Closed
@aduh95 aduh95 deleted the revert-legacy-url-fix branch March 11, 2022 00:02
@Trott

This comment was marked as resolved.

Sign in to view
xtx1130 pushed a commit to xtx1130/node that referenced this pull request Apr 25, 2022
@aduh95 @xtx1130
url: revert fix url.parse() for @hostname
e9ec967 
This reverts commit 010cb71.

Refs: nodejs#42279

PR-URL: nodejs#42280
Fixes: nodejs#42279
Reviewed-By: Stewart X Addison <sxa@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@richardlau richardlau richardlau approved these changes

@sxa sxa sxa approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. url Issues and PRs related to the legacy built-in url module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

17.7 Regression on url.resolve breaks Yarn 1.x
6 participants
@aduh95 @nodejs-github-bot @Trott @richardlau @sxa @RaisinTen