-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
init_process_flags.is_lock_free check fails on mipsel #45152
Comments
The comment for that assert explains it: // init_process_flags is accessed in ResetStdio(),
// which can be called from signal handlers. If it's not lock-free, it's protected by a mutex, and mutexes aren't safe to use inside a signal handler (can deadlock.) Try changing it from an atomic |
Changing it to |
Sorry, no: |
Fix nodejs#45152 PR-URL: nodejs#45221 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Version
v18.11.0
Platform
Linux 4.19.0-21-octeon #1 SMP Debian 4.19.249-2 (2022-06-30) mips64el (mips64)
Subsystem
node
What steps will reproduce the bug?
Build nodejs with mipsel target. On debian.
How often does it reproduce? Is there a required condition?
Something about the slowness of the host arch maybe ?
What is the expected behavior?
Same thing used to work with nodejs 18.10.0.
What do you see instead?
full build log
Additional information
As usual, I know this isn't a supported architecture.
However it might be a hidden bug actually affecting other architectures, only on high load.
Build machine info.
The text was updated successfully, but these errors were encountered: