Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lock-free init_process_flags for all archs #45221

Merged
merged 1 commit into from
Oct 31, 2022
Merged

lock-free init_process_flags for all archs #45221

merged 1 commit into from
Oct 31, 2022

Conversation

kapouer
Copy link
Contributor

@kapouer kapouer commented Oct 28, 2022

Fix #45152

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/startup

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Oct 28, 2022
addaleax
addaleax reviewed Oct 28, 2022
View reviewed changes
src/node.cc Show resolved Hide resolved
addaleax
addaleax requested changes Oct 28, 2022
View reviewed changes
src/node.h Outdated Show resolved Hide resolved
src/node.cc Show resolved Hide resolved
@kapouer kapouer force-pushed the patch-4 branch 2 times, most recently from 2fc42b0 to 1627557 Compare October 28, 2022 13:19
@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@kapouer
Copy link
Contributor Author

kapouer commented Oct 28, 2022 •
edited
Loading

@addaleax changed TODO(addaleax) and wrapped line to 80 chars.

@addaleax addaleax added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 28, 2022
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
@nodejs-github-bot

This comment was marked as outdated.

Sign in to view
This was referenced Oct 29, 2022
Open
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47593/

@Flarna Flarna added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. and removed needs-ci PRs that need a full CI run. labels Oct 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 3d1bdc9 into nodejs:main Oct 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 3d1bdc9

@github-actions github-actions bot mentioned this pull request Nov 1, 2022
Open
17 tasks
RafaelGSS pushed a commit that referenced this pull request Nov 1, 2022
@kapouer @RafaelGSS
src: lock-free init_process_flags
db81931 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@RafaelGSS RafaelGSS mentioned this pull request Nov 1, 2022
Merged
@github-actions github-actions bot mentioned this pull request Nov 2, 2022
Open
15 tasks
lucshi pushed a commit to lucshi/node that referenced this pull request Nov 9, 2022
@kapouer @lucshi
src: lock-free init_process_flags
82173c1 
Fix nodejs#45152

PR-URL: nodejs#45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
RafaelGSS pushed a commit that referenced this pull request Nov 10, 2022
@kapouer @RafaelGSS
src: lock-free init_process_flags
97547bc 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@kapouer @danielleadams
src: lock-free init_process_flags
9d63883 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
@danielleadams danielleadams mentioned this pull request Dec 30, 2022
Merged
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
@kapouer @danielleadams
src: lock-free init_process_flags
8247d10 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
@kapouer @danielleadams
src: lock-free init_process_flags
bf028a6 
Fix #45152

PR-URL: #45221
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2023
@addaleax
src: use uint32_t for process initialization flags enum
52853ca 
Refs: nodejs#45221
@addaleax addaleax mentioned this pull request Jan 30, 2023
Merged
addaleax added a commit to addaleax/node that referenced this pull request Jan 30, 2023
@addaleax
src: use uint32_t for process initialization flags enum
f3cffbd 
Refs: nodejs#45221
nodejs-github-bot pushed a commit that referenced this pull request Feb 2, 2023
@addaleax
src: use uint32_t for process initialization flags enum
f84de0a 
Refs: #45221
PR-URL: #46427
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@addaleax addaleax addaleax approved these changes

@juanarbol juanarbol juanarbol approved these changes

@Flarna Flarna Flarna approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

init_process_flags.is_lock_free check fails on mipsel
5 participants
@kapouer @nodejs-github-bot @addaleax @juanarbol @Flarna