Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Discussion: assert.CallTracker future #47492

Closed
MoLow opened this issue Apr 9, 2023 · 3 comments · Fixed by #47740
Closed

Discussion: assert.CallTracker future #47492

MoLow opened this issue Apr 9, 2023 · 3 comments · Fixed by #47740
Labels
assert Issues and PRs related to the assert subsystem. discuss Issues opened for discussions and feedbacks.

Comments

@MoLow
Copy link
Member

MoLow commented Apr 9, 2023 •
edited
Loading

assert.CallTracker has been added three years ago,
it has been marked as experimental a few weeks later

there is now also an alternative subset mock within node:test: https://nodejs.org/api/test.html#mocking

after such a long time as an experimental API, I suggest we should decide if assert.CallTracker should exit experimental stage or should be deprecated in favor of mock
@MoLow MoLow added assert Issues and PRs related to the assert subsystem. discuss Issues opened for discussions and feedbacks. labels Apr 9, 2023
@MoLow
Copy link
Member Author

MoLow commented Apr 9, 2023

CC @nodejs/assert

@jasnell
Copy link
Member

jasnell commented Apr 10, 2023

I think deprecating it makes sense. I'd hoped that it would progress but the interest never materialized.

@ErickWendel
Copy link
Member

+1 for deprecating it

@MoLow MoLow mentioned this issue Apr 27, 2023
Merged
nodejs-github-bot pushed a commit that referenced this issue Apr 29, 2023
@MoLow
assert: deprecate callTracker
adf332b 
PR-URL: #47740
Fixes: #47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
yjl9903 pushed a commit to yjl9903/node that referenced this issue Apr 29, 2023
@MoLow @yjl9903
assert: deprecate callTracker
73feca6 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 2, 2023
@MoLow @targos
assert: deprecate callTracker
5e99598 
PR-URL: #47740
Fixes: #47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this issue May 3, 2023
@MoLow @targos
assert: deprecate callTracker
33d1bd3 
PR-URL: #47740
Fixes: #47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Jul 6, 2023
@MoLow
assert: deprecate callTracker
f9016ab 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow MoLow mentioned this issue Jul 6, 2023
Closed
MoLow added a commit to MoLow/node that referenced this issue Jul 6, 2023
@MoLow
assert: deprecate callTracker
0a4e25d 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Jul 9, 2023
@MoLow
assert: deprecate callTracker
c5cb170 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Jul 9, 2023
@MoLow
assert: deprecate callTracker
c27d39e 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MoLow added a commit to MoLow/node that referenced this issue Jul 9, 2023
@MoLow
assert: deprecate callTracker
96a3209 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. discuss Issues opened for discussions and feedbacks.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

assert: deprecate callTracker MoLow/node
3 participants
@jasnell @ErickWendel @MoLow