Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v18.x backport] assert: deprecate callTracker #48681

Closed
wants to merge 1 commit into from
Closed

[v18.x backport] assert: deprecate callTracker #48681

wants to merge 1 commit into from

Conversation

MoLow
Copy link
Member

@MoLow MoLow commented Jul 6, 2023

PR-URL: #47740
Fixes: #47492
Reviewed-By: Erick Wendel erick.workspace@gmail.com
Reviewed-By: Benjamin Gruenbaum benjamingr@gmail.com
Reviewed-By: James M Snell jasnell@gmail.com

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch. labels Jul 6, 2023
@MoLow MoLow force-pushed the backport-call-tracker-deprecation branch 4 times, most recently from c27d39e to 6bb7c53 Compare July 9, 2023 19:22
@MoLow MoLow added the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@MoLow MoLow requested a review from danielleadams July 9, 2023 19:32
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jul 9, 2023
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/52672/

@MoLow
assert: deprecate callTracker
96a3209 
PR-URL: nodejs#47740
Fixes: nodejs#47492
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MoLow MoLow force-pushed the backport-call-tracker-deprecation branch from 6bb7c53 to 96a3209 Compare July 9, 2023 20:26
@MoLow
Copy link
Member Author

MoLow commented Jul 9, 2023

it seems this is missing the deprecation before this (DEP0172: The asyncResourceproperty ofAsyncResource bound functions) wich is not backported to v18.
I think it is ok for this to not be backported as well, @danielleadams WDYT?

@danielleadams
Copy link
Contributor

@MoLow yes - as long as the deprecation numbers stay in order, that should be fine.

@MoLow MoLow closed this Jul 10, 2023
@MoLow MoLow deleted the backport-call-tracker-deprecation branch July 10, 2023 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielleadams danielleadams Awaiting requested review from danielleadams

Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. needs-ci PRs that need a full CI run. v18.x Issues that can be reproduced on v18.x or PRs targeting the v18.x-staging branch.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoLow @nodejs-github-bot @danielleadams