Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

governance: add new collaborators #X #5064

Closed
Trott opened this issue Feb 3, 2016 · 57 comments
Closed

governance: add new collaborators #X #5064

Trott opened this issue Feb 3, 2016 · 57 comments
Labels
meta Issues and PRs related to the general management of the project.

Comments

@Trott
Copy link
Member

Trott commented Feb 3, 2016

Continued discussion from #3761.

Names that have come up so far this round:
@Trott Trott added the meta Issues and PRs related to the general management of the project. label Feb 3, 2016
@Trott Trott mentioned this issue Feb 3, 2016
Closed
@evanlucas
Copy link
Contributor

I'd like make sure @matthewloring (commits, issue comments) is nominated too.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

There are a number of other people in #3761 who aren't listed here. I'll make a list.

@Fishrock123
Copy link
Contributor

I suggest we use this format from past threads:

- @{NAME} [commits](https://github.com/nodejs/node/commits/master?author={NAME}), [issue comments](https://github.com/nodejs/node/issues?page=1&q=commenter%3A{NAME}&utf8=%E2%9C%93)

This gives any of us a quick overview of their activity.

@Trott
Copy link
Member Author

Trott commented Feb 3, 2016

@Fishrock123 I've edited the issue description to use that format. Thanks.

@GlenTiki
Copy link
Contributor

GlenTiki commented Feb 3, 2016

@Trott I'm awaiting processing too :)

@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

@thekemkid I'm updating the list and have your name.

@GlenTiki
Copy link
Contributor

GlenTiki commented Feb 3, 2016

@cjihrig Cool. So for new readers worried that their name isn't there, don't spam? :)

@cjihrig
Copy link
Contributor

cjihrig commented Feb 3, 2016

OK, I updated the original list.

@Trott
Copy link
Member Author

Trott commented Feb 3, 2016

Recent-ish commit activity should not be the only metric we look at of course. (Just stating the obvious for the benefit of outside observers.) But it seems to me that it's far from a useless metric. So here's a list:

@estliberitas
Copy link
Contributor

Wow, I must do more useful contribs to get into org. Good motivation.

@jbergstroem
Copy link
Member

@Trott how about getting the number of commits and comments into the first message? I reckon activity is is a good way to show engagement.

@pmq20
Copy link
Contributor

pmq20 commented Feb 4, 2016

Thanks for nominating. Though recently being absent due to work, I'd be contributing more if I was officially on board.

@whitlockjc
Copy link
Contributor

PRs wouldn't be bad as well if we're looking for total work.

@MylesBorins
Copy link
Contributor

I'd be willing to help with onboarding if ya'll need help

@rvagg
Copy link
Member

rvagg commented Feb 8, 2016

I think we should set up a @nodejs/onboarding, who should be involved in that? @Fishrock123, @chrisdickinson? Who has been doing this work recently and who would like to be involved?

I wouldn't mind the onboarding process to focus a little more on governance and the level of responsibility placed into the hands of collaborators, thinking particularly of this interaction:

screenshot from 2016-02-08 16-33-18

(not picking on you @thefourtheye, this is just a great illustration of the understanding gap that I think exists in general)

Lack of familiarity with the fact that we have a high-bar for major changes and that collaborators have a right and responsibility to expect people proposing changes to convince them of the need for such changes is an important factor in maintaining stability in both the short and long-term for the project. I suspect there's a general lack of awareness of this in some of the major-change PRs and discussions that are going on at the moment, such as the Promises PR and the ES Modules discussion happening over in node-eps. Collaborators are not second class in these discussions and can't be steam-rolled by noisy crowds as they flock to hot-button issues as they arise and I'd love to see folks asserting themselves a bit more strongly where they have concerns that need to be assuaged; the onus of that is on the change-proposer to do that work, not the folks defending status quo.

@thefourtheye
Copy link
Contributor

@rvagg No problem :-) I learnt our process better there.

@Chris911
Copy link
Contributor

Chris911 commented Feb 9, 2016

As part of onboarding or just welcoming new contributors more easily I think current contributors should be more active in tagging issues as good first contribution and proactively creating issues for features/tasks that are on the roadmap (officially or not). I was happy to see this label when looking for my first contribution but there isn't many new issues in the list + most of the issues still opened have a pending PR that hasn't landed yet. There are a lot of reported bugs in issues for not many tasks.

@Fishrock123 did a good job giving me some onboarding instruction outside Github so +1 for that. Official onboarding docs would surely help both technically and also explaining the governance model as @rvagg mentioned.

Looking forward to being on that list for the next batch! 👍

@claudiorodriguez
Copy link
Contributor

Keep in mind that I recently removed an email from my github account (cr@fansworld.tv) - that email was associated with most of the commits I made on this repository, so now if you search for my user's commits they won't show up, but they do show up here: https://github.com/nodejs/node/commits/master?author=cr@fansworld.tv

PS I'm always happy to contribute in any way. I seem to be finding a niche in the tools/test/doc area

@tomgco
Copy link
Contributor

tomgco commented Feb 9, 2016

Thanks for the nomination @rvagg and @jasnell, I am currently dedicating my Friday's working on core / other areas within the Node.js organisation, and I would be more than happy to help out in any way possible. 💃

@Fishrock123
Copy link
Contributor

Will try to get to this tomorrow...

@phillipj
Copy link
Member

As part of onboarding or just welcoming new contributors more easily I think current contributors should be more active in tagging issues as good first contribution and proactively creating issues for features/tasks that are on the roadmap (officially or not).

Agreed. More first contrib labels would be really great. We've got such a vibrant community that such issues get picked in no time, which of course is awesome, but sad for those of us not fast enough :)

@evanlucas
Copy link
Contributor

I'd like to nominate @benjamingr. He has been actively involved for quite some time now and is a member of other working groups including documentation, Localization, and nodejs-he.

@rvagg
Copy link
Member

rvagg commented Feb 25, 2016

+1 to @benjamingr

+1 to @ronkorving in the original list too

Who's going to run the next onboarding?

@benjamingr
Copy link
Member

Yeah sure. I'd be honored.

@evanlucas
Copy link
Contributor

I'd be happy to help with onboarding. I know @Fishrock123 and @chrisdickinson both have a lot of their plates.

@cjihrig
Copy link
Contributor

cjihrig commented Feb 25, 2016

I'm willing to help too. I've never seen an onboarding though, so I'd like to sit in on one first.

@thefourtheye
Copy link
Contributor

+1 to @benjamingr's nomination. His knowledge and contributions in Promises WG is phenomenal.

@chrisdickinson
Copy link
Contributor

+1 to @benjamingr, his work on the promises PR and WG has been great.

@claudiorodriguez
Copy link
Contributor

Friday's good, thanks a bunch for this!

@GlenTiki
Copy link
Contributor

GlenTiki commented Mar 9, 2016

Cool, I'll be there.

@Trott
Copy link
Member Author

Trott commented Mar 9, 2016

@Fishrock123 If omitting me makes things easier, then please omit me.

Hopefully someone will be able to do another onboarding soon to get in the people we miss. So many great contributors!

@AndreasMadsen
Copy link
Member

Awesome, looking forward to it.

@phillipj
Copy link
Member

phillipj commented Mar 9, 2016

Thanks, I'm in 👍

@AndreasMadsen
Copy link
Member

@Fishrock123 are we going to get an invite for the hangout?

@MylesBorins
Copy link
Contributor

@Fishrock123 I don't feel like I particularly need a refresher. I'm up for helping with whatever you need though. I'll try and sync with you on irc

@Fishrock123
Copy link
Contributor

Ok. Idk how to make an actual event or what everyone's google address are, so I'm just going to rely on posting the link here around the time (in 15 minutes)

@Fishrock123
Copy link
Contributor

Call link (Google Hangouts): https://hangouts.google.com/call/mzopunh4uncybgbcnp3zjbkyxue

Document: https://github.com/Fishrock123/node/blob/onboarding-docs/doc/onboarding.md
Extras: https://github.com/Fishrock123/node/blob/onboarding-docs/doc/onboarding-extras.md

@benjamingr benjamingr mentioned this issue Mar 11, 2016
Closed
benjamingr added a commit that referenced this issue Mar 11, 2016
@benjamingr
doc: add benjamingr to collaborator list
9b7a406 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
benjamingr added a commit that referenced this issue Mar 11, 2016
@benjamingr
doc: add benjamingr to collaborator list
a74bf87 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@Fishrock123
Copy link
Contributor

Ons set of people down! 🎉

@ronkorving
Copy link
Contributor

Sweet! :)

@benjamingr benjamingr mentioned this issue Mar 14, 2016
Closed
evanlucas pushed a commit that referenced this issue Mar 14, 2016
@benjamingr @evanlucas
doc: add benjamingr to collaborator list
6443bf2 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit that referenced this issue Mar 16, 2016
@benjamingr @rvagg
doc: add benjamingr to collaborator list
8e1f670 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this issue Mar 17, 2016
@benjamingr
doc: add benjamingr to collaborator list
6c5f188 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@Trott
Copy link
Member Author

Trott commented Mar 18, 2016

This happened, so I'm going to close this and open one for a new round to hopefully pick up some of the people that were missed in this round.

@Trott Trott closed this as completed Mar 18, 2016
@Fishrock123 Fishrock123 mentioned this issue Mar 18, 2016
Closed
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@benjamingr
doc: add benjamingr to collaborator list
db21c17 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this issue Mar 21, 2016
@benjamingr
doc: add benjamingr to collaborator list
e5f254d 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@stefanmb
Copy link
Contributor

@Trott If nominated in the first post, how do we know if we're actually selected to be onboarded?

@Trott
Copy link
Member Author

Trott commented Mar 22, 2016

@stefanmb In this particular case, @Fishrock123 posted a Doodle link and asked anyone who was listed to fill it out so he could figure a good time to onboard people.

So, if you missed this round of onboarding and want to get in on the next round, maybe leave a comment at #5779 (which is the issue for the next round) saying that you missed the last round but would be interested.

A more concrete process might be in order (or maybe not) and the CTC might discuss it tomorrow. (I've added onboarding as an agenda item but I don't know how much time there will be or how much interest there will be in getting too deep into the weeds on it.)

This was referenced Apr 24, 2023
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests