Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add benjamingr to collaborator list #5664

Closed
wants to merge 1 commit into from
Closed

doc: add benjamingr to collaborator list #5664

wants to merge 1 commit into from

Conversation

benjamingr
Copy link
Member

Adding myself to the list as part of the collaborator onboarding process

Add benjamingr to collaborator list.
refs: #5064

cc @nodejs/documentation

@Fishrock123 Fishrock123 added the doc Issues and PRs related to the documentations. label Mar 11, 2016
@Fishrock123
Copy link
Contributor

LGTM

@stevemao
Copy link
Contributor

LGTM

Edited: Please don't sign-off unless you are on the Collaborators list, Thanks! -Fishrock123

@whitlockjc
Copy link
Contributor

LGTM

1 similar comment
@evanlucas
Copy link
Contributor

LGTM

@whitlockjc
Copy link
Contributor

What's it like being at the top of the list? ;)

@benjamingr
doc: add benjamingr to collaborator list
9b7a406 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
benjamingr added a commit that referenced this pull request Mar 11, 2016
@benjamingr
doc: add benjamingr to collaborator list
a74bf87 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@benjamingr
Copy link
Member Author

Landed in a74bf87

@benjamingr benjamingr closed this Mar 11, 2016
@Fishrock123 Fishrock123 deleted the benjamingr-add-collaborator branch March 11, 2016 22:15
@rvagg
Copy link
Member

rvagg commented Mar 14, 2016

Woot! Welcome @benjamingr!

@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Closed
evanlucas pushed a commit that referenced this pull request Mar 14, 2016
@benjamingr @evanlucas
doc: add benjamingr to collaborator list
6443bf2 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@evanlucas evanlucas mentioned this pull request Mar 14, 2016
Merged
rvagg pushed a commit that referenced this pull request Mar 16, 2016
@benjamingr @rvagg
doc: add benjamingr to collaborator list
8e1f670 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins
Copy link
Contributor

🎉

MylesBorins pushed a commit that referenced this pull request Mar 17, 2016
@benjamingr
doc: add benjamingr to collaborator list
6c5f188 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@benjamingr
doc: add benjamingr to collaborator list
db21c17 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Mar 21, 2016
@benjamingr
doc: add benjamingr to collaborator list
e5f254d 
Add benjamingr to collaborator list.
Related #5064

PR-URL: #5664
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@benjamingr @Fishrock123 @stevemao @whitlockjc @evanlucas @rvagg @MylesBorins @jasnell