You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
srl295 opened this issue
Oct 1, 2024
· 2 comments
· May be fixed by #55215
Assignees
Labels
buildIssues and PRs related to build files or the CI.icuIssues and PRs related to the ICU dependency.pythonPRs and issues that require attention from people who are familiar with Python.
How often does it reproduce? Is there a required condition?
always
What is the expected behavior? Why is that the expected behavior?
successful configure
What do you see instead?
Traceback (most recent call last):
File "C:\Users\srl29\src\node\configure", line 28, in <module>
import configure
File "C:\Users\srl29\src\node\configure.py", line 2204, in <module>
configure_intl(output)
File "C:\Users\srl29\src\node\configure.py", line 1939, in configure_intl
elif with_icu_source and Path(icu_full_path).resolve() == Path(with_icu_source).resolve():
File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 1215, in resolve
s = self._flavour.resolve(self, strict=strict)
File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 215, in resolve
s = self._ext_to_normal(_getfinalpathname(s))
OSError: [WinError 123] El nombre de archivo, el nombre de directorio o la sintaxis de la etiqueta del volumen no son correctos: 'https:\\github.com\\unicode-org\\icu\\releases\\download\\release-76-rc\\icu4c-76_1-src.tgz'
srl295
changed the title
configure path refactoring broke ICU download on windows
build: configure path refactoring broke ICU download on windows
Oct 1, 2024
srl295
added
build
Issues and PRs related to build files or the CI.
i18n-api
Issues and PRs related to the i18n implementation.
python
PRs and issues that require attention from people who are familiar with Python.
icu
Issues and PRs related to the ICU dependency.
and removed
i18n-api
Issues and PRs related to the i18n implementation.
labels
Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL
Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url
Fixes: nodejs#55214
srl295
added a commit
to srl295/node
that referenced
this issue
Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL
Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url
Fixes: nodejs#55214
srl295
added a commit
to srl295/node
that referenced
this issue
Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL
Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url
Fixes: nodejs#55214
buildIssues and PRs related to build files or the CI.icuIssues and PRs related to the ICU dependency.pythonPRs and issues that require attention from people who are familiar with Python.
Version
main
Platform
No response
Subsystem
build
What steps will reproduce the bug?
on windows git bash:
How often does it reproduce? Is there a required condition?
always
What is the expected behavior? Why is that the expected behavior?
successful configure
What do you see instead?
Additional information
broke in #47581
The text was updated successfully, but these errors were encountered: