Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: configure path refactoring broke ICU download on windows #55214

Open
srl295 opened this issue Oct 1, 2024 · 2 comments · May be fixed by #55215
Open

build: configure path refactoring broke ICU download on windows #55214

srl295 opened this issue Oct 1, 2024 · 2 comments · May be fixed by #55215
Assignees
Labels
build Issues and PRs related to build files or the CI. icu Issues and PRs related to the ICU dependency. python PRs and issues that require attention from people who are familiar with Python.

Comments

@srl295
Copy link
Member

srl295 commented Oct 1, 2024

Version

main

Platform

No response

Subsystem

build

What steps will reproduce the bug?

on windows git bash:

./configure --with-intl=full-icu --with-icu-source=https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1-src.tgz

How often does it reproduce? Is there a required condition?

always

What is the expected behavior? Why is that the expected behavior?

successful configure

What do you see instead?

Traceback (most recent call last):
  File "C:\Users\srl29\src\node\configure", line 28, in <module>
    import configure
  File "C:\Users\srl29\src\node\configure.py", line 2204, in <module>
    configure_intl(output)
  File "C:\Users\srl29\src\node\configure.py", line 1939, in configure_intl
    elif with_icu_source and Path(icu_full_path).resolve() == Path(with_icu_source).resolve():
  File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 1215, in resolve
    s = self._flavour.resolve(self, strict=strict)
  File "C:\Users\srl29\.pyenv\pyenv-win\versions\3.9.13\lib\pathlib.py", line 215, in resolve
    s = self._ext_to_normal(_getfinalpathname(s))
OSError: [WinError 123] El nombre de archivo, el nombre de directorio o la sintaxis de la etiqueta del volumen no son correctos: 'https:\\github.com\\unicode-org\\icu\\releases\\download\\release-76-rc\\icu4c-76_1-src.tgz'

Additional information

broke in #47581

@srl295 srl295 changed the title configure path refactoring broke ICU download on windows build: configure path refactoring broke ICU download on windows Oct 1, 2024
@srl295 srl295 self-assigned this Oct 1, 2024
@srl295 srl295 added build Issues and PRs related to build files or the CI. i18n-api Issues and PRs related to the i18n implementation. python PRs and issues that require attention from people who are familiar with Python. icu Issues and PRs related to the ICU dependency. and removed i18n-api Issues and PRs related to the i18n implementation. labels Oct 1, 2024
@srl295 srl295 linked a pull request Oct 1, 2024 that will close this issue
srl295 added a commit to srl295/node that referenced this issue Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL

Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url

Fixes: nodejs#55214
srl295 added a commit to srl295/node that referenced this issue Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL

Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url

Fixes: nodejs#55214
srl295 added a commit to srl295/node that referenced this issue Oct 1, 2024
- configure: don't assume ICU source is a path, it's sometimes a URL

Also:
- cleanup comments in configure.py and nodedownload.py
- feat: add a way to set ICU url on windows
- update docs for maintaining ICU per above url

Fixes: nodejs#55214
@Phakrada666

This comment has been minimized.

@Phakrada666
Copy link


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. icu Issues and PRs related to the ICU dependency. python PRs and issues that require attention from people who are familiar with Python.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants