build: unbreak windows build of ICU source URL

[srl295]

• configure: don't assume ICU source is a path, it's sometimes a URL

Also:

• cleanup comments in configure.py and nodedownload.py
• feat: add a way to set ICU url on windows: with-icu-source <url>
• update docs for maintaining ICU per above url

Fixes: #55214

[nodejs-github-bot]

Review requested:

• @nodejs/tsc

[StefanStojanovic]

Sorry, I lost track of this when assigned to it, and only got back to it now. Anyway, when I run the command from the linked issue on this branch:

./configure --with-intl=full-icu --with-icu-source=https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1-src.tgz --openssl-no-asm

I get the following error:

Traceback (most recent call last):
  File "E:\work\node\configure.py", line 2218, in <module>
    configure_intl(output)
  File "E:\work\node\configure.py", line 1981, in configure_intl
    nodedownload.unpack(icu_tarball, icu_tmp_path)
  File "E:\work\node\tools\configure.d\nodedownload.py", line 73, in unpack
    packedsuffix = packedfile.lower().split('.')[-1]  # .zip, .tgz etc
AttributeError: 'NoneType' object has no attribute 'lower'

From what I saw the packedfile provided to the unpack function is None. There is also a previous error that causes this in retrievefile:

 <https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1rc-src.tgz>
 ** IOError [Errno socket error] [ASN1] nested asn1 error (_ssl.c:4030)

[srl295]

will take a look, but if there was an ASN1 error it should just halt at that point (si it a temporary thing? a known outage on github? or maybe your environment is out of date SSL wise? if you use a garbage url i would imagine you could reproduce the same, from what you said.

…

On Wed, Nov 13, 2024 at 2:10 AM Stefan Stojanovic ***@***.***> wrote: Sorry, I lost track of this when assigned to it, and only got back to it now. Anyway, when I run the command from the linked issue on this branch: ./configure --with-intl=full-icu --with-icu-source= https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1-src.tgz --openssl-no-asm I get the following error: Traceback (most recent call last): File "E:\work\node\configure.py", line 2218, in <module> configure_intl(output) File "E:\work\node\configure.py", line 1981, in configure_intl nodedownload.unpack(icu_tarball, icu_tmp_path) File "E:\work\node\tools\configure.d\nodedownload.py", line 73, in unpack packedsuffix = packedfile.lower().split('.')[-1] # .zip, .tgz etc AttributeError: 'NoneType' object has no attribute 'lower' From what I saw the packedfile provided to the unpack function is None. There is also a previous error that causes this in retrievefile: <https://github.com/unicode-org/icu/releases/download/release-76-rc/icu4c-76_1rc-src.tgz> ** IOError [Errno socket error] [ASN1] nested asn1 error (_ssl.c:4030) — Reply to this email directly, view it on GitHub <#55215 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAGQZM275N7WUFQJ2RFXBQL2AMQQVAVCNFSM6AAAAABPF42NLOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINZTGA3DSNRRGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[StefanStojanovic]

or maybe your environment is out of date SSL wise?

Since this was the first time I have ever tried --with-icu-source it's most likely on my side