-
Notifications
You must be signed in to change notification settings - Fork 29.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
module resolution can fail with trailing slash #6214
Labels
Comments
targos
added
confirmed-bug
Issues with confirmed bugs.
module
Issues and PRs related to the module subsystem.
labels
Apr 15, 2016
4 tasks
targos
added a commit
to targos/node
that referenced
this issue
Apr 19, 2016
A recent optimization of module loading performance [1] forgot to check that extensions were set in a certain code path. [1] nodejs@ae18bbe Fixes: nodejs#6214
joelostrowski
pushed a commit
to joelostrowski/node
that referenced
this issue
Apr 25, 2016
A recent optimization of module loading performance [1] forgot to check that extensions were set in a certain code path. [1] nodejs@ae18bbe Fixes: nodejs#6214 PR-URL: nodejs#6215 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
I discovered this bug while trying to run pm2 with v6.0.0-rc.2.
To repro, create the following directory structure:
test/test.js:
test/node_modules/a/package.json:
Then execute
test/test.js
.Result with v5.10.1:
Result with v6.0.0-rc.2 / master:
I'm working on a fix right now.
The text was updated successfully, but these errors were encountered: