Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: isabsolute() windows examples use wrong path separator #6520

Closed
rtpHarry opened this issue May 2, 2016 · 1 comment
Closed

doc: isabsolute() windows examples use wrong path separator #6520

rtpHarry opened this issue May 2, 2016 · 1 comment
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.

Comments

@rtpHarry
Copy link

rtpHarry commented May 2, 2016

Doc incorrectly uses forward slashes for path examples on Windows platform:

https://nodejs.org/docs/latest/api/path.html#path_path_isabsolute_path

path.isAbsolute('//server')  // true
path.isAbsolute('C:/foo/..') // true

Should be

path.isAbsolute('\\server')  // true
path.isAbsolute('C:\foo\..') // true
@mscdex mscdex added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels May 2, 2016
@cjihrig
Copy link
Contributor

cjihrig commented May 2, 2016

It might be worth noting in the docs that forward slashes work too. The example could also add an absolute path using backslashes to go along with what is already there.

Care to make a PR?

jasnell added a commit to jasnell/node that referenced this issue Aug 30, 2016
Fishrock123 pushed a commit to Fishrock123/node that referenced this issue Sep 8, 2016
Fixes: nodejs#6520
PR-URL: nodejs#8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Fishrock123 pushed a commit that referenced this issue Sep 9, 2016
Fixes: #6520
PR-URL: #8291
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@sam-github sam-github added doc Issues and PRs related to the documentations. and removed doc Issues and PRs related to the documentations. labels Dec 1, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

No branches or pull requests

5 participants