doc: clarify that path.isAbsolute on windows accepts / and \ #8291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasnell
added
doc
| ``` | ||
|
|
||
| *Note*: On Windows, the `path.isAbsolute()` method will accept both forward | ||
| slash (`/`) and backwards slash (`\`) characters as path delimiters. |
There was a problem hiding this comment.
s/backwards/backward/ ? I'm not a native speaker but "backward slash" has more occurrences on Google.
There was a problem hiding this comment.
btw, this sounds a bit overly specific, although I might be wrong… is there anything in the Node API where / isn’t accepted on Windows?
There was a problem hiding this comment.
@addaleax ... good point...
jasnell
force-pushed
the
doc-path-absolute-slash
branch
from
bf100e1 to
08b12f2
Compare
|
LGTM. |
|
LGTM |
|
Landed in 86067f0. Thanks! |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Fixes: nodejs#6520 PR-URL: nodejs#8291 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
doc
Description of change
Clarify that path.isAbsolute() on windows accepts / and \ as path delims
Fixes: #6520