-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url.resolveObject: conflicting values of host and port #8213
Labels
url
Issues and PRs related to the legacy built-in url module.
Comments
imyller
added a commit
to imyller/node
that referenced
this issue
Aug 21, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
3 tasks
I've opened PR with a fix and test case. |
imyller
added a commit
to imyller/node
that referenced
this issue
Sep 30, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 PR-URL: nodejs#8214 Reviewed-By: James M Snell <jasnell@gmail.com>
imyller
added a commit
to imyller/node
that referenced
this issue
Sep 30, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 PR-URL: nodejs#8214 Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
url.resolveObject
generates inconsistentport
andhost
value when modifying port:Where
port
andhost
unexpectedly contain conflicting information:The text was updated successfully, but these errors were encountered: