-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
url: fix inconsistent port in url.resolveObject #8214
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
nodejs-github-bot
added
the
url
Issues and PRs related to the legacy built-in url module.
label
Aug 21, 2016
CI: https://ci.nodejs.org/job/node-test-pull-request/3792/ |
New CI: https://ci.nodejs.org/job/node-test-pull-request/3806/ |
Landed in 286d44e . Thank you! |
this does not land cleanly on v4.x @imyller would you be willing to manually backport against v4.x-staging feel free to let me know if you have any questions |
imyller
added a commit
to imyller/node
that referenced
this pull request
Sep 30, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 PR-URL: nodejs#8214 Reviewed-By: James M Snell <jasnell@gmail.com>
imyller
added a commit
to imyller/node
that referenced
this pull request
Sep 30, 2016
This commit fixes bug where url.resolveObject returns conflicting host and port values. Fixes: nodejs#8213 PR-URL: nodejs#8214 Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test
(UNIX), orvcbuild test nosign
(Windows) passesAffected core subsystem(s)
url
Description of change
This commit fixes a bug where url.resolveObject returns conflicting host and port values.
Fixes: #8213