Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V4.6.2 proposal #9298

Closed
wants to merge 221 commits into from
Closed

V4.6.2 proposal #9298

wants to merge 221 commits into from

Conversation

MylesBorins
Copy link
Contributor

@MylesBorins MylesBorins commented Oct 26, 2016

2016-11-08, Version 4.6.2 'Argon' (LTS), @thealphanerd

This LTS release comes with 219 commits. This includes 80 commits that are docs related, 58 commits that are test related, 20 commits that are build / tool related, and 9 commits that are updates to dependencies.

Notable Changes

  • build: It is now possible to build the documentation from the release tarball (Anna Henningsen) #8413
  • buffer: Buffer.alloc() will no longer incorrectly return a zero filled buffer when an encoding is passed (Teddy Katz) #9238
  • deps: upgrade npm in LTS to 2.15.11 (Kat Marchán) #8928
  • repl: Enable tab completion for global properties (Lance Ball) #7369
  • url: url.format() will now encode all # in search (Ilkka Myller) #8072

Commits

  • [06a1c9bf80] - assert: remove code that is never reached (Rich Trott) #8132
  • [861e584d46] - async_wrap: add a missing case to test-async-wrap-throw-no-init (yorkie) #8198
  • [a3d08025fa] - benchmark: add benches for fs.stat & fs.statSync (Anna Henningsen) #8338
  • [408a585261] - buffer: fix fill with encoding in Buffer.alloc() (Teddy Katz) #9238
  • [17c4187949] - buffer: optimize hex_decode (Christopher Jeffrey) #7602
  • [50cfea0081] - build: run npm install for doc builds in tarball (Anna Henningsen) #8413
  • [c4be179064] - build: add missing files to zip and 7z packages (Richard Lau) #8069
  • [41e27f6a6a] - build: don't link against liblog on host system (Ben Noordhuis) #7762
  • [7766997f7e] - build: add conflict marker check during CI lint (Brian White) #7625
  • [2a66ddbcbb] - build: re-add --ninja option to configure (Ehsan Akhgari) #6780
  • [950cc1df83] - build: adding config.gypi dep to addons/.buildstamp (Daniel Bevenius) #7893
  • [e64063c344] - build: don't require processing docs for nightlies (Johan Bergström) #8325
  • [00ea7388cb] - build: fix dependencies on AIX (Michael Dawson) #8285
  • [8dfab3ad68] - build: fix dependencies on AIX (Michael Dawson) #8272
  • [1b5f35f1be] - build: turn on thin static archives (Ben Noordhuis) #7957
  • [c41efe4d68] - build: add node_module_version to config.gypi (Marcin Cieślak) #8171
  • [f556b43e3e] - build: add --enable-d8 configure option (Ben Noordhuis) #7538
  • [612dfeb647] - child_process: Check stderr before accessing it (Robert Chiras) #6877
  • [5ed5142158] - child_process: workaround fd passing issue on OS X (Santiago Gimeno) #7572
  • [227db0ab21] - cluster: remove bind() and self (cjihrig) #7710
  • [3003131e9a] - configure: reword help for --without-npm (BlackYoup) #7471
  • [2b933339d0] - debugger: use arrow function for lexical this (Guy Fraser) #7415
  • [52cba4147d] - deps: backport 2bcbe2f from V8 upstream (ofrobots) #7814
  • [2b01bc8e55] - deps: backport a76d133 from v8 upstream (Matt Loring) #7689
  • [e1f12fb358] - deps: cherry-pick b93c80a from v8 upstream (Matt Loring) #7689
  • [2d07fd71ee] - deps: backport e093a04, 09db540 from upstream V8 (Ali Ijaz Sheikh) #7689
  • [4369055878] - deps: cherry-pick 1f53e42 from v8 upstream (Ben Noordhuis) #7612
  • [05d40d9573] - deps: upgrade npm in LTS to 2.15.11 (Kat Marchán) #8928
  • [36b3ff0cfc] - deps: float gyp patch for long filenames (Anna Henningsen) #7963
  • [9ddc615d0e] - deps: no /safeseh for ml64.exe (Fedor Indutny) #7759
  • [ea36c61eda] - deps: MASM.UseSafeExceptionHandlers for OpenSSL (Fedor Indutny) #7427
  • [0b87b1a095] - dns: tweak regex for IPv6 addresses (Luigi Pinca) #8665
  • [0e2aba96bc] - doc: make sure links are correctly passed to marked (Timothy Gu) #8494
  • [3a43b0d981] - doc: correct metadata of Buffer.from (Anna Henningsen) #9167
  • [880ca99847] - doc: fix broken link in dgram doc (Brian White) #8365
  • [65ca2af471] - doc: add missing semicolon (Ravindra barthwal) #7915
  • [da3b938be3] - doc: add added: information for globals (Luigi Pinca) #8901
  • [b4ba4af525] - doc: add CTC meeting minutes 2016-09-07 (Josh Gavant) #8499
  • [4b49b0e30c] - doc: add CTC meeting minutes 2016-09-14 (Josh Gavant) #8726
  • [88b0067229] - doc: add CTC meeting minutes 2016-09-21 (Josh Gavant) #8727
  • [f7c4e9489f] - doc: update npm LICENSE using license-builder.sh (Kat Marchán) #8928
  • [6effc4aadc] - doc: add added: information for crypto (Luigi Pinca) #8281
  • [d750fc6336] - doc: add added: information for dgram (Luigi Pinca) #8196
  • [b92e3fc72e] - doc: add added: information for util (Luigi Pinca) #8206
  • [578bf511f9] - doc: add added: information for events (Luigi Pinca) #7822
  • [6ef58e7211] - doc: add gibfahn to collaborators (Gibson Fahnestock) #8533
  • [5ff1fc7d86] - doc: add imyller to collaborators (Ilkka Myller) #8530
  • [88bb65dd74] - doc: add not-an-aardvark to collaborators (not-an-aardvark) #8525
  • [5bec1eb0d4] - doc: update onboarding PR landing info (Rich Trott) #8479
  • [ecd2b52982] - doc: encourage 2FA before onboarding (Rich Trott) #8776
  • [2adbd53837] - doc: add commit formats for release blog posts (fen) #8631
  • [764502bb37] - doc: add CTC meeting minutes 2016-08-24 (Josh Gavant) #8423
  • [3037a9da08] - doc: add eugeneo to collaborators (Eugene Ostroukhov) #8696
  • [0fd1d8dfd7] - doc: add ak239 to collaborators (Aleksey Kozyatinskiy) #8676
  • [64c4bb30fe] - doc: add link to help repo in README (Rich Trott) #8570
  • [d123fc1307] - doc: update exercise portion of onboarding doc (Rich Trott) #8559
  • [c6b622f6b3] - doc: add CTC meeting minutes 2016-08-31 (Josh Gavant) #8424
  • [055d39c724] - doc: add CI help/support info to onboarding doc (Rich Trott) #8407
  • [a7e6fc08d8] - doc: add 2016-08-17 CTC meeting minutes (Josh Gavant) #8245
  • [ca63c127c7] - doc: add 2016-08-10 CTC meeting minutes (Josh Gavant) #8229
  • [3f2e3dfb32] - doc: update CI content in onboarding doc (Rich Trott) #8374
  • [9e1325c42e] - doc: update authors list (James M Snell) #8346
  • [c529bf5521] - doc: add return type of clientRequest.setTimeout (Mike Ralphson) #8356
  • [c094b2a51c] - doc: update targos email in readme per request (James M Snell) #8389
  • [5c417ee25b] - doc: update landing pr info in onboarding doc (Rich Trott) #8344
  • [763fa85ccf] - doc: bad/better examples for fs.access() and fs.exists() (Dan Fabulich) #7832
  • [0c933e5bab] - doc: adding danbev to collaborators (Daniel Bevenius) #8359
  • [e069dc45b0] - doc: add lpinca to collaborators (Luigi Pinca) #8331
  • [e5f4367da5] - doc: readline write() is processed as input (James M Snell) #8295
  • [b3617fcc7d] - doc: add added: information for modules (Luigi Pinca) #8250
  • [0b605636c5] - doc: add Myles Borins to the CTC (Rod Vagg) #8260
  • [a8a8f0a6f1] - doc: add added: information for cluster (Anna Henningsen) #7640
  • [2a2971b26e] - doc: use blockquotes for Stability: markers (Anna Henningsen) #7757
  • [3a3fde69c7] - doc: fix variable scoping bug in server example code (lazlojuly) #8124
  • [f1e14e4227] - doc: fix cluster message event docs (Zach Bjornson) #8017
  • [9b29cfc3a6] - doc: Clean up roff source in manpage (Alhadis) #7819
  • [364af49e0f] - doc: add CTC meeting minutes 2016-06-22 (Josh Gavant) #7390
  • [9892a5ddc3] - doc: remove extra spaces and concats in examples (Joe Esposito) #7885
  • [3ad74089f5] - doc: correct sample output of buf.compare (Hargobind S. Khalsa) #7777
  • [26e695c46c] - doc: remove "feature branch" jargon (Rich Trott) #8194
  • [d676467208] - doc: remove outdated LTS info from ROADMAP.md (Rich Trott) #8161
  • [b3545e148d] - doc: update release announce instruction to tweet (Tracy Hinds) #8126
  • [2032bba65f] - doc: add @joshgav to collaborators (Josh Gavant) #8146
  • [727c24f3a2] - doc: update Reviewing section of onboarding doc (Rich Trott)
  • [04515b891a] - doc: move orangemocha to collaborators list (Rich Trott) #8062
  • [d3344aa216] - doc: Add fhinkel to collaborators (Franziska Hinkelmann) #8052
  • [532bbde4bf] - doc: add CTC meeting minutes 2016-08-03 (Josh Gavant) #7980
  • [98fe74fbc8] - doc: fix a markdown error in CTC meeting minutes (Сковорода Никита Андреевич) #7729
  • [e74daadeb6] - doc: clarify collaborators & ctc members relationships (yorkie) #7996
  • [6bfdc92860] - doc: clarify "Reviewed-By" iff "LGTM" (Bryan English) #7183
  • [94a82cd0a7] - doc: add CTC meeting minutes 2016-07-13 (Josh Gavant) #7968
  • [012ccf010e] - doc: add CTC meeting minutes 2016-07-20 (Josh Gavant) #7970
  • [08111e84b1] - doc: use consistent markdown in README (Rich Trott) #7971
  • [009df788de] - doc: use git-secure-tag for release tags (Fedor Indutny) #7603
  • [abefdca5ae] - doc: piscisaureus has stepped-down from the CTC (James M Snell) #7969
  • [9700660d2b] - doc: add @addaleax to the CTC (Anna Henningsen) #7966
  • [f255180853] - doc: add CTC meeting minutes 2016-07-06 (Josh Gavant) #7570
  • [b60473fac7] - doc: add CTC meeting minutes 2016-06-29 (Josh Gavant) #7571
  • [ac40b2a9b6] - doc: add CTC meeting minutes 2016-07-27 (William Kapke) #7900
  • [bbbbb19658] - doc: add information about CTC quorum rules (Rich Trott) #7813
  • [d759d4e0a6] - doc: remove platform assumption from CONTRIBUTING (Bethany N Griggs) #7783
  • [b01854dd9d] - doc: add princejwesley to collaborators (Prince J Wesley) #7877
  • [26f5168c02] - doc: clarify that the node.js irc channel is not under tsc oversight (James M Snell) #7810
  • [506e367062] - doc: update readme with andrasq as a collaborator (Andras) #7801
  • [590c52a309] - doc: update CTC governance information (Rich Trott) #7719
  • [fdff642e0b] - doc: fix util.deprecate() example (Evan Lucas) #7674
  • [8fec02ffb8] - doc: delete non-existing zlib constants (Franziska Hinkelmann) #7520
  • [d6c2e383a2] - doc: minor updates to onboarding doc (Rich Trott) #8060
  • [e46d1e026e] - doc: add POST_STATUS_TO_PR info to onboarding doc (Rich Trott) #8059
  • [4f3107190d] - doc: add added: info for dgram.*Membership() (Rich Trott) #6753
  • [0e52861629] - doc: grammar fixes to event loop guide (Ryan Lewis) #7479
  • [29139bff65] - doc: improve server.listen() random port (Phillip Johnsen) #8025
  • [b680eb99ad] - doctool: improve the title of pages in doc (yorkie)
  • [3d6f107a2f] - fs: fix handling of uv_stat_t fields (Anna Henningsen) #8515
  • [2e29b76666] - intl: Don't crash if v8BreakIterator not available (Steven R. Loomis) #4253
  • [f6e332da2d] - lib: implement consistent brace style (Rich Trott) #8348
  • [9d9bcd7c55] - meta: clarify process for breaking changes (Rich Trott) #7955
  • [6d49f22e35] - meta: include a minimal CTC removal policy (Rich Trott) #7720
  • [7faf6dc0da] - meta: provide example activities (Rich Trott) #7744
  • [fe48415c60] - net: add length check when normalizing args (Brian White) #8112
  • [3906206ecc] - net: remove unnecessary variables (Brian White) #8112
  • [9f1b790f79] - net: make holding the buffer in memory more robust (Anna Henningsen) #8252
  • [b630be2309] - net: export isIPv4, isIPv6 directly from cares (Sakthipriyan Vairamani) #7481
  • [c235708bef] - readline: keypress trigger for escape character (Prince J Wesley) #7382
  • [8198dbc5a4] - repl: Enable tab completion for global properties (Lance Ball) #7369
  • [12300626d7] - src: no abort from getter if object isn't wrapped (Trevor Norris) #6184
  • [166a9b85d9] - src: always clear wrap before persistent Reset() (Trevor Norris) #6184
  • [b3149cee8c] - src: inherit first from AsyncWrap (Trevor Norris) #6184
  • [8b93fddd1b] - src: disable stdio buffering (Ben Noordhuis) #7610
  • [72be320962] - src: suppress coverity message (cjihrig) #7587
  • [6ba3ad5d34] - src: guard against overflow in ParseArrayIndex() (Ben Noordhuis) #7497
  • [e1f961d050] - src: move ParseArrayIndex() to src/node_buffer.cc (Ben Noordhuis) #7497
  • [57921ebec5] - src: remove unnecessary HandleScopes (Ben Noordhuis) #7711
  • [6838ad5f8e] - src: fix handle leak in UDPWrap::Instantiate() (Ben Noordhuis) #7711
  • [dadcf6b263] - src: fix handle leak in BuildStatsObject() (Ben Noordhuis) #7711
  • [7aa268922a] - src: fix handle leak in Buffer::New() (Ben Noordhuis) #7711
  • [606deecd16] - src: don't include a null character in the WriteConsoleW call (Nikolai Vavilov) #7764
  • [a5b6c2cdd7] - src: use RAII for mutexes and condition variables (Ben Noordhuis) #7334
  • [19d6f06058] - stream_base: always use Base template class (Trevor Norris) #6184
  • [d5f03db819] - test: fix test-cluster-dgram-1 flakiness (Santiago Gimeno)
  • [a83bbaa5a3] - test: refactor test-tick-processor (Rich Trott) #8180
  • [1c81c078c2] - test: add assert.notDeepStrictEqual() tests (Rich Trott) #8177
  • [57c98f18a9] - test: favor === over == in crypto tests (Rich Trott) #8176
  • [11f761ab1a] - test: refactor pummel/test-dtrace-jsstack (Rich Trott) #8175
  • [2997b79fcc] - test: favor strict equality in test-exec (Rich Trott) #8173
  • [558f7d999c] - test: add assert.notDeepEqual() tests (Rich Trott) #8156
  • [49c488625d] - test: add missing assert.deepEqual() test case (Rich Trott) #8152
  • [eec078cd66] - test: favor strict equality in http tests (Rich Trott) #8151
  • [e3669f8c21] - test: favor strict equality in pummel net tests (Rich Trott) #8135
  • [ac83d199fb] - test: confirm that assert truncates long values (Rich Trott) #8134
  • [9c826beef7] - test: favor === over == in test-timers.js (Rich Trott) #8131
  • [af02d2a642] - test: favor strict equality check (Rich Trott) #8130
  • [30034048b0] - test: fix assertion in test-watch-file.js (Rich Trott) #8129
  • [b063dc90b1] - test: use strict equality in regression test (Rich Trott) #8098
  • [dc7bc2e679] - test: add test for debug usage message (Rich Trott) #8061
  • [ce2cfbdc3a] - test: console constructor missing new keyword (Rich Trott) #8003
  • [69f4edd368] - test: speed up test-net-reconnect-error (Rich Trott) #7886
  • [50acf72d80] - test: increase RAM requirement for intensive tests (Rich Trott) #7772
  • [924ea0a2bd] - test: fix flaky test-http-server-consumed-timeout (Rich Trott) #7717
  • [97a3d89c80] - test: improve coverage of the util module (Michaël Zasso) #8633
  • [52bb37734b] - test: mark test-child-process-fork-dgram as flaky (Michael Dawson) #8274
  • [97c68ddaad] - test: improve error message in test-tick-processor (Rich Trott) #7693
  • [cd9e8e0361] - test: fix old tty tests (Jeremiah Senkpiel) #7613
  • [22990d8851] - test: move parallel/test-tty-* to pseudo-tty/ (Jeremiah Senkpiel) #7613
  • [afee32fed5] - test: fix fs-watch-recursive flakiness on OS X (Santiago Gimeno) #4629
  • [c543f4a879] - test: stream writable ended state (Italo A. Casas) #8778
  • [f46a04cc6d] - test: add tests for add/remove header after sent (Niklas Ingholt) #8682
  • [e79351c3ac] - test: improve test-https-agent.js (Dan.Williams) #8517
  • [9ffb2f3c0d] - test: add coverage for client._addHandle() (Rich Trott) #8518
  • [8da2dcb70a] - test: refector parallel/test-http.js (Junshu Okamoto) #8471
  • [69404ec473] - test: fix flaky test-force-repl (Rich Trott) #8484
  • [5a07bb62ea] - test: swapped == and equal to === and strictEqual (Christopher Dunavan) #8472
  • [ad1230e731] - test: skip pseudo-tty/no_dropped_stdio test (Michael Dawson) #8470
  • [6d03170751] - test: clean up net server try ports test (Thomas Hunter II) #8458
  • [775c84ec38] - test: add test-debug-protocol-execute (Rich Trott) #8454
  • [0d1082426a] - test: mark pseudo-tty/no_dropped_stdio as flaky (Michael Dawson) #8385
  • [c034c861bb] - test: test non-buffer/string with zlib (Rich Trott) #8350
  • [bb8690433c] - test: fix ::1 error in test-dns-ipv6 (Gibson Fahnestock) #8254
  • [2f458ea663] - test: add test for zlib.create*Raw() (Rich Trott) #8306
  • [a368ea673c] - test: refactor test-debug-signal-cluster (Rich Trott) #8289
  • [a48469f098] - test: add check in test-signal-handler (Rich Trott) #8248
  • [cadb2612c6] - test: add test for attempted multiple IPC channels (cjihrig) #8159
  • [21c1b8467e] - test: decrease inconsistency in the common.js (Vse Mozhet Byt) #7758
  • [d40873ddcd] - test: ensure stream preprocessing order (Vse Mozhet Byt) #7741
  • [0e1f098b09] - test: avoid usage of mixed IPV6 addresses (Gireesh Punathil) #7702
  • [741373cb49] - test: clean up test-buffer-badhex (Jeremiah Senkpiel) #7773
  • [58f3fa17eb] - test: s/assert.fail/common.fail as appropriate (cjihrig) #7735
  • [b0e2f9a37a] - test: add common.rootDir (cjihrig) #7685
  • [c94f3a5784] - test: handle IPv6 localhost issues within tests (Rich Trott) #7766
  • [b64828d8df] - test: accept expected AIX result test-stdio-closed (Rich Trott) #8755
  • [3dbcc3d2d9] - test: fix flaky test-*-connect-address-family (Rich Trott) #7605
  • [733233d3ea] - test: add uncaught exception test for debugger (Rich Trott) #8087
  • [c9af24d2a7] - test: add test for assert.notStrictEqual() (Rich Trott) #8091
  • [337d2dd381] - test: implement consistent braces (Rich Trott) #8348
  • [77df523264] - test: exclude tests for AIX (Michael Dawson) #8076
  • [50ae37e350] - test: add --repeat option to tools/test.py (Michael Dawson) #6700
  • [ea72e9f143] - test,doc: clarify buf.indexOf(num) input range (Anna Henningsen) #7611
  • [c841b5a6b9] - tls: copy the Buffer object before using (Sakthipriyan Vairamani) #8055
  • [6076293d6c] - tls_wrap: do not abort on new TLSWrap() (Trevor Norris) #6184
  • [6e5906c7f1] - tools: use long format for gpg fingerprint (Myles Borins) #9258
  • [7409c332b8] - tools: check tag is on github before release (Rod Vagg) #9142
  • [b632badda2] - tools: make detached SHASUM .sig file for releases (Rod Vagg) #9071
  • [5867ffe27e] - tools: explicitly set digest algo for SHASUM to 256 (Rod Vagg) #9071
  • [bdfa3b388b] - tools: favor === over == in license2rtf.js (Rich Trott)
  • [d7e3edc744] - tools: add remark-lint configuration in .remarkrc (Сковорода Никита Андреевич) #7729
  • [afbfbc04c9] - tools: add .vscode folder to .gitignore (Josh Gavant) #7967
  • [3f4a5fe61e] - tools: increase lint coverage (Rich Trott) #7647
  • [d1a50b3ed2] - tools: enforce JS brace style with linting (Rich Trott) #8348
  • [76b8d81f38] - tools,test: show signal code when test crashes (Santiago Gimeno) #7859
  • [389a6d2cc2] - url: fix off-by-one error in loop handling dots (Luigi Pinca) #8420
  • [be9d9bd7c3] - url: fix inconsistent port in url.resolveObject (Ilkka Myller) #8214
  • [96cfa926bd] - url: url.format() encodes all # in search (Ilkka Myller) #8072
  • [f7796f23e3] - util: inspect boxed symbols like other primitives (Anna Henningsen) #7641
  • [410e083d7c] - win,build: forward release_urlbase to configure (João Reis) #8430
  • [26e73740e9] - win,build: exit when addons fail to build (João Reis) #8412
  • [30e751f38b] - win,build: skip finding VS when not needed (João Reis) #8412
  • [b3090f8e64] - win,build: fail on invalid option in vcbuild (João Reis) #8412
  • [1b5213bfc3] - win,msi: fix inclusion of translations (João Reis) #7798
  • [e8be413d0d] - win,msi: add zh-CN translations for the installer (Minqi Pan) #2569
  • [99f85b8340] - win,msi: Added Italian translation (Matteo Collina) #4647

bnoordhuis and others added 30 commits October 26, 2016 14:08
Add an option to the configure script for building d8.  Useful for
testing V8 standalone.

PR-URL: #7538
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
Manual backport from master to 4.x stream, original
commit message follows.

I often want to run a test many times to see if a failure
can be recreated and I believe this is a common
use case.  We even have this job in the CI
https://ci.nodejs.org/job/node-stress-single-test/configure
but often you want to run it on a specific machine.

This patch adds the --repeat option so that
you can repeat the selected set of tests a
number of times. Given existing options
in test.py this will allow you to run
one or more tests for the number of
repeats specified. For example:

tools/test.py -j8 --repeat 1000 parallel/test-process-exec-argv

runs the test-process-exec-argv test 1000 times,
running 8 copies in parallel

tools/test.py --repeat 2

would run the entire test suite twice.

PR-URL: #6700
Reviewed-By: Ben Noorhduis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
Reviewed-By: thefourtheye - Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: joaocgreis - João Reis <reis@janeasystems.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Enable targetting of a different node version than
the currently running one when building binary modules.

Based on 410296c37

PR-URL: #8171
Ref: #8027
Ref: #7808
Ref: nodejs/node-gyp#855
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Minor rewording related to making a server listen to a random port,
and added how to retrieve which port was randomly chosen by the OS.

Also changed documented `server.listen()` signature as it does in fact
not require `port` to be provided.

PR-URL: #8025
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

PR-URL: #8076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7479
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
The function objects encapsulating `isIPv4` and `isIPv6` are not
necessary. They can be directly exposed from `cares`.

PR-URL: #7481
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Inspect boxed symbol objects in the same way other boxed primitives
are inspected.

Fixes: #7639
PR-URL: #7641
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Use `msvs_settings.MASM.UseSafeExceptionHandlers` when building OpenSSL
assembly code on Windows. This option appends `/safeseh` to the list of
assembler flags when building `.asm` files on Windows.

Having this option in place, separate rules in `masm_compile.gypi` are
no longer needed.

Fix: #7426
PR-URL: #7427
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Bert Belder <bertbelder@gmail.com>
`ml64.exe` doesn't support `/safeseh` option. Do not attempt to use it
if `target_arch=="x64"`.

See: https://msdn.microsoft.com/en-us/library/s0ksfwcf.aspx
PR-URL: #7759
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Robert Jefe Lindstaedt <robert.lindstaedt@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Since I was doing the necessary git archaeology anyway, I took the time
to add YAML information to the docs about when `addMembership()` and
`dropMembership()` first appeared in their current forms.

PR-URL: #6753
Ref: #6578
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This change is in preparation for lint-enforced brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
This change is in preparation for lint enforcement of brace style.

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Enable `brace-style` in ESLint.

Ref: #7094 (comment)

PR-URL: #8348
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Set the `req.buffer` property, which serves as a way of keeping
a `Buffer` alive that is being written to a stream, on the C++
side instead of the JS side.

This closes a hole where buffers that were temporarily created
in order to write strings with uncommon encodings (e.g. `hex`)
were passed to the native side without being set as `req.buffer`.

Fixes: #8251
PR-URL: #8252
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
We will be introducing many more critical sections in the upcoming
multi-isolate changes, so let's make manual synchronization a thing
of the past.

PR-URL: #7334
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Extend linting to tools/license2rtf.js and any other JS that gets added
to the `tools` directory by default.

This incidentally simplifies lint invocation.

Ref: #8349
PR-URL: #7647
Reviewed-By: Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
`POST_STATUS_TO_PR` previously did not work.

Now it works.

Update the onboarding documentation accordingly.

PR-URL: #8059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Some constants in the zlib docs are not in the actual code:

zlib.Z_BINARY
zlib.Z_TEXT
zlib.Z_ASCII
zlib.Z_UNKNOWN

Also handled in #7203, but marked as
semver-major, so will not land in v6.x.

Fixes: #7204
PR-URL: #7520
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
The arguments object is not created for arrow functions so the example
was incorrect.

PR-URL: #7674
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Update some outdated material. Provide some minor fixes. Wrap to 80
characters.

PR-URL: #7719
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ali Ijaz Sheikh <ofrobots@google.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #7801
There has been some question about whether the #node.js irc channel
falls under the TSC oversight or not.

See: #7746

This clarifies that the #node.js irc channel is a community provided
resource that is not currently directly under the oversight of the
TSC/CTC.

PR-URL: #7810
Reviewed-By: Bryan Hughes <bryan@nebri.us>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #7877
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
CTC quorum rules were not in writing. There was an informal
understanding between CTC members. Document the rules to avoid
differences in interpretation.

PR-URL: #7813
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Provide example activities to better distinguish Collaborator activities
from CTC member activities.

PR-URL: #7744
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
PR-URL: #7900
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Add language identifying a request for voluntary resignation as the
typical mechanism for addressing inactive CTC members.

PR-URL: #7720
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Shigeki Ohtsu <ohtsu@iij.ad.jp>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Julien Gilli <jgilli@nodejs.org>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins removed build Issues and PRs related to build files or the CI. npm Issues and PRs related to the npm client dependency or the npm registry. labels Oct 26, 2016
MylesBorins added a commit that referenced this pull request Oct 26, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer will no longer incorrectly return a zero filled buffer when
    an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298
@MylesBorins
Copy link
Contributor Author

MylesBorins commented Oct 26, 2016

@MylesBorins
Copy link
Contributor Author

With this being a semver patch release I would like to do 2 weeks of RC followed by a release on november 8. If anyone has concerns about this please let me know.

/cc @nodejs/ctc @nodejs/lts

## Notable Changes

* **build**: It is now possible to build the documentation from the release tarball (Anna Henningsen) [#8413](https://github.com/nodejs/node/pull/8413)
* **buffer**: Buffer will no longer incorrectly return a zero filled buffer when an encoding is passed (Teddy Katz) [#9238](https://github.com/nodejs/node/pull/9238)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this supposed to say Buffer.alloc instead of just Buffer?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

MylesBorins added a commit that referenced this pull request Oct 26, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298
@MylesBorins
Copy link
Contributor Author

one more citgm for posterity: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/432/
CI failures were all infra related

@jasnell
Copy link
Member

jasnell commented Nov 3, 2016

LGTM!

Git has been using my Long format fingerprint in the tagging messages,
this has been causing the release script to fail on my keys.

It would also be wise to be using the long format on keys based on some
attacks that hack been found in the wild around short keys.

PR-URL: #9258
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298
@MylesBorins
Copy link
Contributor Author

@nodejs/collaborators @nodejs/lts @nodejs/ctc

This release is planned to go out tomorrow. Please give one more look at the changelog and make sure that nothing seems out of place

@mcollina
Copy link
Member

mcollina commented Nov 7, 2016

LGTM

1 similar comment
@mhdawson
Copy link
Member

mhdawson commented Nov 8, 2016

LGTM

@MylesBorins
Copy link
Contributor Author

Failures of citgm included:

  • eslint on fedora ~ due to phantomjs not having releases for platform
  • async on ubuntu ~ due to flaky fails. Individual runs had mixed results

@MylesBorins MylesBorins closed this Nov 8, 2016
MylesBorins pushed a commit that referenced this pull request Nov 8, 2016
MylesBorins added a commit that referenced this pull request Nov 8, 2016
This LTS release comes with 219 commits. This includes 80 commits that
are docs related, 58 commits that are test related, 20 commits that
are build / tool related, and 9 commits that are updates to
dependencies.

Notable Changes

* build:
  - It is now possible to build the documentation from the release
    tarball (Anna Henningsen)
    #8413
* buffer:
  - Buffer.alloc() will no longer incorrectly return a zero filled
    buffer when an encoding is passed (Teddy Katz)
    #9238
* deps:
  - upgrade npm in LTS to 2.15.11 (Kat Marchán)
    #8928
* repl:
  - Enable tab completion for global properties (Lance Ball)
    #7369
* url:
  - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
    #8072

PR-URL: #9298
imyller added a commit to imyller/meta-nodejs that referenced this pull request Nov 11, 2016
    This LTS release comes with 219 commits. This includes 80 commits that
    are docs related, 58 commits that are test related, 20 commits that
    are build / tool related, and 9 commits that are updates to
    dependencies.

    Notable Changes

    * build:
      - It is now possible to build the documentation from the release
        tarball (Anna Henningsen)
        nodejs/node#8413
    * buffer:
      - Buffer.alloc() will no longer incorrectly return a zero filled
        buffer when an encoding is passed (Teddy Katz)
        nodejs/node#9238
    * deps:
      - upgrade npm in LTS to 2.15.11 (Kat Marchan)
        nodejs/node#8928
    * repl:
      - Enable tab completion for global properties (Lance Ball)
        nodejs/node#7369
    * url:
      - `url.format()` will now encode all `#` in `search` (Ilkka Myller)
        nodejs/node#8072

    PR-URL: nodejs/node#9298

Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>
@MylesBorins MylesBorins deleted the v4.6.2-proposal branch December 15, 2016 18:44
ofrobots added a commit to ofrobots/node that referenced this pull request Jan 11, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: nodejs#7612
Ref: nodejs#9298
MylesBorins pushed a commit that referenced this pull request Jan 12, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
The cherry-pick of #7612 to v4.x (4369055) added in #9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: #7612
Ref: #9298

PR-URL: #10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
gibfahn pushed a commit to ibmruntimes/node that referenced this pull request Feb 22, 2017
The cherry-pick of nodejs#7612 to v4.x (4369055) added in nodejs#9298 wasn't quite
correct as it depends on a runtime function %SymbolDescriptiveString
that doesn't exist on v4.x. We can use %SymbolDescription instead.

Ref: nodejs/node#7612
Ref: nodejs/node#9298

PR-URL: nodejs/node#10732
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Fedor Indutny <fedor.indutny@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.