Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

win,msi: Added Italian translation #4647

Closed
wants to merge 1 commit into from
Closed

win,msi: Added Italian translation #4647

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

I have added the Italian translation for the windows installer.
Is there something else to add?

Also, I do not have a dev env to build this bundle, so I did not test it.

cc @nodejs/platform-windows @nodejs/nodejs-it @piccoloaiutante

orangemocha
orangemocha reviewed Jan 12, 2016
View reviewed changes
tools/msvs/msi/i18n/it-it.wxl
<String Id="EnvironmentPathNpmModules_Description">Aggiunge i moduli installati globalmente da npm alla variabile di ambiente PATH. Questa opzione avrà effetto solo per l'utente corrente, gli altri utenti dovranno aggiornare la loro variabile PATH manualmente.</String>

<!-- References like [ProductName] are not resolved for Property tags -->
<String Id="WIXUI_EXITDIALOGOPTIONALTEXT">Node.js è stato installto correttamente.</String>
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

installto => installato

@piccoloaiutante
Copy link
Member

@mcollina i could try to build it in the next two three days. What's the deadline for this task?

@mscdex mscdex added windows Issues and PRs related to the Windows platform. install Issues and PRs related to the installers. labels Jan 12, 2016
@mcollina
Copy link
Member Author

Thanks @piccoloaiutante @orangemocha for reviewing, all your changes are in.

@piccoloaiutante it would be great if you could attempt a build, but I'll leave that decision to the @nodejs/platform-windows team on how to test this (I have no idea, but I would love to see this happening).

@piccoloaiutante
Copy link
Member

@mcollina ok i'm downloading VS2013 to build six project because i'm currently unable to build it with my vs2015.
I hope to get it build by tomorrow :-)

@joaocgreis
Copy link
Member

@mcollina this also needs to be added commented in nodemsi.wixproj, similar to https://github.com/nodejs/node/pull/2569/files .

@piccoloaiutante note that to build with VS2015 you need WiX 3.10. If you find issues with it, please report.

@piccoloaiutante
Copy link
Member

@joaocgreis i had issue with my vs2015 professional update 1 on Windows 10. After having installed WiX 3.10.2.2516 i cannot build node WiX project because it seems that wcautil.h referenced in custom_action.cc is missing.
screen shot 2016-01-20 at 14 26 00

Do you have any suggestion? Should i rollback to vs2013?

@mcollina
Copy link
Member Author

@joaocgreis I've added the nodemsi.wixproj stuff.

@felixfbecker
Copy link
Contributor

@piccoloaiutante I have the same issue, anyone has a fix?

@piccoloaiutante
Copy link
Member

@felixfbecker yes i solved it downloading WiX binaries and sources and adding their path to the custom_actions cpp project 'VC++ Directories' tab:

screen shot 2016-01-25 at 09 05 46

I still have problem during compilation time specifically for it-IT language. That's the output:

screen shot 2016-01-25 at 09 08 28

@mcollina
Copy link
Member Author

Possibly it's my bad, any idea how to fix those?

@piccoloaiutante
Copy link
Member

i fixed that problem @mcollina but then it seems i found some limit in WiX installer.
screen shot 2016-01-25 at 09 38 10

and this seems related to WiX libraries, as reported here:
http://windows-installer-xml-wix-toolset.687559.n2.nabble.com/localized-variable-unknown-for-fr-FR-it-IT-and-some-other-cultures-td7585859.html

@joaocgreis joaocgreis mentioned this pull request Mar 1, 2016
Closed
@mcollina
Copy link
Member Author

mcollina commented Mar 2, 2016

@piccoloaiutante maybe you can send those translation to upstream at wix (see #2569 (comment))?

@MylesBorins
Copy link
Contributor

@mcollina where are we at on this?

@mcollina
Copy link
Member Author

I think it's blocked on Wix. Is the best course of action to submit a PR to add Italian to https://github.com/wixtoolset/wix3/tree/develop/src/ext/UtilExtension/wixlib?

@piccoloaiutante
Copy link
Member

Sorry i missed it. Let me send the PR to WiX and see if it gets accepted.

@piccoloaiutante
Copy link
Member

PR for italian translation for Wix has been submitted. I hope they'll evaluate it soon..

wixtoolset/wix3#366

@piccoloaiutante
Copy link
Member

PR has been merged. I hope it gets its way into WiX weekly release so I can use it for building italian nodejs installer next week.

@piccoloaiutante
Copy link
Member

Bad news, it seems that the code merged won't be released till next version of visual studio is released.

I hope they will make a weekly release as they have done in June.

wixtoolset/wix3#366

In the meantime i suggest to go on and send PR for the language that we need so we can have them in the next version of Wix.

One temporary solution that i could try is to build my own version of wix, but that seems pretty challenging..

@piccoloaiutante
Copy link
Member

I finally got it working :)

screen shot 2016-07-13 at 12 05 43
screen shot 2016-07-13 at 12 05 23
screen shot 2016-07-13 at 12 05 14
screen shot 2016-07-13 at 12 05 08
screen shot 2016-07-13 at 12 04 59
screen shot 2016-07-13 at 12 04 51
screen shot 2016-07-13 at 12 04 45
screen shot 2016-07-13 at 12 03 01

@mcollina
Copy link
Member Author

@fhemberger I think it's enabled: https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L59.

@fhemberger
Copy link
Contributor

@mcollina No, the actual msi creation process is still disabled:
https://github.com/mcollina/node/blob/148f23c10f5f7c97030d27256c7a7a5510749716/tools/msvs/msi/nodemsi.wixproj#L79

mcollina added a commit to mcollina/node that referenced this pull request Jul 13, 2016
@mcollina
win,msi: Added Italian translation
c01d61a 
As titled. Tested by @piccoloaiutante.

PR-URL: nodejs#4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
@mcollina
Copy link
Member Author

Merged in as c01d61a

@mcollina mcollina closed this Jul 13, 2016
@fhemberger
Copy link
Contributor

@mcollina Great, thanks! Can we land #2569 as well?

@mcollina
Copy link
Member Author

@fhemberger can't really tell. I think so, but I know nothing about Chinese :(.

@fhemberger
Copy link
Contributor

@mcollina Well, regarding the content, there are several LGTMs from nodejs-cn.

evanlucas pushed a commit that referenced this pull request Jul 15, 2016
@mcollina @evanlucas
win,msi: Added Italian translation
f25c7ce 
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
Merged
evanlucas added a commit that referenced this pull request Jul 19, 2016
@evanlucas
2016-07-20, Version 6.3.1 (Current)
b0ed0fb 
Notable changes:

* deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531)
* win,msi
  * add zh-CN translations for the installer (Minqi Pan) [#2569](#2569)
  * Added Italian translation (Matteo Collina) [#4647](#4647)

PR-URL: #7782
@joaocgreis joaocgreis mentioned this pull request Jul 19, 2016
Closed
2 tasks
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@mcollina @cjihrig
win,msi: Added Italian translation
dbbcb9d 
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
@MylesBorins
Copy link
Contributor

@mcollina I am landing this on v4.x-staging. Would you be able to build and test that things are not weird?

MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@mcollina
win,msi: Added Italian translation
1924a18 
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
@mcollina
Copy link
Member Author

@thealphanerd not really, @piccoloaiutante will do it :)

@mcollina mcollina deleted the msvs-it branch September 30, 2016 16:19
@mcollina
Copy link
Member Author

mcollina commented Sep 30, 2016 •
edited
Loading

@thealphanerd as far as I remember, the translated installers were not enabled. Are you enabling them in the next release?

@MylesBorins
Copy link
Contributor

@mcollina I was unaware of that... just working on general backporting 💃

does this need to be enabled in our release process? Want to make an issue on build?

@mcollina
Copy link
Member Author

@thealphanerd I'm not really 100% of what that takes @piccoloaiutante did most of the windows-specific stuff. He is also looking to help on build nodejs/build#495.
I will let him drive this.

@piccoloaiutante
Copy link
Member

@thealphanerd enabling build for it-IT in in nodemsi.wixproj i was able to build this PR out of v4.x-staging. Do you need anything else?

screen shot 2016-10-03 at 14 29 29

screen shot 2016-10-03 at 14 31 46

@piccoloaiutante
Copy link
Member

@thealphanerd don't forget that in order to build it you need to install the weekly build of wixtoolset http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been included.

@MylesBorins
Copy link
Contributor

thanks for the confirmation, that was all I needed

On Mon, Oct 3, 2016, 8:45 AM Michele Capra notifications@github.com wrote:

@thealphanerd https://github.com/TheAlphaNerd don't forget that in
order to build it you need to install the weekly build of wixtoolset
http://wixtoolset.org/releases/v3-11-0-906/ where my PR for WiX has been
included.

—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#4647 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecVwGPq_0veNa_IWjD-OrRXqBWBi7Eks5qwPkEgaJpZM4HDGdc
.

rvagg pushed a commit that referenced this pull request Oct 18, 2016
@mcollina @rvagg
win,msi: Added Italian translation
e70146a 
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@mcollina @MylesBorins
win,msi: Added Italian translation
99f85b8 
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
install Issues and PRs related to the installers. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mcollina @piccoloaiutante @joaocgreis @felixfbecker @MylesBorins @rvagg @fhemberger @orangemocha @mscdex