Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.4.0 Proposal #8070

Merged
merged 144 commits into from
Aug 16, 2016
Merged

v6.4.0 Proposal #8070

merged 144 commits into from
Aug 16, 2016

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Aug 11, 2016

2016-08-15, Version 6.4.0 (Current), @cjihrig

Notable changes

  • build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
  • child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
  • child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
  • fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
  • repl: The REPL now supports editor mode. (Prince J Wesley) #7275
  • util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Commits

  • [06a0a053ea] - 2016-08-15, Version 6.4.0 (Current) (cjihrig) #8070
  • [342a85b1a7] - Working on v6.3.2 (Evan Lucas) #7782
  • [f135a4c3d1] - 2016-07-21, Version 6.3.1 (Current) (Evan Lucas) #7782
  • [57043aad33] - assert: fix deepEqual/deepStrictEqual on equivalent typed arrays (Feross Aboukhadijeh) #8002
  • [f6713bfabd] - bench: add bench for fs.realpath() fix (Trevor Norris) #7899
  • [0d4b04659f] - benchmark: favor === over == (Rich Trott) #8000
  • [98f51ffeb6] - buffer: fix unintended unsigned overflow (Fedor Indutny) #7494
  • [28071a130e] - buffer: introduce latin1 encoding term (Trevor Norris) #7111
  • [b0a557eef7] - build: add correct shared library naming on OS X (Stewart Addison) #7687
  • [6ed4ea8fd6] - build: turn on thin static archives (Ben Noordhuis) #7957
  • [c843e58914] - (SEMVER-MINOR) build: export zlib symbols on Windows (Alex Hultman) #7983
  • [889c62fec1] - build: fix dependency on missing header file (Ben Noordhuis) #7945
  • [a4394b8745] - build: fix typo in non-essential source file name (Ben Noordhuis) #7945
  • [636cf2236a] - build: adding config.gypi dep to addons/.buildstamp (Daniel Bevenius) #7893
  • [ddf292fc32] - build: don't link against liblog on host system (Ben Noordhuis) #7762
  • [f0312e6560] - (SEMVER-MINOR) build: export more openssl symbols on Windows (Alex Hultman) #7576
  • [e561895275] - (SEMVER-MINOR) child_process: control argv0 for spawned processes (Pat Pannuto) #7696
  • [da481c634f] - (SEMVER-MINOR) child_process: support stdio option in fork() (cjihrig) #7811
  • [a4f0b13e2b] - (SEMVER-MINOR) cluster: support stdio option for workers (cjihrig) #7838
  • [5f3ab3ffd1] - (SEMVER-MINOR) crypto: fix undefined behavior in ParseExtension (Fedor Indutny) #7494
  • [60d6e048f0] - (SEMVER-MINOR) deps: v8_inspector: console support (Aleksei Koziatinskii) #7988
  • [a9fe85ee9c] - deps: v8_inspector update (Ali Ijaz Sheikh) #8014
  • [4d81362b99] - deps: v8_inspector: remove jinja2 tests (Ali Ijaz Sheikh) #7796
  • [57312fc0c5] - deps: remove jinja.el from deps/v8_inspector (Ali Ijaz Sheikh) #7796
  • [507c65d94a] - deps: update v8_inspector (Ali Ijaz Sheikh) #7796
  • [3f46b5c18e] - deps: float gyp patch for long filenames (Anna Henningsen) #7963
  • [e6887e2ceb] - deps: cherry-pick a76d133 from v8 upstream (Matt Loring) #7689
  • [a03e3d3cff] - deps: cherry-pick b93c80a from v8 upstream (Matt Loring) #7689
  • [75b37a6bac] - deps: cherry-pick 43547df from V8 upstream (Franziska Hinkelmann) #7863
  • [af63871593] - deps: cherry-pick a51f429 from V8 upstream (Franziska Hinkelmann) #7834
  • [e82e80417b] - deps: backport 2bcbe2f from V8 upstream (ofrobots) #7814
  • [51a2041b90] - (SEMVER-MINOR) dgram: generalized send queue to handle close (Matteo Collina) #7066
  • [7eb95f6faa] - doc: minor updates to onboarding doc (Rich Trott) #8060
  • [5259322e62] - doc: add POST_STATUS_TO_PR info to onboarding doc (Rich Trott) #8059
  • [1903275963] - doc: update windows prerequisites (Ben Noordhuis) #8049
  • [3fe122f57e] - doc: update licenses (Ali Ijaz Sheikh) #7796
  • [14b762f81f] - doc: move orangemocha to collaborators list (Rich Trott) #8062
  • [ffbead92a0] - doc: Add fhinkel to collaborators (Franziska Hinkelmann) #8052
  • [96d15e2f3c] - doc: fix cluster message event docs (Zach Bjornson) #8017
  • [4a8b8048f2] - doc: add added: information for cluster (Anna Henningsen) #7640
  • [38255080db] - doc: remove spurious new line in CHANGELOG_V6.md (Luigi Pinca) #8009
  • [9f78c3f64f] - doc: fix typo in vm.runInNewContext() description (Luigi Pinca) #8005
  • [c4765a1b66] - doc: Clean up roff source in manpage (Alhadis) #7819
  • [cbcd03c912] - doc: add CTC meeting minutes 2016-08-03 (Josh Gavant) #7980
  • [7d0e5a0622] - doc: clarify collaborators & ctc members relationships (yorkie) #7996
  • [dedfcb7858] - doc: clarify fd closing by fs.readFile etc. (kibertoad) #7561
  • [ce776d22f9] - doc: fix a markdown error in CTC meeting minutes (Сковорода Никита Андреевич) #7729
  • [b20518a013] - doc: add added: information for events (Luigi Pinca) #7822
  • [7fa4be0f87] - doc: improve server.listen() random port (Phillip Johnsen) #7976
  • [7c427bdccc] - doc: clarify "Reviewed-By" iff "LGTM" (Bryan English) #7183
  • [cdbeae9adc] - doc: add CTC meeting minutes 2016-07-13 (Josh Gavant) #7968
  • [2245e843cc] - doc: add CTC meeting minutes 2016-07-20 (Josh Gavant) #7970
  • [cb0baca982] - doc: use consistent markdown in README (Rich Trott) #7971
  • [3d1a06451a] - doc: use git-secure-tag for release tags (Fedor Indutny) #7603
  • [e116cf96a0] - doc: use blockquotes for Stability: markers (Anna Henningsen) #7757
  • [c934f51aa4] - doc: fix default encoding mention in crypto.md (hugnosis) #7805
  • [df35ae6246] - doc: fix minor formatting issue in 0.10 changelog (Сковорода Никита Андреевич) #7727
  • [5f12807c46] - doc: remove extra indentation in iojs changelog (Сковорода Никита Андреевич) #7727
  • [abd0bc0523] - doc: *.md formatting fixes in the top-level dir (Сковорода Никита Андреевич) #7727
  • [c72019b75a] - doc: convert tabs to spaces (Сковорода Никита Андреевич) #7727
  • [0fbb83a67b] - doc: piscisaureus has stepped-down from the CTC (James M Snell) #7969
  • [48422c240a] - doc: add @addaleax to the CTC (Anna Henningsen) #7966
  • [0094adc0b2] - doc: add CTC meeting minutes 2016-06-22 (Josh Gavant) #7390
  • [fd9b7b4c5a] - doc: add CTC meeting minutes 2016-07-06 (Josh Gavant) #7570
  • [4616261110] - doc: add CTC meeting minutes 2016-06-29 (Josh Gavant) #7571
  • [bb90867339] - doc: add CTC meeting minutes 2016-07-27 (William Kapke) #7900
  • [7d0c1bf781] - doc: fix path markdown formatting (Joey Cozza) #7817
  • [04ec64aacc] - doc: add missing semicolon (Ravindra barthwal) #7915
  • [8d8d70d826] - doc: fill in missing V8 version (Timothy Gu) #7878
  • [6ce9c80ccb] - doc: remove extra spaces and concats in examples (Joe Esposito) #7885
  • [23b6468667] - doc: add information about CTC quorum rules (Rich Trott) #7813
  • [0645c3d0c4] - doc: align breakEvalOnSigint - repl option (Prince J Wesley) #7849
  • [14a0c3181c] - doc: remove platform assumption from CONTRIBUTING (Bethany N Griggs) #7783
  • [5c4b938665] - doc: minor typo fixes in stream docs (Alex Perkins) #7763
  • [57fb0d2ee2] - doc: add/fix version metadata for Buffer methods (Brian White) #7784
  • [49a669bcda] - doc: improve function parameter descriptions (Brian White) #7784
  • [bdc8690610] - doc: add missing properties in Buffer docs (Brian White) #7784
  • [a8e7c7f2bf] - doc: improve wording and style of Buffer docs (Brian White) #7784
  • [9a4a00bcdb] - doc: improve links in Buffer docs (Brian White) #7784
  • [0103d9dcea] - doc: reorganize Buffer link references (Brian White) #7784
  • [17ae49a055] - doc: improve Buffer code examples (Brian White) #7784
  • [0ffeddb5b4] - doc: various documentation formatting fixes (Сковорода Никита Андреевич) #7637
  • [1fa9330ac6] - doc: add princejwesley to collaborators (Prince J Wesley) #7877
  • [715ac62670] - doc: clarify that the node.js irc channel is not under tsc oversight (James M Snell) #7810
  • [edb877da65] - doc: fix added: date for NODE_REPL_HISTORY (Anna Henningsen) #7775
  • [27f92efaee] - doctool: improve the title of pages in doc (yorkie) #7939
  • [18a3064937] - fs: restore JS implementation of realpath (Bartosz Sosnowski) #7899
  • [0bb9d21f0e] - (SEMVER-MINOR) fs: add bytesRead to ReadStream (Linus Unnebäck) #7942
  • [db3a7e83eb] - http: specify _implicitHeader in OutgoingMessage (yorkie) #7949
  • [b75ca50c90] - inspector: Do not crash if the port is n/a (Eugene Ostroukhov) #7874
  • [7dc66f82e3] - lib: remove double check of string type (Franziska Hinkelmann) #7985
  • [5cc4b0ed15] - meta: clarify process for breaking changes (Rich Trott) #7955
  • [79ecfb5183] - meta: include a minimal CTC removal policy (Rich Trott) #7720
  • [376d73b3b9] - meta: provide example activities (Rich Trott) #7744
  • [ccbb46378f] - module: fix node_modules search path in edge case (hefangshi) #6670
  • [2f32191686] - (SEMVER-MINOR) process: save original argv[0] (Pat Pannuto) #7696
  • [d9c9e46780] - repl: disable Ctrl+C support on win32 for now (Anna Henningsen) #7977
  • [61e57e06a6] - repl: don't override all internal repl defaults (cjihrig) #7826
  • [4875aa2aa2] - (SEMVER-MINOR) repl: Add editor mode support (Prince J Wesley) #7275
  • [fc3ba2ff4f] - (SEMVER-MINOR) repl: Use displayErrors for SyntaxError (Prince J Wesley) #7589
  • [b3164ae22e] - (SEMVER-MINOR) repl: add support for custom completions (Diosney Sarmiento) #7527
  • [980f4da8c4] - repl: prevent undefined ref in completion (Evan Lucas) #7718
  • [6e6cf36761] - repl: default useGlobal to true (cjihrig) #7795
  • [08e6eeee70] - repl,util: insert carriage returns in output (JungMinu) #8028
  • [fb8840cac2] - src: use RAII for mutexes in node_watchdog.cc (Anna Henningsen) #7933
  • [780395ffca] - src: fix use-after-free in inspector agent (Ben Noordhuis) #7907
  • [9d45569ed4] - src: avoid manual memory management in inspector (Ben Noordhuis) #7906
  • [a20336e708] - src: remove unused using decls (Haojian Wu) #7990
  • [317ae96c33] - src: make EnvDelete behave like the delete operator (Franziska Hinkelmann) #7975
  • [1ab796fa96] - src: do not copy on failing setProperty() (Franziska Hinkelmann) #7908
  • [cf65a7ce9e] - src: unifying PipeConnectWrap and TCPConnectWrap (Daniel Bevenius) #7501
  • [63c62cce35] - src: Only use TR1 type_traits on OSX<10.9 (Ehsan Akhgari) #7778
  • [d7143095cb] - src: fix build on CentOS (Rich Trott) #7873
  • [303f4102d3] - src: pull OnConnection from pipe_wrap and tcp_wrap (Daniel Bevenius) #7547
  • [c967af8c07] - src: suppress coverity message (cjihrig) #7587
  • [f3e5b39696] - src: guard against overflow in ParseArrayIndex() (Ben Noordhuis) #7497
  • [c730a5d026] - src: move ParseArrayIndex() to src/node_buffer.cc (Ben Noordhuis) #7497
  • [da9bd2fc48] - src: alias BINARY to LATIN1 (Ben Noordhuis) #7284
  • [7ba0f860a6] - src: fix erroneous fallthrough in ParseEncoding() (Ben Noordhuis) #7262
  • [a059aea9a2] - src: remove final trace of raw encoding (Trevor Norris) #7111
  • [2db26cb165] - test: add test for debug usage message (Rich Trott) #8061
  • [2e435998eb] - test: mark test failing on AIX as flaky (Michael Dawson) #8065
  • [554b0f9d91] - test: fix failing inspector cctest (Eugene Ostroukhov) #8019
  • [c565c17636] - test: fix memory leaks in inspector tests (Ben Noordhuis) #7906
  • [5d68e4ba9b] - test: console constructor missing new keyword (Rich Trott) #8003
  • [9735accd3e] - test: allow globals to be whitelisted (cjihrig) #7826
  • [a385277eb5] - test: fix flaky test-vm-sigint-existing-handler (Anna Henningsen) #7982
  • [b5beae2529] - test: remove internal headers from addons (Gibson Fahnestock) #7947
  • [02b12fe880] - test: improve chained property readability (Rich Trott) #7920
  • [d94063a22b] - test: fix test-vm-sigint flakiness (Santiago Gimeno) #7854
  • [facd7dade1] - test: don't hard code deprecation count (Prince J Wesley) #7927
  • [4aee970d92] - test: decrease inconsistency in the common.js (Vse Mozhet Byt) #7758
  • [10f0c94c35] - test: fix flaky test-tls-wrap-timeout (Rich Trott) #7857
  • [ccfa6bf4d4] - test: speed up test-net-reconnect-error (Rich Trott) #7886
  • [577adc74cd] - test: ensure stream preprocessing order (Vse Mozhet Byt) #7741
  • [8f51e36898] - test: use common platform helpers everywhere (Santiago Gimeno) #7845
  • [2f45941807] - test: handle IPv6 localhost issues within tests (Rich Trott) #7766
  • [e56db1477c] - test: fix flaky test-*-connect-address-family (Rich Trott) #7605
  • [1ab6df6b04] - test: make import common as the first line (Sakthipriyan Vairamani) #7786
  • [0daceffd38] - test,assert: add deepEqual/deepStrictEqual tests for typed arrays (Feross Aboukhadijeh) #8002
  • [4416ffab8a] - test,util: fix flaky test-util-sigint-watchdog (Anna Henningsen) #7933
  • [4535149794] - timers: remove unused repeat param in timer_wrap (Jan Schär) #7994
  • [381aef8145] - timers: fix cleanup of nested same-timeout timers (Erin Spiceland) #7827
  • [e611c293bb] - tools: enable rest-spread-spacing (Rich Trott) #8073
  • [7eb0e7a479] - tools: favor === over == in license2rtf.js (Rich Trott)
  • [583a2515da] - tools: update license-builder.sh for v8_inspector (Ali Ijaz Sheikh) #7796
  • [97934f99bb] - tools: enable linting for chained properties (Rich Trott) #7999
  • [60ff991c09] - tools: update to ESLint 3.2.2 (Rich Trott) #7999
  • [d37a17ec5f] - tools: add remark-lint configuration in .remarkrc (Сковорода Никита Андреевич) #7729
  • [cb16e97e9f] - tools: add .vscode folder to .gitignore (Josh Gavant) #7967
  • [fecf611ca8] - tools,test: show signal code when test crashes (Santiago Gimeno) #7859
  • [2f20910e24] - tty: set the handle to blocking mode (Jeremiah Senkpiel) #6816
  • [cfec3ae5fd] - (SEMVER-MINOR) util: add inspect.defaultOptions (Roman Reiss) #8013
  • [295d1ea016] - util: support classes in util.deprecate() (vladimir) #7690
  • [0a07201ca1] - util: fix formatting of objects with SIMD enabled (Anna Henningsen) #7864
  • [f1c50a8c5e] - win,msi: fix inclusion of translations (João Reis) #7798
  • [dbbcb9dbd9] - win,msi: Added Italian translation (Matteo Collina) #4647
  • [909254c901] - zlib: remove unneeded property (Jan Schär) #7987

bnoordhuis and others added 30 commits August 10, 2016 10:57
It's not used anywhere else so move it out of src/node_internals.h.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Conflicts:
	src/node_internals.h
ParseArrayIndex() would wrap around large (>=2^32) index values on
platforms where sizeof(int64_t) > sizeof(size_t).  Ensure that the
return value fits in a size_t.

PR-URL: #7497
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Coverity marked a change in 630096b as a constant expression.
However, on platforms where sizeof(int64_t) > sizeof(size_t),
this should not be the case. This commit flags the comparison
as OK to coverity.

PR-URL: #7587
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Allow user code to override the default `complete()` function from
`readline.Interface`. See:
https://nodejs.org/api/readline.html#readline_use_of_the_completer_function

Ref: nodejs/node-v0.x-archive#8484

PR-URL: #7527
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Lance Ball <lball@redhat.com>
`offset` is user supplied variable and may be bigger than
`ts_obj_length`. There is no need to subtract them and pass along, so
just throw when the subtraction result would overflow.

PR-URL: #7494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Many extensions are unknown to the `ClientHelloParser::ParseExtension`,
do not cast user-supplied `uint16_t` to `enum`.

PR-URL: #7494
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Skip tests if localhost does not resolve to ::1.

Fixes: #7288
PR-URL: #7605
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>

Conflicts:
	test/parallel/test-https-connect-address-family.js
	test/parallel/test-tls-connect-address-family.js
This exports even more openssl symbols when building
on Windows. SSL_set_fd is one example of added symbol.

PR-URL: #7576
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Roman Reiss <me@silverwind.io>
As titled. Tested by @piccoloaiutante.

PR-URL: #4647
Refs: wixtoolset/wix3#366
Reviewed-By: Rod Vagg <rod@vagg.org>
Reviewed-By: Frederic Hemberger <mail@frederic-hemberger.de>
If the udp socket is not ready and we are accumulating
messages to send, it needs to delay closing the socket when
all messages are flushed.

Fixes: #7061
PR-URL: #7066
Reviewed-By: Anna Henningsen <anna@addaleax.net>
* Fix markdown code sample in releases.md, it was <a id="x.y.x></a>"
* Fix some markdown errors, e.g. in changelogs
* Fix broken defs links, e.g. in domain-postmortem.md
* Fix other broken refs, by addaleax
* Add links to some defs that were present but not linked to
* Remove dead defs
* Move defs to the bottom (one file affected)
* Add language indicators to all code blocks, using `txt` when no
specific language could be chosen
* Some minor formatting changes (spaces, ident, headings)

PR-URL: #7637
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Roman Reiss <me@silverwind.io>

Conflicts:
	doc/api/zlib.md
	doc/changelogs/CHANGELOG_V4.md
The issue of hosts that do not resolve `localhost` to `::1` is now
handled within the tests. Remove flaky status for
test-https-connect-address-family and test-tls-connect-address-family.

PR-URL: #7766
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
This commit allows child_process.fork() to pass stdio options
to spawn(). This allows fork() to more easily take advantage of
additional stdio channels.

Refs: nodejs/node-v0.x-archive#5727
PR-URL: #7811
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This commit adds more links and separates internal doc links
from external web links.

PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
This commit adds more links and reuses existing link references more.

PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
PR-URL: #7784
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
One of the issues in #4641 concerns OnConnection in pipe_wrap and
tcp_wrap which are very similar with some minor difference in how
they are coded. This commit extracts OnConnection so both these
classes can share the same implementation.

PR-URL: #7547
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Trevor Norris <trev.norris@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
85af1a6 was added (squashed into another commit) without running
through CI. Unfortunately, it breaks some of the CI builds, notably on
three of the CentOS setups.

Undoing that one small change to get builds green again.

Refs: #7547 (comment)
PR-URL: #7873
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Original commit message:

If we can't rehash the backing store for weak sets & maps, do a last
resort GC

BUG=v8:4909
R=hpayer@chromium.org

Committed: https://crrev.com/b93c80a6039c757723e70420ae73375b5d277814
Cr-Commit-Position: refs/heads/master@{#37591}

Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Original commit message:

Fix incorrect parameter to HasSufficientCapacity

It takes the number of additional elements, not the total target
capacity.

Also, avoid right-shifting a negative integer as this is undefined in
general

BUG=v8:4909
R=verwaest@chromium.org

Review-Url: https://codereview.chromium.org/2162333002
Cr-Commit-Position: refs/heads/master@{#37901}

Fixes: #6180
PR-URL: #7689
Reviewed-By: Matt Loring <mattloring@google.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Use the common.isWindows, common.isFreeBSD and common.isSunOS where
possible.
Add common.isOSX and common.isLinux.
Fix `test-fs-read-file-sync-hostname` as in its current form was not
being run anywhere.

PR-URL: #7845
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
Mac OSX 10.9 has switched to using libc++ by default.  libc++
provides a C++11 <type_traits> implementation, so we only need
to use the TR1 version when targetting OSX 10.8 or 10.7.

PR-URL: #7778
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #7763
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Sometimes it is necessary to preprocess some initial bit
of a stream data before giving the entire stream
to the main processing function. Sometimes this bit should be extracted
from the stream before the main processing; sometimes it should be
returned to the stream. This test checks an order of stream
modes, methods and events for a possible preprocessing algorithm.
Stream BOM stripping is selected as a use case.

See nodejs/help#221 as the prehistory.

PR-URL: #7741
Reviewed-By: Anna Henningsen <anna@addaleax.net>
```js
node 🙈 ₹ git:(upstream ⚡ display-error-repl) ./node
> var 4;
var 4;
    ^
SyntaxError: Unexpected number

>
```

PR-URL: #7589
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>

Conflicts:
	test/parallel/test-repl.js
- Specify that the ‘make test’ commands are Unix/OS X specific.
- Link to BUILDING.md for other platform commands.

Fixes: #7646
PR-URL: #7783
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@jasnell
Copy link
Member

jasnell commented Aug 11, 2016

Perhaps include in the notable changes:

@richardlau
Copy link
Member

Should #7689 have bumped the V8 patch level?

cjihrig added a commit that referenced this pull request Aug 11, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 12, 2016

CITGM seems fine, if I'm reading the results correctly. Two of the errors are linting errors. The third looks like a spurious failure in async's tests, which I cannot reproduce locally on the same OS.

@MylesBorins
Copy link
Contributor

it looks to me like there is a legitimate failure on vinyl-fs on Ubuntu and
Debian, (this is in addition to the lint error)

I can dig into this more tomorrow.

On Thu, Aug 11, 2016, 8:19 PM Colin Ihrig notifications@github.com wrote:

CITGM seems fine, if I'm reading the results correctly. Two of the errors
are linting errors. The third looks like a spurious failure in async's
tests, which I cannot reproduce locally on the same OS.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8070 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AAecV9JdaVbT07RVjoB8d9w1pKhXLsCkks5qe7v2gaJpZM4Jifmb
.

@MylesBorins
Copy link
Contributor

turns out it is tomorrow today!

vinyl-fs tested on v6.3.1: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/349/
against v6.4.0-proposal: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/350/

@MylesBorins
Copy link
Contributor

looks like the failures are on v6.3.1, so we should be good to move ahead with this release. I'll follow up with @phated to see what is going on with the broken tests on v6.x

@cjihrig
Copy link
Contributor Author

cjihrig commented Aug 12, 2016

Going to have to revisit this next week to avoid a Friday release. FWIW, one of the Jenkins release jobs has been running for over 9 hours.

alexkozy and others added 11 commits August 15, 2016 09:50
When node is running with --inspect flag, default console.log,
console.warn and other methods call inspector console methods in
addition to current behaviour (dump formatted message to stderr and
stdout). Inspector console methods forward message to DevTools and
show up in DevTools Console with DevTools formatters. Inspector
console methods not present on Node console will be added into it.

Only own methods on global.console object will be changed while in a
debugging session. User are still able to redefine it, use
console.Console or change original methods on Console.prototype.

PR-URL: #7988
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: jasnell - James M Snell <jasnell@gmail.com>
Reviewed-By: ofrobots - Ali Ijaz Sheikh <ofrobots@google.com>
This reverts parts of b488b19
restoring javascript implementation of realpath and realpathSync.

Fixes: #7175
Fixes: #6861
Fixes: #7294
Fixes: #7192
Fixes: #7044
Fixes: #6624
Fixes: #6978
PR-URL: #7899
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
The benchmarks included also work for the previous JS
implementation of fs.realpath(). In case the new implementation of
realpath() needs to be reverted, we want these changes to stick around.

PR-URL: #7899
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Visual Studio 2013 is no longer supported.  Update the Windows build
prerequisites.

Refs: #7484
PR-URL: #8049
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
`POST_STATUS_TO_PR` previously did not work.

Now it works.

Update the onboarding documentation accordingly.

PR-URL: #8059
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #8060
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
PR-URL: #8061
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
`\n` is not enough for Linux with some custom stream
add carriage returns to ensure that the output is displayed correctly
using `\r\n` should not be a problem, even on non-Windows platforms.

Fixes: #7954
PR-URL: #8028
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: https://github.com/nodejs/node/pull/8068.patch
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Prince John Wesley <princejohnwesley@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
There are currently 17 instances of the spread operator and all of them
have no space between the operator and the subsequent argument. This
change enables a lint rule to enforce that same style on any future uses
of the spread operator.

Refs: https://github.com/nodejs/node/pull/6573/files/7a1b47f329f2e6481ef8f54951570197fd98378d#r74479351
PR-URL: #8073
Reviewed-By: cjihrig - Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: targos - Michaël Zasso <mic.besace@gmail.com>
Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) #7983 and #7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) #7811 and #7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) #7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) #7942
* repl: The REPL now supports editor mode. (Prince J Wesley) #7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) #8013

Refs: #8020
PR-URL: #8070
@cjihrig cjihrig merged commit 5cff147 into v6.x Aug 16, 2016
cjihrig added a commit to cjihrig/node that referenced this pull request Aug 16, 2016
Notable changes:

* build: zlib symbols and additional OpenSSL symbols are now exposed on Windows platforms. (Alex Hultman) nodejs#7983 and nodejs#7576
* child_process, cluster: Forked child processes and cluster workers now support stdio configuration. (Colin Ihrig) nodejs#7811 and nodejs#7838
* child_process: argv[0] can now be set to arbitrary values in spawned processes. (Pat Pannuto) nodejs#7696
* fs: fs.ReadStream now exposes the number of bytes it has read so far. (Linus Unnebäck) nodejs#7942
* repl: The REPL now supports editor mode. (Prince J Wesley) nodejs#7275
* util: inspect() can now be configured globally using util.inspect.defaultOptions. (Roman Reiss) nodejs#8013

Refs: nodejs#8020
PR-URL: nodejs#8070
@cjihrig cjihrig deleted the v6.4.0-proposal branch August 16, 2016 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.