test: fix flaky test-https-connect-address-family #7605
Conversation
Trott
added
https
|
One build failure on Raspberry Pi but otherwise CI is good. |
|
nice, lgtm |
|
LGTM |
|
@Trott would the same fix work for |
|
@gibfahn Whoops, yes, I'll add that file too... |
|
Added a second commit to addres test-tls-connect-address-family the same way. PTAL. |
| if (err) | ||
| throw err; | ||
|
|
||
| if (addresses.some((val) => { return val.address === '::1'; })) |
There was a problem hiding this comment.
Wouldn't it be better to do
addresses.some((val) => val.address === '::1')There was a problem hiding this comment.
I thought I was going with the de facto standard in the project code as it exists, but it looks like you are correct. There are over 150 instances where the braces are already omitted and only around 20 cases where there are braces included even though they can be removed.
So, yeah, I'll remove these.
|
LGTM |
Skip test if localhost does not resolve to ::1. Fixes: nodejs#7288
Skip test if localhost does not resolve to ::1. Fixes: nodejs#7288
Skip tests if localhost does not resolve to ::1. Fixes: nodejs#7288 PR-URL: nodejs#7605 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
|
Landed in 2d77cba |
Skip tests if localhost does not resolve to ::1. Fixes: #7288 PR-URL: #7605 Reviewed-By: Rod Vagg <rod@vagg.org> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Conflicts: test/parallel/test-https-connect-address-family.js test/parallel/test-tls-connect-address-family.js
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
test https
Description of change
Skip test if localhost does not resolve to ::1.
Fixes: #7288