Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: fix added: date for NODE_REPL_HISTORY #7775

Closed

Conversation

addaleax
Copy link
Member

NODE_REPL_HISTORY was introduced in v3.0.0 (see e.g. 6faf17c).

I noticed this while doing the conflict resolution for the backport in #7677, and I think I wanted to PR that against master right then, but ended up correcting the version in the backport – sorry for that.

`NODE_REPL_HISTORY` was introduced in v3.0.0
(see e.g. 6faf17c).
@addaleax addaleax added the doc Issues and PRs related to the documentations. label Jul 17, 2016
@Fishrock123
Copy link
Contributor

hmmmm, @phillipj / @mscdex the labeling here doesn't look quite right?

@phillipj
Copy link
Member

@Fishrock123 you're thinking of the cli label here? That's intentional as of nodejs/github-bot#47

@mscdex
Copy link
Contributor

mscdex commented Jul 17, 2016

Looks alright to me.

EDIT: referring to the PR labeling

@cjihrig
Copy link
Contributor

cjihrig commented Jul 18, 2016

LGTM

@silverwind
Copy link
Contributor

silverwind commented Jul 19, 2016

LGTM.

BTW, are we okay backticks in commit messages?

@addaleax
Copy link
Member Author

I think they are actually encouraged if their content would otherwise be parsed non-trivially by markdown parsers in the changelog (e.g. for words starting/ending with underscores)?

@silverwind
Copy link
Contributor

silverwind commented Jul 19, 2016

They might be nice for changelog rendering, but I'd personally avoid them until GitHub decides to render them in the commit log (like they interestingly already do for :emoji:). It's not a big issue if you like to keep them, though. 😉

@addaleax
Copy link
Member Author

I’d like to keep them, yeah. For me they make it easier to parse, even without markdown rendering. :)

@addaleax
Copy link
Member Author

Landed in c67ec57

@addaleax addaleax closed this Jul 25, 2016
@addaleax addaleax deleted the doc-fix-repl-history-env-added branch July 25, 2016 08:03
addaleax added a commit that referenced this pull request Jul 25, 2016
`NODE_REPL_HISTORY` was introduced in v3.0.0
(see e.g. 6faf17c).

PR-URL: #7775
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
evanlucas pushed a commit that referenced this pull request Aug 2, 2016
`NODE_REPL_HISTORY` was introduced in v3.0.0
(see e.g. 6faf17c).

PR-URL: #7775
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
gibfahn pushed a commit to gibfahn/node that referenced this pull request Aug 5, 2016
`NODE_REPL_HISTORY` was introduced in v3.0.0
(see e.g. 6faf17c).

PR-URL: nodejs#7775
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Roman Reiss <me@silverwind.io>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants