doc: add POST_STATUS_TO_PR info to onboarding doc #8059
Conversation
|
Commit message typo: LGTM but got a question… does it ever make sense not to check that box? |
|
@addaleax (Whoops, ignore previous comment, I misread your question.) I guess not. I suppose it might be worthwhile asking @nodejs/build to make that box checked by default and then we don't have to mention it at all in the onboarding doc! |
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly.
|
@addaleax Updated the commit message. Thanks. |
|
@jbergstroem think we are ready to move forward with this or is there still stuff being worked on there? |
|
Can we change the default for |
|
Yeah, I'd definitely prefer for post status to be on by default. |
|
I'd like to get some more time working with this if that's ok. ETA ~1w. |
|
Same goes for me for having in on by default once we are ready. |
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: nodejs#8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Landed in fa1476c. (We can update it again when the default switches to the box being checked. I expect to be updating the onboarding doc frequently anyway.) |
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
`POST_STATUS_TO_PR` previously did not work. Now it works. Update the onboarding documentation accordingly. PR-URL: #8059 Reviewed-By: Anna Henningsen <anna@addaleax.net>
Checklist
Affected core subsystem(s)
doc
Description of change
POST_STATUS_TO_PRdid not used to work.Now it works.
Update the onboarding documentation accordingly.