timers: remove unused repeat param in timer_wrap #7994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `repeat` param in `start(timeout, repeat)` was 0 in all callsites.
nodejs-github-bot
added
c++
|
seems fine to me |
mscdex
removed
the
c++
|
LGTM |
|
A pair of build failures on CI. Trying again: https://ci.nodejs.org/job/node-test-pull-request/3556/ |
|
LGTM. It looks like there were more build failures. |
|
LGTM |
jasnell
pushed a commit
that referenced
this pull request
Aug 9, 2016
The `repeat` param in `start(timeout, repeat)` was 0 in all callsites. PR-URL: #7994 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in 1b99093 |
cjihrig
pushed a commit
that referenced
this pull request
Aug 10, 2016
The `repeat` param in `start(timeout, repeat)` was 0 in all callsites. PR-URL: #7994 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Brian White <mscdex@mscdex.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
|
adding don't land for now. @Fishrock123 you will likely want to include this if you decide to do the timers backport |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
Description of change
The
repeatparam instart(timeout, repeat)was 0 in all callsites. Because this is an internal API, it can be safely removed.