Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Add fhinkel to collaborators #8052

Closed
wants to merge 1 commit into from
Closed

Conversation

fhinkel
Copy link
Member

@fhinkel fhinkel commented Aug 10, 2016

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Add https://github.com/fhinkel to collaborators.

@fhinkel fhinkel added the doc Issues and PRs related to the documentations. label Aug 10, 2016
@@ -216,6 +216,8 @@ more information about the governance of the Node.js project, see
**Robert Jefe Lindstaedt** <robert.lindstaedt@gmail.com>
* [estliberitas](https://github.com/estliberitas) -
**Alexander Makarenko** <estliberitas@gmail.com>
* [fhinkel] (https://github.com/fhinkel) -
**Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there's a missing ** after your name.

@fhinkel
Copy link
Member Author

fhinkel commented Aug 10, 2016

@cjihrig
Copy link
Contributor

cjihrig commented Aug 10, 2016

LGTM, pending nits.

@Trott
Copy link
Member

Trott commented Aug 10, 2016

LGTM

@jasnell
Copy link
Member

jasnell commented Aug 10, 2016

LGTM!

fhinkel added a commit that referenced this pull request Aug 10, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@fhinkel
Copy link
Member Author

fhinkel commented Aug 10, 2016

Landed in 4878e1c.

@fhinkel fhinkel closed this Aug 10, 2016
@MylesBorins
Copy link
Contributor

🎉🎉🎉🎉

On Wed, Aug 10, 2016, 1:18 PM Franziska Hinkelmann notifications@github.com
wrote:

Closed #8052 #8052.


You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#8052 (comment), or mute the
thread
https://github.com/notifications/unsubscribe-auth/AAecVx4TJqBsftpL4sbGUI7bhxymc5Vgks5qegffgaJpZM4JhXNJ
.

cjihrig pushed a commit that referenced this pull request Aug 10, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
PR-URL: #8052
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants