Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add @addaleax to the CTC #7966

Closed
wants to merge 1 commit into from
Closed

doc: add @addaleax to the CTC #7966

wants to merge 1 commit into from

Conversation

addaleax
Copy link
Member

@addaleax addaleax commented Aug 3, 2016

I am not sure there’s a fixed process for this (or if so, I couldn’t find it/tell from the previous CTC changes), so… I guess here I am?

@addaleax
doc: add @addaleax to the CTC
bca4595 
Voted on and approved at CTC meeting
nodejs#7948
(2016-08-03).
@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Aug 3, 2016
@evanlucas
Copy link
Contributor

LGTM

1 similar comment
@cjihrig
Copy link
Contributor

cjihrig commented Aug 3, 2016

LGTM

@bnoordhuis
Copy link
Member

There goes my top spot... LGTM. Welcome, Anna.

@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

LGTM!!

@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

I'm gonna go out on a limb and say this one doesn't need to wait 48/72 hours to land. The CTC approved the nomination today and @addaleax is now a CTC member. Woot!

jasnell pushed a commit that referenced this pull request Aug 3, 2016
@addaleax @jasnell
doc: add @addaleax to the CTC
0c73685 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@addaleax
Copy link
Member Author

addaleax commented Aug 3, 2016

@jasnell … was just about to merge this myself ;)
Did you mean to close this? Anyway, landed in 0c73685!

@addaleax addaleax closed this Aug 3, 2016
@addaleax addaleax deleted the addaleax-ctc branch August 3, 2016 22:38
@jasnell
Copy link
Member

jasnell commented Aug 3, 2016

Yes! I just hadn't gotten back to the UI to do so :-D

@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@addaleax @cjihrig
doc: add @addaleax to the CTC
48422c2 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Sep 9, 2016
@addaleax
doc: add @addaleax to the CTC
9296373 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
@addaleax
doc: add @addaleax to the CTC
d0dd117 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@addaleax @rvagg
doc: add @addaleax to the CTC
2eaffc0 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@addaleax @MylesBorins
doc: add @addaleax to the CTC
9700660 
Voted on and approved at CTC meeting
#7948
(2016-08-03).

PR-URL: #7966
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@addaleax @evanlucas @cjihrig @bnoordhuis @jasnell @MylesBorins @nodejs-github-bot