Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v6.3.1 Release Proposal #7782

Merged
merged 2 commits into from
Jul 21, 2016
Merged

v6.3.1 Release Proposal #7782

merged 2 commits into from
Jul 21, 2016

Conversation

evanlucas
Copy link
Contributor

@evanlucas evanlucas commented Jul 18, 2016

2016-07-21, Version 6.3.1 (Current), @evanlucas

Notable changes

  • buffer:
    • Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
    • Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
  • deps:
    • Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
    • Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
  • repl: Fix issue with function redeclaration. (Prince J Wesley) #7794
  • util: Fix inspecting of boxed symbols. (Anna Henningsen) #7641

Commits

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Jul 18, 2016
@evanlucas evanlucas added arm Issues and PRs related to the ARM platform. v6.x and removed arm Issues and PRs related to the ARM platform. labels Jul 18, 2016
evanlucas added a commit that referenced this pull request Jul 18, 2016
Notable changes:

* deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531)

PR-URL: #7782
evanlucas added a commit that referenced this pull request Jul 18, 2016
@gibfahn
Copy link
Member

gibfahn commented Jul 18, 2016

@evanlucas It might be worth waiting until the changes discussed in #7123 (comment) land. Looks like #7751 + another PR this week.

@evanlucas
Copy link
Contributor Author

@gibfahn yea, this isn't going out today. I will incrementally updating this PR. If on Wednesday, v6.x is in a good state, we will push it out. If it needs to wait on things still, then we will wait :]. Thanks for the heads up though!

@addaleax
Copy link
Member

btw, there are a couple of open PRs labelled v6.x, I think they all are good to go and can be landed/included here?

@evanlucas
Copy link
Contributor Author

@addaleax thanks! I'll take a look

@Fishrock123
Copy link
Contributor

@evanlucas Nice, thanks for picking it up this week. :D

Maybe mention the translations for the Windows installers in the Notable Changes?

@addaleax if they land they will be included, usually we don't hold releases on specific PRs?

@addaleax
Copy link
Member

@Fishrock123 Sorry, didn’t mean to imply these would need to be included or anything.

evanlucas added a commit that referenced this pull request Jul 19, 2016
Notable changes:

* deps: upgrade to V8 5.0.71.54 (Ben Noordhuis) [#7531](#7531)
* win,msi
  * add zh-CN translations for the installer (Minqi Pan) [#2569](#2569)
  * Added Italian translation (Matteo Collina) [#4647](#4647)

PR-URL: #7782
evanlucas added a commit that referenced this pull request Jul 19, 2016
@evanlucas evanlucas changed the title 2016-07-18, Version 6.3.1 (Current) v6.3.1 Release Proposal Jul 19, 2016
@evanlucas
Copy link
Contributor Author

did another round of commits. I will plan on shipping early tomorrow morning unless there are any objections.

@evanlucas
Copy link
Contributor Author

@bnoordhuis
Copy link
Member

@evanlucas Re: "deps: upgrade to V8 5.0.71.54", some of the back-ports bump the patch level. Might be confusing to release notes readers.

@evanlucas
Copy link
Contributor Author

@bnoordhuis ah thanks for the heads up. Any suggestions on how to word to prevent confusion?

@mhdawson
Copy link
Member

Have we resolved the licensing issue with node inspector. I don't think we should ship again without having done that.

@mhdawson
Copy link
Member

looking at the issue where the things to be done are listed: #7123 (comment) it does not look like the licensing issues have been addressed. @ofrobots are those likely to get in soon ?

@ofrobots
Copy link
Contributor

@mhdawson #7751 has landed already and we are waiting for one CL to land upstream for the rest. Hopefully we can get this finished today. /cc @eugeneo

@bnoordhuis
Copy link
Member

Any suggestions on how to word to prevent confusion?

Feel free to leave my name out and just say "Upgrade to V8 5.0.71.xx."

@joaocgreis
Copy link
Member

@evanlucas the Italian translation introduced a bug that prevents the MSI to be generated. So, even if CI and CITGM are green, the release job will fail. You can either leave it out for this release or wait for #7798 to land (not sure if it qualifies as urgent and can land before 48h have passed?).

@evanlucas
Copy link
Contributor Author

@joaocgreis thanks for the heads up. I would be fine with it landing sooner than the 48h if @nodejs/platform-windows is cool with it

@evanlucas
Copy link
Contributor Author

I'm going to hold off on this until we know that the plinux issues are not from something in this branch

@Fishrock123
Copy link
Contributor

Fishrock123 commented Jul 21, 2016

@evanlucas I thought the plinux hardware was just generally having issues? @mhdawson?

@jbergstroem / @rvagg ?

@evanlucas
Copy link
Contributor Author

@Fishrock123 yea, I just wanted to confirm

evanlucas added a commit that referenced this pull request Jul 21, 2016
Notable changes:

* **buffer**:
  * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
  * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**: Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641

PR-URL: #7782
evanlucas added a commit that referenced this pull request Jul 21, 2016
@evanlucas
Copy link
Contributor Author

@mhdawson
Copy link
Member

@Fishrock123 there was a specific failure with one of the PRs as opposed to a general issue. Right now not aware of any general issues on the PPC machines. I did investigate and since it seemed tied to the specific PR/machine and as we see has not recreated in the Ci run above suggested we proceed.

@evanlucas
Copy link
Contributor Author

evanlucas commented Jul 21, 2016

@mhdawson I'm pretty sure that issue was happening on more than just that PR, but doesn't look to be happening anymore. Thanks for digging into that!!!

Notable changes:

* **buffer**:
  * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
  * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**:
  * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
  * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641

PR-URL: #7782
@evanlucas
Copy link
Contributor Author

Ok, final CI before building binaries: https://ci.nodejs.org/job/node-test-pull-request/3376/

@evanlucas evanlucas merged commit 342a85b into v6.x Jul 21, 2016
@evanlucas evanlucas deleted the v6.3.1-proposal branch July 21, 2016 22:29
evanlucas added a commit that referenced this pull request Jul 21, 2016
Notable changes:

* **buffer**:
  * Improve performance of Buffer.from(str, 'hex') and Buffer#write(str, 'hex'). (Christopher Jeffrey) #7602
  * Fix creating from zero-length ArrayBuffer. (Ingvar Stepanyan) #7176
* **deps**:
  * Upgrade to V8 5.0.71.xx. (Ben Noordhuis) #7531
  * Backport V8 instanceof bugfix (Franziska Hinkelmann) #7638
* **repl**: Fix issue with function redeclaration. (Prince J Wesley) #7794
* **util**: Fix inspecting of boxed symbols. (Anna Henningsen) #7641

PR-URL: #7782
@bnoordhuis
Copy link
Member

@evanlucas When I suggested "Upgrade to V8 5.0.71.xx", the idea was to replace the .xx with the real patch level at the time of release. :-)

@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants