Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: link and highlight Object.assign #7670

Closed
wants to merge 1 commit into from
Closed

doc: link and highlight Object.assign #7670

wants to merge 1 commit into from

Conversation

thefourtheye
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc, util

Description of change

link and highlight Object.assign

cc @nodejs/documentation

@thefourtheye thefourtheye added util Issues and PRs related to the built-in util module. doc Issues and PRs related to the documentations. labels Jul 12, 2016
@mscdex
Copy link
Contributor

mscdex commented Jul 12, 2016

LGTM

3 similar comments
@cjihrig
Copy link
Contributor

cjihrig commented Jul 12, 2016

LGTM

@Fishrock123
Copy link
Contributor

LGTM

@addaleax
Copy link
Member

LGTM

@thefourtheye
Copy link
Contributor Author

Landed in 4b9a0e4

@thefourtheye thefourtheye deleted the code-highlight-object-assign branch July 13, 2016 01:45
thefourtheye added a commit that referenced this pull request Jul 13, 2016
@thefourtheye
doc: link and highlight Object.assign
4b9a0e4 
PR-URL: #7670
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
evanlucas pushed a commit that referenced this pull request Jul 15, 2016
@thefourtheye @evanlucas
doc: link and highlight Object.assign
58b70d3 
PR-URL: #7670
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@evanlucas evanlucas mentioned this pull request Jul 18, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. util Issues and PRs related to the built-in util module.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@thefourtheye @mscdex @cjihrig @Fishrock123 @addaleax @MylesBorins