tools: remove unnecessary imports and assignments #7483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
1 similar comment
|
LGTM |
|
LGTM, CI is green |
thefourtheye
force-pushed
the
remove-unused-imports
branch
2 times, most recently
from
7c1c672 to
f705a68
Compare
|
Removed few more unnecessary imports from |
|
Can you go over test/timers/testcfg.py while you're at it? It has a bunch of unused imports too. |
thefourtheye
force-pushed
the
remove-unused-imports
branch
from
f705a68 to
cfcbee6
Compare
|
@bnoordhuis Sure. Done! |
|
LGTM |
|
Landed in 89ede72 |
MylesBorins
pushed a commit
to MylesBorins/node
that referenced
this pull request
Jul 8, 2016
PR-URL: nodejs#7483 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
This doesn't land cleanly on v4.x and to be honest seems potentially error prone (at least cherry-picking). Adding a don't land tag @thefourtheye feel free to backport but I don't think it is high priority |
|
@thealphanerd This changes files introduced in #6088, and since that is marked as don't land, this also can be skipped. |
evanlucas
pushed a commit
that referenced
this pull request
Jul 13, 2016
PR-URL: #7483 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
tools
Description of change
remove unnecessary imports and assignments
CI Run: https://ci.nodejs.org/job/node-test-pull-request/3129/