-
Notifications
You must be signed in to change notification settings - Fork 29.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: align breakEvalOnSigint - repl option #7849
Conversation
@@ -392,7 +392,7 @@ added: v0.1.91 | |||
equivalent to prefacing every repl statement with `'use strict'`. | |||
* `repl.REPL_MODE_MAGIC` - attempt to evaluates expressions in default | |||
mode. If expressions fail to parse, re-try in strict mode. | |||
* `breakEvalOnSigint` - Stop evaluating the current piece of code when | |||
* `breakEvalOnSigint` - Stop evaluating the current piece of code when | |||
`SIGINT` is received, i.e. `Ctrl+C` is pressed. This cannot be used together | |||
with a custom `eval` function. Defaults to `false`. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you re-align the two subsequent lines, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no line break. View here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah, but they are still column-aligned in the raw markdown file.
LGTM with a comment |
LGTM, thanks! |
LGTM |
1 similar comment
LGTM |
Landed in c94887 |
PR-URL: #7849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
PR-URL: #7849 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: JungMinu - Minwoo Jung <jmwsoft@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
Affected core subsystem(s)
doc
Description of change
breakEvalOnSigint
option is wrongly aligned insidereplMode
.