Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix inconsistencies in code style #7915

Closed
wants to merge 1 commit into from
Closed

doc: fix inconsistencies in code style #7915

wants to merge 1 commit into from

Conversation

ravindrabarthwal
Copy link
Contributor

@ravindrabarthwal ravindrabarthwal commented Jul 29, 2016 •
edited
Loading

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Added missing semicolon

@nodejs-github-bot nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Jul 29, 2016
@mscdex
Copy link
Contributor

mscdex commented Jul 29, 2016

LGTM

3 similar comments
@JungMinu
Copy link
Member

LGTM

@jasnell
Copy link
Member

jasnell commented Jul 29, 2016

LGTM

@doron2402
Copy link

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Aug 1, 2016

LGTM. Landed in 1658297. Thanks!

@cjihrig cjihrig closed this Aug 1, 2016
cjihrig pushed a commit that referenced this pull request Aug 1, 2016
@ravindrabarthwal @cjihrig
doc: add missing semicolon
1658297 
PR-URL: #7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 8, 2016
Closed
cjihrig pushed a commit that referenced this pull request Aug 10, 2016
@ravindrabarthwal @cjihrig
doc: add missing semicolon
04ec64a 
PR-URL: #7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@cjihrig cjihrig mentioned this pull request Aug 11, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 11, 2016
@ravindrabarthwal
doc: add missing semicolon
c795494 
PR-URL: #7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@ravindrabarthwal @rvagg
doc: add missing semicolon
5b99dde 
PR-URL: #7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@ravindrabarthwal @MylesBorins
doc: add missing semicolon
65ca2af 
PR-URL: #7915
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@ravindrabarthwal @mscdex @JungMinu @jasnell @doron2402 @cjihrig @MylesBorins @nodejs-github-bot