Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: exclude tests for AIX #8076

Closed
wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

exclude tests for AIX in 4.x stream now that
its been added to regular regression runs. This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Aug 12, 2016
@joaocgreis
Copy link
Member

LGTM

CI: https://ci.nodejs.org/job/node-test-pull-request/3641/

As with #8065 , I believe this can be landed quickly.

cc @nodejs/lts

@jasnell
Copy link
Member

jasnell commented Aug 12, 2016

LGTM

@@ -31,3 +31,14 @@ test-tls-connect-address-family : PASS,FLAKY
# regressions until this work is complete
[$system==aix]
test-fs-watch-enoent : FAIL, PASS
# disable so we don't get failures now that AIX has been
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you capitalize "disable".

@cjihrig
Copy link
Contributor

cjihrig commented Aug 12, 2016

LGTM

Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.
mhdawson added a commit that referenced this pull request Aug 25, 2016
Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

PR-URL: #8076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@mhdawson
Copy link
Member Author

Landed as: 4bfb247

@mhdawson mhdawson closed this Aug 25, 2016
MylesBorins pushed a commit that referenced this pull request Sep 28, 2016
Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

PR-URL: #8076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

PR-URL: #8076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
Exclude tests for AIX in 4.x stream now that
its been added to regular regression runs.  This
will avoid known failures from making the build
look RED while also being able to catch any
new regressions if they are introduced.

PR-URL: #8076
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joao Reis <reis@janeasystems.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
@mhdawson mhdawson deleted the v4xaixflaky branch March 15, 2017 21:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants