Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: add assert.notDeepStrictEqual() tests #8177

Closed
wants to merge 1 commit into from
Closed

test: add assert.notDeepStrictEqual() tests #8177

wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Aug 19, 2016

Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test assert

Description of change

There is no test coverage for assert.notDeepStrictEqual(). Add some
minimal tests.

@Trott
test: add assert.notDeepStrictEqual() tests
1d8d60d 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.
@Trott Trott added assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests. labels Aug 19, 2016
@addaleax
Copy link
Member

LGTM with CI: https://ci.nodejs.org/job/node-test-commit/4661/

@jasnell
Copy link
Member

jasnell commented Aug 19, 2016

LGTM

Trott added a commit to Trott/io.js that referenced this pull request Aug 22, 2016
@Trott
test: add assert.notDeepStrictEqual() tests
181324e 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.

PR-URL: nodejs#8177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott
Copy link
Member Author

Trott commented Aug 22, 2016

Landed in 181324e

@Trott Trott closed this Aug 22, 2016
evanlucas pushed a commit that referenced this pull request Aug 24, 2016
@Trott @evanlucas
test: add assert.notDeepStrictEqual() tests
a6f8379 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.

PR-URL: #8177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@evanlucas evanlucas mentioned this pull request Aug 24, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@Trott
test: add assert.notDeepStrictEqual() tests
275386e 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.

PR-URL: #8177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@Trott @rvagg
test: add assert.notDeepStrictEqual() tests
6f68a79 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.

PR-URL: #8177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@Trott @MylesBorins
test: add assert.notDeepStrictEqual() tests
1c81c07 
There is no test coverage for `assert.notDeepStrictEqual()`. Add some
minimal tests.

PR-URL: #8177
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
@Trott Trott deleted the notDeepStrictEqual branch January 13, 2022 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
assert Issues and PRs related to the assert subsystem. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Trott @addaleax @jasnell @MylesBorins