build: fix depenencies on AIX #8272
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this.
nodejs-github-bot
added
the
build
|
I'm assuming we can land this quickly as it resolves a regular issue in the CI, is low risk, only affects AIX and should not be controversial in any way. |
|
@bnoordhuis, @Trott can you take a look and L.G.T.M, if appropriate |
Agreed that we should land it quickly. LGTM. (My gyp knowledge is limited but this is also a very limited change.) |
|
LGTM |
|
Commit message typo: LGTM |
|
LGTM |
@addaleax You seem to catch typos in commit messages more than anyone else (probably more than everyone else combined), which I really appreciate. 🎉 |
|
You mean we're actually supposed to be reading the commit messages!? ;-) |
mhdawson
added a commit
that referenced
this pull request
Aug 25, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
|
Landed as 063d14e |
Closed
Fishrock123
pushed a commit
to Fishrock123/node
that referenced
this pull request
Sep 8, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: nodejs#8239 PR-URL: nodejs#8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Fishrock123
pushed a commit
that referenced
this pull request
Sep 9, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins
pushed a commit
that referenced
this pull request
Sep 30, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 10, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
rvagg
pushed a commit
that referenced
this pull request
Oct 18, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
MylesBorins
pushed a commit
that referenced
this pull request
Oct 26, 2016
Addon tests were starting to run before the node exp file creation was complete. Add process_outputs_as_sources to avoid this. Fixes: #8239 PR-URL: #8272 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test nosign(Windows) passesAffected core subsystem(s)
build
Description of change
addon tests were starting to run before the node exp file
creation was complete. Add process_outputs_as_sources to
node_exp target to avoid this.
this.
Fixes: #8239