Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add return type of clientRequest.setTimeout #8356

Closed
wants to merge 1 commit into from
Closed

doc: add return type of clientRequest.setTimeout #8356

wants to merge 1 commit into from

Conversation

MikeRalphson
Copy link
Contributor

Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Document the return type of clientRequest.setTimeout
#1699 did not update documentation

@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. doc Issues and PRs related to the documentations. labels Aug 31, 2016
@jasnell
Copy link
Member

jasnell commented Aug 31, 2016

LGTM

1 similar comment
@lpinca
Copy link
Member

lpinca commented Aug 31, 2016

LGTM

@lpinca
Copy link
Member

lpinca commented Aug 31, 2016

@MikeRalphson can you please update the commit message?
It must be 50 chars or less all in lowercase and it should include the subsystem as prefix (doc:).
If it is too boring, don't worry, we will take care of it when landing.

@MikeRalphson MikeRalphson changed the title Document return type of clientRequest.setTimeout doc: add return type of clientRequest.setTimeout Aug 31, 2016
@MikeRalphson
Copy link
Contributor Author

@lpinca sorry, hopefully that's better (I assumed all lowercase didn't include refs to actual functions etc, from a browse of recent commits). First line of commit msg is now 48 chars.

@lpinca
Copy link
Member

lpinca commented Aug 31, 2016 •
edited
Loading

@MikeRalphson instead of "PR #1699 did not update documentation" I would use the "Refs:" metadata, that is Refs: https://github.com/nodejs/node/pull/1699, thanks!

@MikeRalphson
Copy link
Contributor Author

@lpinca commit message updated to use Refs: as above.

@cjihrig
Copy link
Contributor

cjihrig commented Sep 1, 2016

LGTM

@evanlucas
Copy link
Contributor

lgtm

lpinca pushed a commit to lpinca/node that referenced this pull request Sep 3, 2016
@MikeRalphson @lpinca
doc: add return type of clientRequest.setTimeout
7e8d994 
Refs: nodejs#1699
PR-URL: nodejs#8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@lpinca
Copy link
Member

lpinca commented Sep 3, 2016

Landed in 7e8d994

@lpinca lpinca closed this Sep 3, 2016
@Fishrock123 Fishrock123 mentioned this pull request Sep 6, 2016
Closed
Fishrock123 pushed a commit to Fishrock123/node that referenced this pull request Sep 8, 2016
@MikeRalphson @Fishrock123
doc: add return type of clientRequest.setTimeout
8a38353 
Refs: nodejs#1699
PR-URL: nodejs#8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Fishrock123 pushed a commit that referenced this pull request Sep 9, 2016
@MikeRalphson @Fishrock123
doc: add return type of clientRequest.setTimeout
ee83f5d 
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Sep 30, 2016
@MikeRalphson
doc: add return type of clientRequest.setTimeout
06e3f7f 
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Oct 10, 2016
@MikeRalphson
doc: add return type of clientRequest.setTimeout
9c05528 
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
rvagg pushed a commit that referenced this pull request Oct 18, 2016
@MikeRalphson @rvagg
doc: add return type of clientRequest.setTimeout
62ccc7a 
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
MylesBorins pushed a commit that referenced this pull request Oct 26, 2016
@MikeRalphson @MylesBorins
doc: add return type of clientRequest.setTimeout
c529bf5 
Refs: #1699
PR-URL: #8356
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Evan Lucas <evanlucas@me.com>
@MylesBorins MylesBorins mentioned this pull request Oct 26, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MikeRalphson @jasnell @lpinca @cjihrig @evanlucas @MylesBorins @nodejs-github-bot